Page MenuHomePhabricator
Create Task
Maniphest T303188

Wikilambda: Change errors Z542 or Z551 key creation to be types instead of strings
Closed, ResolvedPublic
Actions

Description

For:

  • ZErrorFactory.php:577
  • ZErrorFactory.php:616

When creating an instance of the errors Z542 or Z551, we should create Z4s instead of Z6s. These Z4s might be either ZReference or ZFunctionCall objects.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (225fe88)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (225fe88)mediawiki/extensions/WikiLambdamaster+0 -0
Update function-schemata sub-module to HEAD (3195378)mediawiki/services/function-orchestratormaster+1 -1
Fix overlap between type mismatch error typesmediawiki/extensions/WikiLambdamaster+9 -11
Fix overlap between Z542 and Z551mediawiki/services/function-schematamaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Mar 7 2022, 3:48 PM
DVrandecic moved this task from To Triage to Phase η – Generic types on the Abstract Wikipedia team board.Mar 8 2022, 5:14 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 8 2022, 5:17 PM
gengh changed the task status from Open to In Progress.Mar 17 2022, 10:22 AM
gengh claimed this task.
gengh moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team (Phase η – Generic types).Mar 17 2022, 6:04 PM
gerritbot added a comment.Mar 18 2022, 3:15 PM

Change 771931 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix overlap between type mismatch error types

https://gerrit.wikimedia.org/r/771931

gerritbot added a project: Patch-For-Review.Mar 18 2022, 3:15 PM
gerritbot added a comment.Mar 18 2022, 3:17 PM

Change 771932 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/services/function-schemata@master] Fix overlap between Z542 and Z551

https://gerrit.wikimedia.org/r/771932

gerritbot added a comment.Mar 24 2022, 7:46 PM

Change 771932 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Fix overlap between Z542 and Z551

https://gerrit.wikimedia.org/r/771932

Jdforrester-WMF mentioned this in rMSFS3669d1a6c055: Fix overlap between Z542 and Z551.Mar 24 2022, 7:46 PM
gerritbot added a comment.Mar 24 2022, 8:07 PM

Change 771931 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix overlap between type mismatch error types

https://gerrit.wikimedia.org/r/771931

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2022, 8:11 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 24 2022, 9:00 PM
gerritbot added a comment.Mar 29 2022, 6:34 PM

Change 774949 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (225fe88)

https://gerrit.wikimedia.org/r/774949

gerritbot added a project: Patch-For-Review.Mar 29 2022, 6:34 PM

Change 774950 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (225fe88)

https://gerrit.wikimedia.org/r/774950

gerritbot added a comment.Mar 31 2022, 7:18 PM

Change 773496 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (d668209)

https://gerrit.wikimedia.org/r/773496

gerritbot added a comment.Mar 31 2022, 11:45 PM

Change 773496 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (3195378)

https://gerrit.wikimedia.org/r/773496

Jdforrester-WMF mentioned this in rMSFO3effccc2bb2e: Update function-schemata sub-module to HEAD (3195378).Mar 31 2022, 11:45 PM
gengh moved this task from Phase θ – Throttling to Phase η – Generic types on the Abstract Wikipedia team board.Apr 1 2022, 1:48 PM
gengh edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team (Phase θ – Throttling).
gengh moved this task from In progress to Code Review on the Abstract Wikipedia team (Phase η – Generic types) board.
gengh moved this task from Code Review to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.
gerritbot added a comment.Apr 4 2022, 7:18 PM

Change 774949 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (225fe88)

Reason:

https://gerrit.wikimedia.org/r/774949

gerritbot added a comment.Apr 4 2022, 7:24 PM

Change 774950 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (225fe88)

https://gerrit.wikimedia.org/r/774950

Jdforrester-WMF mentioned this in rMSFEcbfe31fa2b78: Update function-schemata sub-module to HEAD (225fe88).Apr 4 2022, 7:25 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 4 2022, 7:30 PM
Jdforrester-WMF closed this task as Resolved.Apr 6 2022, 2:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits