Maniphest T303194

Gadgets extensions should not cache serialized PHP objects
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Mar 7 2022, 4:19 PM

Tags

Referenced Files

None

Subscribers

Tokens

"Mountain of Wealth" token, awarded by Reedy.

Description

As per T161647: RFC: Deprecate using php serialization inside MediaWiki.

Recent change that motivates this task:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Gadgets/+/768274

Details

	Subject	Repo	Branch	Lines +/-
	tests: Enforce parity between Gadget::serializeDefinition and toArray	mediawiki/extensions/Gadgets	master	+36 -29
	Avoid caching serialized PHP object	mediawiki/extensions/Gadgets	master	+99 -17

Customize query in gerrit

Related Objects

Mentioned In: T303391: Flag-day change (cached values incompatible) in Gadgets extension brought translatewiki.net down
Mentioned Here: T161647: RFC: Deprecate using php serialization inside MediaWiki

Event Timeline

Krinkle created this task.Mar 7 2022, 4:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2022, 4:19 PM

Reedy awarded a token.Mar 7 2022, 4:29 PM

Nikerabbit mentioned this in T303391: Flag-day change (cached values incompatible) in Gadgets extension brought translatewiki.net down.Mar 9 2022, 1:35 PM

SD0001 claimed this task.Aug 27 2022, 10:48 AM

Change 826943 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/Gadgets@master] Avoid caching serialized PHP object

https://gerrit.wikimedia.org/r/826943

gerritbot added a project: Patch-For-Review.Aug 27 2022, 11:28 AM

Change 826943 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Avoid caching serialized PHP object

https://gerrit.wikimedia.org/r/826943

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 22 2023, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2023, 7:10 AM

Change 959349 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Gadgets@master] tests: Enforce parity between Gadget::serializeDefinition and toArray

https://gerrit.wikimedia.org/r/959349

gerritbot added a project: Patch-For-Review.Sep 20 2023, 9:41 PM

Change 959349 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] tests: Enforce parity between Gadget::serializeDefinition and toArray

https://gerrit.wikimedia.org/r/959349

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Sep 21 2023, 6:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2023, 6:10 AM

SD0001 closed this task as Resolved.Oct 24 2023, 9:48 AM