neilk wrote:

This bug is only hit if you are trying to upload a file with both the same filename and the same content.

The problem is that the API returns only one error at a time. It believes that same-filename error is more important, so it returns that one. Conversely, we believe that same filename isn't important yet (since we plan to surface that problem later), so we ignore it.

Solution?

• swap the priority of those messages in the API ?

• give the API some placeholder random filename for now so same-filename isn't even triggered at this point? We suppress the error if it occurs anyway.

We could check for same hash separately:
api.php?action=query&list=allimages&format=json&aisha1=<hash>
...and make sure the number of matches is 0.

neilk wrote:

fixed in r85683

used placeholder semi-random filename