Page MenuHomePhabricator
Create Task
Maniphest T303209

Make Vector skin installed by default in Canasta
Closed, ResolvedPublic
Actions

Description

Canasta is a MediaWiki-based Docker image:

https://github.com/WikiWorks/Canasta

Its Dockerfile does a variety of things, one of which is to add the line "#cfLoadSkin()" to LocalSettings.php for every skin that is included in Canasta:

https://github.com/WikiWorks/Canasta/blob/master/Dockerfile

In other words, it adds commented-out lines, so that the admin can include them if they want to. This is fine - but one skin, Vector, should be included by default, i.e., not start with "#".

This is a Google-Summer-of-Code 2022 microtask for T301893.

Related Objects

Event Timeline

Yaron_Koren created this task.Mar 7 2022, 7:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2022, 7:10 PM
Yaron_Koren mentioned this in T301893: Command-line interface (CLI) for Canasta.Mar 7 2022, 7:31 PM
Aklapper added a project: Google-Summer-of-Code (2022).Mar 7 2022, 8:05 PM
Aklapper updated the task description. (Show Details)
Mhmohona subscribed.Mar 8 2022, 3:01 AM
Amalpaultech subscribed.Mar 8 2022, 12:30 PM
Amalpaultech added a comment.Mar 9 2022, 1:11 PM

I did work on this task and works in my environment. Had to change the docker-compose to use my personal image to test this. I used
sed to uncomment the line. Here is my work. Please do give your suggestion for me to improve on.

Yaron_Koren added a comment.Mar 13 2022, 1:42 AM

@Amalpaultech - sorry for the delay. That's a clever solution! Could you just add a comment above that line, explaining what it's doing?

Amalpaultech added a comment.EditedMar 13 2022, 2:35 AM

@Yaron_Koren It's fine. I will get the comment added, and thanks for your suggestion.
EDIT: Here is the updated work

Yaron_Koren added a comment.Mar 14 2022, 8:13 PM

Okay, this looks pretty good. Could you create a pull request for this change?

Amalpaultech added a comment.Mar 15 2022, 2:48 AM

Yeah Sure.

srishakatux moved this task from Backlog to Microtasks on the Google-Summer-of-Code (2022) board.Mar 30 2022, 12:44 AM
srishakatux closed this task as Resolved.Sep 20 2022, 9:42 PM
srishakatux subscribed.

This task seems to have been resolved as per Github. Closing for now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL