Add "-username" option to approveAllPages.php
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	Yaron_Koren
	Mar 7 2022, 7:24 PM

Description

The approveAllPages.php in the Approved Revs extension marks the latest revision of all pages in the wiki as the approved one. Currently, every such approval shows up in the wiki (for example, in Special:RecentChanges) as having been done by localhost, i.e "127.0.0.1". It would be good to add to this script a "-username" option, so that whoever is running the script can specify a user account that is responsible for these approvals (preferably, their own account). Please make sure that this works even for usernames containing spaces.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Added username support for approveAllPages.php	mediawiki/extensions/ApprovedRevs	master	+17 -3
	Add command line argument for specifying username	mediawiki/extensions/ApprovedRevs	master	+13 -2

Customize query in gerrit

Related Objects

Mentioned In: T301893: Command-line interface (CLI) for Canasta

Event Timeline

Yaron_Koren created this task.Mar 7 2022, 7:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2022, 7:24 PM

Yaron_Koren mentioned this in T301893: Command-line interface (CLI) for Canasta.Mar 7 2022, 7:31 PM

Assuming this is a feature request.

Mhmohona subscribed.Mar 8 2022, 3:01 AM

Amalpaultech subscribed.Mar 9 2022, 1:15 PM

Change 770007 had a related patch set uploaded (by Techwizzie; author: Techwizzie):

[mediawiki/extensions/ApprovedRevs@master] Add command line argument for specifying username

https://gerrit.wikimedia.org/r/770007

gerritbot added a project: Patch-For-Review.Mar 11 2022, 5:15 PM

Change 770007 abandoned by Techwizzie:

[mediawiki/extensions/ApprovedRevs@master] Add command line argument for specifying username

Reason:

https://gerrit.wikimedia.org/r/770007

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2022, 6:10 PM

Change 770101 had a related patch set uploaded (by TechieNK; author: TechieNK):

[mediawiki/extensions/ApprovedRevs@master] Added username support for approveAllPages.php

https://gerrit.wikimedia.org/r/770101

gerritbot added a project: Patch-For-Review.Mar 12 2022, 6:13 PM

TechieNK subscribed.Mar 12 2022, 6:13 PM

@Yaron_Koren I've uploaded a patch for this microtask. Please check out.

This looks pretty good! The PHP formatting just needs some work.

In T303214#7771740, @Yaron_Koren wrote:

This looks pretty good! The PHP formatting just needs some work.

I've made the changes related to formatting, now. Also, it seems that the other two microtasks are already pretty much done by others. Is there some more microtasks available?

TechieNK claimed this task.Mar 14 2022, 4:44 AM

Great. Not yet, unfortunately.

Hi, Is this fine or Should I change something?

Sorry for the misunderstanding - I was wondering what was going on with this. I think the patch still needs to be fixed, to handle a username of "0" and potentially other usernames where the empty() call would return the wrong thing.

Change 770101 merged by jenkins-bot: