Page MenuHomePhabricator
Create Task
Maniphest T303224

[wmf.24] hewiki - RTL oo-ui-icon-mentor icon is used for Mentorship module
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
• mewoph
Authored By
Etonkovidova
Mar 7 2022, 9:05 PM
Tags
Referenced Files
F35174375: Screen Shot 2022-05-24 at 5.21.16 PM.png
May 25 2022, 12:33 AM
F35174401: Screen Shot 2022-05-24 at 5.32.16 PM.png
May 25 2022, 12:33 AM
F35174377: Screen Shot 2022-05-24 at 5.23.01 PM.png
May 25 2022, 12:33 AM
F35170747: Screen Shot 2022-05-23 at 3.46.04 PM.png
May 23 2022, 10:51 PM
F35170743: Screen Shot 2022-05-23 at 1.44.58 PM.png
May 23 2022, 10:51 PM
F35170741: Screen Shot 2022-05-23 at 1.45.10 PM.png
May 23 2022, 10:51 PM
F35170745: Screen Shot 2022-05-23 at 3.46.28 PM.png
May 23 2022, 10:51 PM
F34994447: Screen Shot 2022-03-09 at 4.54.37 PM.png
Mar 10 2022, 12:55 AM
View All 9 Files
Subscribers
Aklapper
Amire80
Etonkovidova
kostajh
• mewoph
MMiller_WMF
Sgs
Tgr

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Login to hewiki as a user with enabled Homepage
  • On Special:Homepage the icon in the mentorship module (oo-ui-icon-mentor) will be displayed as the RTL variant icon.

Screen Shot 2022-03-07 at 12.46.31 PM.png (1×1 px, 97 KB)

Details

SubjectRepoBranchLines +/-
Mentorship: Use LTR icon for Hebrewmediawiki/extensions/GrowthExperimentsmaster+16 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Mar 7 2022, 9:05 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 7 2022, 9:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• mewoph added a comment.Mar 8 2022, 12:01 AM

I think in this case we should use the LTR version for Hebrew (similar to T296438: [arwiki] Add image - a question mark not in RTL format )

kostajh triaged this task as Low priority.Mar 8 2022, 12:20 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh edited projects, added GrowthExperiments-Mentorship; removed GrowthExperiments.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova added a comment.Mar 10 2022, 12:55 AM

For testing after the fix - check the Help panel too:

Screen Shot 2022-03-09 at 4.54.37 PM.png (1×758 px, 85 KB)

MShilova_WMF moved this task from New Tasks to Backlog on the GrowthExperiments-Mentorship board.Apr 15 2022, 4:11 PM
Etonkovidova added a parent task: T289013: [hewiki] Mentorship module incorrectly uses RTL icon variant .May 5 2022, 1:21 AM
• mewoph claimed this task.May 23 2022, 10:46 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 23 2022, 10:51 PM

Change 797586 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Mentorship: Use LTR icon for Hebrew

https://gerrit.wikimedia.org/r/797586

gerritbot added a project: Patch-For-Review.May 23 2022, 10:51 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 23 2022, 10:51 PM
Usagearhe
Homepage
Screen Shot 2022-05-23 at 1.45.10 PM.png (540×808 px, 40 KB)
Screen Shot 2022-05-23 at 1.44.58 PM.png (546×828 px, 44 KB)
Help panel
Screen Shot 2022-05-23 at 3.46.28 PM.png (252×686 px, 24 KB)
Screen Shot 2022-05-23 at 3.46.04 PM.png (264×690 px, 24 KB)
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 24 2022, 8:47 AM
gerritbot added a comment.May 24 2022, 9:11 AM

Change 797586 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentorship: Use LTR icon for Hebrew

https://gerrit.wikimedia.org/r/797586

Maintenance_bot removed a project: Patch-For-Review.May 24 2022, 9:31 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 24 2022, 10:00 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.EditedMay 25 2022, 12:33 AM

Checked in betalabs with uselang=he - the fix is in place.

Screen Shot 2022-05-24 at 5.21.16 PM.png (858×948 px, 72 KB)
Screen Shot 2022-05-24 at 5.23.01 PM.png (828×730 px, 65 KB)
mobile
Screen Shot 2022-05-24 at 5.32.16 PM.png (1×530 px, 67 KB)

Testing note:

  • in wmf.14 check "oo-ui-iconElement-icon oo-ui-icon-mentor oo-ui-image-progressive" in "Assign a mentor"
• mewoph merged a task: T260283: Special:Homepage shows a reverse question mark in mentor userpage icon in the Hebrew Wikipedia.Jun 1 2022, 9:46 PM
• mewoph added subscribers: Amire80, MMiller_WMF.
Etonkovidova closed this task as Resolved.Jun 2 2022, 12:14 AM
In T303224#7954976, @Etonkovidova wrote:

Testing note:

  • in wmf.14 check "oo-ui-iconElement-icon oo-ui-icon-mentor oo-ui-image-progressive" in "Assign a mentor"

Filed as T309749

Sgs mentioned this in T287248: [BUG] Inconsistent question mark graphics in RTL languages in mobile web GrowthExperiments editing help panel.Nov 30 2022, 11:51 AM
Maintenance_bot moved this task from Backlog to In Progress on the GrowthExperiments-Mentorship board.Nov 30 2022, 12:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL