Page MenuHomePhabricator

Refactor envoy access_log_path to access loggers
Closed, ResolvedPublic

Description

From the 1.18.0 release notes:

admin: access_log_path is deprecated in favor for access loggers.

I think we're mostly only using access loggers ever since we moved to the v3 config API, but access_log_path still has some hits, which we should convert.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
RLazarus triaged this task as Medium priority.Mar 7 2022, 11:04 PM

Change 769807 had a related patch set uploaded (by RLazarus; author: RLazarus):

[operations/puppet@production] envoyproxy: Migrate from access_log_path field to FileAccessLog API

https://gerrit.wikimedia.org/r/769807

Change 915458 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] Refactor envoy access_log_path to access loggers

https://gerrit.wikimedia.org/r/915458

Change 915458 merged by jenkins-bot:

[operations/deployment-charts@master] Refactor envoy access_log_path to access loggers

https://gerrit.wikimedia.org/r/915458

Change 769807 merged by JMeybohm:

[operations/puppet@production] envoyproxy: Migrate from access_log_path field to FileAccessLog API

https://gerrit.wikimedia.org/r/769807

Done in deployment-charts and puppet