Page MenuHomePhabricator
Create Task
Maniphest T303262

Headings and other elements look different after saving the page using VisualEditor or DiscussionTools
Closed, ResolvedPublic
Actions

Description

Headings and other elements look different after saving the page using VisualEditor or DiscussionTools while using new Vector. For example, on this page: https://en.wikipedia.beta.wmflabs.org/wiki/Crepuscular

After opening the pageAfter saving changes
image.png (2×3 px, 1 MB)
image.png (2×3 px, 1 MB)

A few things render incorrectly – most noticeable the headings are offset, but also the icon in the Wiktionary template is missing.

Apparently this is because MobileFrontend transformations are kicking in:

image.png (2×3 px, 918 KB)

Details

SubjectRepoBranchLines +/-
Fix handling of disabled 'mobileformat'mediawiki/extensions/VisualEditorwmf/1.38.0-wmf.25+5 -2
Fix handling of disabled 'mobileformat'mediawiki/extensions/DiscussionToolswmf/1.38.0-wmf.25+7 -3
Fix handling of disabled 'mobileformat'mediawiki/extensions/VisualEditormaster+5 -2
Fix handling of disabled 'mobileformat'mediawiki/extensions/DiscussionToolsmaster+7 -3
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Mar 8 2022, 12:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2022, 12:49 PM
matmarex claimed this task.Mar 8 2022, 12:55 PM
matmarex edited projects, added Editing-team (Kanban Board); removed MobileFrontend, Vector (legacy skin).
gerritbot added a comment.Mar 8 2022, 1:01 PM

Change 769039 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/769039

gerritbot added a project: Patch-For-Review.Mar 8 2022, 1:01 PM

Change 769040 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/769040

matmarex renamed this task from Headings and other elements look different after saving the page using VisualEditor or DiscussionTools while using new Vector to Headings and other elements look different after saving the page using VisualEditor or DiscussionTools.Mar 8 2022, 1:06 PM
• ppelberg moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Mar 8 2022, 4:36 PM
• ppelberg subscribed.
gerritbot added a comment.Mar 8 2022, 5:46 PM

Change 769039 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/769039

gerritbot added a comment.Mar 8 2022, 5:46 PM

Change 769040 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/769040

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 8 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 8 2022, 6:10 PM
gerritbot added a comment.Mar 8 2022, 9:03 PM

Change 768802 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.25] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/768802

gerritbot added a comment.Mar 8 2022, 9:03 PM

Change 768803 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.25] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/768803

gerritbot added a project: Patch-For-Review.Mar 8 2022, 9:03 PM
gerritbot added a comment.Mar 8 2022, 9:21 PM

Change 768803 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.25] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/768803

gerritbot added a comment.Mar 8 2022, 9:21 PM

Change 768802 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.25] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/768802

Stashbot added a comment.Mar 8 2022, 9:26 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-08T21:26:19Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/VisualEditor/includes/ApiVisualEditorEdit.php: rEVEDa5c6d06714d7: Fix handling of disabled mobileformat (T303262) (duration: 00m 49s)

Stashbot added a comment.Mar 8 2022, 9:28 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-08T21:28:09Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/DiscussionTools/includes/ApiDiscussionToolsEdit.php: cc5acc27ad02f473b001d088dba454e013129cb2: Fix handling of disabled mobileformat (T303262) (duration: 00m 49s)

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 8 2022, 9:54 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 8 2022, 10:00 PM
EAkinloose edited projects, added Verified; removed Editing QA.Mar 9 2022, 10:09 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Mar 10 2022, 4:16 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Mar 10 2022, 4:17 PM
• ppelberg closed this task as Resolved.Mar 18 2022, 1:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL