Page MenuHomePhabricator

Headings and other elements look different after saving the page using VisualEditor or DiscussionTools
Closed, ResolvedPublic

Description

Headings and other elements look different after saving the page using VisualEditor or DiscussionTools while using new Vector. For example, on this page: https://en.wikipedia.beta.wmflabs.org/wiki/Crepuscular

After opening the pageAfter saving changes
image.png (2×3 px, 1 MB)
image.png (2×3 px, 1 MB)

A few things render incorrectly – most noticeable the headings are offset, but also the icon in the Wiktionary template is missing.

Apparently this is because MobileFrontend transformations are kicking in:

image.png (2×3 px, 918 KB)

Event Timeline

Change 769039 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/769039

Change 769040 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/769040

matmarex renamed this task from Headings and other elements look different after saving the page using VisualEditor or DiscussionTools while using new Vector to Headings and other elements look different after saving the page using VisualEditor or DiscussionTools.Mar 8 2022, 1:06 PM

Change 769039 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/769039

Change 769040 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/769040

Change 768802 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.25] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/768802

Change 768803 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.25] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/768803

Change 768803 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.25] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/768803

Change 768802 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.25] Fix handling of disabled 'mobileformat'

https://gerrit.wikimedia.org/r/768802

Mentioned in SAL (#wikimedia-operations) [2022-03-08T21:26:19Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/VisualEditor/includes/ApiVisualEditorEdit.php: a5c6d06714d76d84fac270e3dac4a4a0a2d83927: Fix handling of disabled mobileformat (T303262) (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2022-03-08T21:28:09Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/DiscussionTools/includes/ApiDiscussionToolsEdit.php: cc5acc27ad02f473b001d088dba454e013129cb2: Fix handling of disabled mobileformat (T303262) (duration: 00m 49s)