Page MenuHomePhabricator
Create Task
Maniphest T303303

Change the pre-defined core types to use typed lists and not general lists
Closed, ResolvedPublic
Actions

Description

Update:

  • CANONICAL schemata: https://gerrit.wikimedia.org/r/c/mediawiki/services/function-schemata/+/764439
    • Z4K2 to take a list of Z3s
    • Z50K1 to take a list of Z3s
    • Z8K1 to take a list of Z17s
    • Z8K2 to take a list of Z20s
    • Z8K3 to take a list of Z14s
    • Z12K1 to take a list of Z11s
    • Z60K2 to take a list of Z6s
    • Z31K2 to take a list of Z6s
    • Z32K1 to take a list of Z31s
  • add tests to canonical_zobject to include typed lists
    • list of Z3s tests (as part of Z4)
    • list of Z14s tests (as part of Z8)
    • list of Z17s tests (as part of Z8)
    • list of Z20s tests (as part of Z8)
    • list of Z11s tests (as part of Z12)
    • list of Z6s tests (as part of Z60)
    • list of Z31s tests (as part of Z32)
  • NORMAL schemata: https://gerrit.wikimedia.org/r/c/mediawiki/services/function-schemata/+/767777/
    • Z4K2 to take a list of Z3s
    • Z50K1 to take a list of Z3s
    • Z8K1 to take a list of Z17s
    • Z8K2 to take a list of Z20s
    • Z8K3 to take a list of Z14s
    • Z12K1 to take a list of Z11s
    • Z60K2 to take a list of Z6s
    • Z31K2 to take a list of Z6s
    • Z32K1 to take a list of Z31s
  • add tests to normal_zobject to include typed lists
    • list of Z3s tests (as part of Z4)
    • list of Z14s tests (as part of Z8)
    • list of Z17s tests (as part of Z8)
    • list of Z20s tests (as part of Z8)
    • list of Z11s tests (as part of Z12)
    • list of Z6s tests (as part of Z60)
    • list of Z31s tests (as part of Z32)
  • JSON definitions
    • Not applicable, as the JSON definitions have canonical form (so JSON arrays instead of typed lists)

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (3195378)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (e98f603)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (e98f603)mediawiki/extensions/WikiLambdamaster+1 -1
Add support for normal generic listsmediawiki/services/function-schematamaster+1 K -84
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedcmassaroT290898 Implement (De)Serialization for Generic/Compound Types
 DeclinedNoneT287608 Reconsider dropping Nothing and Unit in favor of Maybe
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedcmassaroT288555 Support serialisation/deserialisation of user-defined types
 ResolvedcmassaroT287263 Deserialize Objects in Evaluator Based on Z7K1.Z8K2
 ResolvedNoneT275941 Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types")
 ResolvedgenghT277000 Validate a Z7/Function call in the wiki
 ResolvedgenghT281386 Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code
 DeclinedLindsaykwardellT282745 Add function-schemata to frontend in order to remedy hybrid forms
 ResolvedLindsaykwardellT282816 Use canonicalizer to display JSON
 ResolvedcmassaroT284474 Add tests for normalize/canonicalize code in frontend.
 ResolvedcmassaroT284764 Fix Canonicalization Code in Frontend to Handle Z6s That Masquerade as Z9s
 ResolvedNoneT291033 A function call used as an argument should validate its return type against the expected type of the argument
 ResolvedNoneT291034 Every argument of a function call with a literal or reference should be of a type compatible for that argument
 ResolvedgenghT287700 Make error generation code produce an understandable result when called with non-existent arguments
 ResolvedcmassaroT291032 Arguments taking a function should validate functions as values
 ResolvedJdforrester-WMFT293663 Fix instancePath vs. dataPath in function-schemata, Add Tests
 ResolvedSimoneThisDotT291023 Instances of user-defined types can be entered using the default component
 ResolvedJdforrester-WMFT291029 Instances of a user-defined type can be edited
 ResolvedDVrandecicT291025 Make it possible to define and implement functions using user-defined types as output or an input type
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 ResolvedNoneT273124 Use evaluation for validation
 ResolvedcmassaroT260321 Allow users to trigger function calls for built-in functions (orchestrator-only)
 ResolvedDVrandecicT261964 Agree on architecture for first evaluation engine
 ResolvedLindsaykwardellT280558 Normalize Inputs to Orchestrator
 ResolvedarthurlorenziT275095 Move normalization and canonicalization code to function-schemata
 ResolvedNoneT262770 Normalize ZObjects
 InvalidNoneT280559 Retrieve Function Signature from Orchestrator
 ResolvedcmassaroT282843 Hook up orchestrator to the evaluator and pass through appropriately-dereferenced Z7 calls
 ResolvedcmassaroT271762 Create initial Function Evaluator service
 ResolvedcmassaroT269697 Turn Function Evaluator into a service
 ResolvedcmassaroT269698 Make Function Evaluator work async
 ResolvedcmassaroT272630 Define interface for the function-evaluator
 ResolvedJdforrester-WMFT276478 Provide "semantically peel-able" list of programming languages that we allow
 ResolvedcmassaroT273515 Create Execution Environments for Supported Languages
 ResolvedcmassaroT273517 Create Execution Environment for Python
 ResolvedcmassaroT275944 Create Execution Environment for JavaScript
 ResolvedNoneT261470 Sandboxing and monitoring of evaluations
 ResolvedSimoneThisDotT291022 Validators for user-defined types can be defined and linked
 ResolvedSimoneThisDotT291021 Make the UX for creating a user-defined type straightforward
 ResolvedSimoneThisDotT292891 Provide a custom UX for Z4/Type
 ResolvedJdforrester-WMFT291031 Validator implementations can call Z101/object validator, and then add to it
 ResolvedcmassaroT262997 Validate the values on the keys on a user-defined type
 ResolvedgenghT287734 Replace wikilambda extension php validation code with call to schemata validation
 ResolvedcmassaroT276369 Create PHP bindings for function-schemata
 ResolvedJdforrester-WMFT293831 WikiLambda documentation should explain how to get composer dependencies installed, lest users have missing ISchemaLoader fatals
 ResolvedcmassaroT291030 Validator of a user-defined type can be implemented
 ResolvedcmassaroT291026 Let user implementations throw a user-defined error during a user-defined validation
 ResolvedNoneT291027 Users can create error types
 ResolvedDVrandecicT293423 Create a function that turns an error type into a type
 ResolvedcmassaroT289687 Allow users to create instances of errors in composition
 ResolvedarthurlorenziT290346 Function model: Change the signature of validators from Type -> List to Type -> Type (pass-through)
 Resolved• AdesojiThisDotT293742 Navigate to "provide tests" after user define function, instead than to the newly defined object
 ResolvedJdforrester-WMFT286974 Make it possible to implement Map function
 ResolvedNoneT291040 Generic functions
 InvalidNoneT291037 Function model: update functions to the new generic types
 InvalidgenghT291038 Function model: updates to the data model to implement generic types
 Resolved• JKiesermanT303303 Change the pre-defined core types to use typed lists and not general lists
 ResolvedNoneT291045 Function created by a generic function call can be evaluated
 ResolvedJdforrester-WMFT291046 Generic functions can be evaluated
 ResolvedNoneT291047 Generic functions can be implemented
 ResolvedNoneT291048 Generic functions can be defined
 DeclinedNoneT291036 Function model: Z8 should change from a type to a function taking a type and a list of types and returning a type
 ResolvedSimoneThisDotT291041 Instances of a generic type are displayed correctly
 ResolvedSimoneThisDotT291042 Instances of generic types can be edited
 ResolvedcmassaroT291044 Instances of generic types are being validated
 ResolvedcmassaroT285260 Orchestrator Top-Level Validation Should Check Z1K1
 ResolvedSimoneThisDotT297244 Let front-end users create and edit instances of any generic type
 ResolvedSimoneThisDotT291043 Instances of generic typed lists can be created
 ResolvedcmassaroT266241 Normalizer and canonicalizer should deal with local and global keys
 ResolvedcmassaroT289681 Composition creating a type doesn't evaluate
 ResolvedBUG REPORTJdforrester-WMFT292890 Trying to create a Z14 throws "Cannot read properties of undefined (reading 'filter')" in Vue code
 ResolvedSimoneThisDotT295470 Change the type search API to allow users to search for functions returning a type in addition to instances of that type
 ResolvedgenghT262089 Store type identity output in wikilambda_zobject_labels table
ResolvedgenghT297925 Change object search API to optionally include functions' return types as the 'type' filter
 ResolvedcmassaroT286975 Make it possible to define the Typed List function fully
 ResolvedcmassaroT287102 Resolve Z18s Wherever They Occur
 ResolvedJdforrester-WMFT291049 Function that takes a type and returns a type can be evaluated
 ResolvedDVrandecicT291050 Functions that take a type and return a type can be implemented
 ResolvedDVrandecicT291051 Functions that take a type and return a type can be defined

Event Timeline

Jdforrester-WMF removed DVrandecic as the assignee of this task.Mar 8 2022, 5:37 PM
Jdforrester-WMF created this task.
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 8 2022, 5:38 PM
gengh assigned this task to • JKieserman.Mar 17 2022, 10:00 AM
gengh subscribed.

This is done for CANONICAL, and work for NORMAL form is ongoing.

gengh changed the task status from Open to In Progress.Mar 17 2022, 10:01 AM
gengh moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
Jdforrester-WMF updated the task description. (Show Details)Mar 17 2022, 5:22 PM
Jdforrester-WMF updated the task description. (Show Details)
gengh updated the task description. (Show Details)Mar 17 2022, 5:24 PM
gerritbot added a comment.Mar 17 2022, 7:58 PM

Change 767777 had a related patch set uploaded (by Genoveva Galarza; author: Jkieserman):

[mediawiki/services/function-schemata@master] [WIP] Add support for normal generic lists

https://gerrit.wikimedia.org/r/767777

gerritbot added a project: Patch-For-Review.Mar 17 2022, 7:58 PM
• JKieserman updated the task description. (Show Details)Mar 23 2022, 5:25 PM
• JKieserman moved this task from In progress to Code Review on the Abstract Wikipedia team (Phase η – Generic types) board.
• JKieserman mentioned this in T291038: Function model: updates to the data model to implement generic types.
gengh updated the task description. (Show Details)Mar 23 2022, 6:03 PM
gerritbot added a comment.Mar 23 2022, 6:12 PM

Change 767777 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add support for normal generic lists

https://gerrit.wikimedia.org/r/767777

gengh mentioned this in rMSFSd56b4a544dc0: Add support for normal generic lists.Mar 23 2022, 6:12 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 23 2022, 7:10 PM
gerritbot added a comment.Mar 24 2022, 1:16 PM

Change 773496 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773496

gerritbot added a project: Patch-For-Review.Mar 24 2022, 1:16 PM

Change 773497 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773497

gerritbot added a comment.Mar 24 2022, 1:16 PM

Change 773498 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773498

Jdforrester-WMF moved this task from Code Review to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 24 2022, 2:41 PM

Except for the pull-throughs landing (blocked by other work), this is Resolved, I think?

gengh added a comment.Mar 28 2022, 9:00 AM

Yes!

gerritbot added a comment.Mar 29 2022, 5:59 PM

Change 773498 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773498

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 29 2022, 6:00 PM
gerritbot added a comment.Mar 29 2022, 6:04 PM

Change 773497 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773497

Jdforrester-WMF mentioned this in rMSFEbe04613d2f86: Update function-schemata sub-module to HEAD (e98f603).Mar 29 2022, 6:07 PM
gerritbot added a comment.Mar 31 2022, 11:45 PM

Change 773496 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (3195378)

https://gerrit.wikimedia.org/r/773496

Jdforrester-WMF mentioned this in rMSFO3effccc2bb2e: Update function-schemata sub-module to HEAD (3195378).Mar 31 2022, 11:45 PM
Jdforrester-WMF closed this task as Resolved.Apr 6 2022, 2:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL