Page MenuHomePhabricator

Change the pre-defined core types to use typed lists and not general lists
Closed, ResolvedPublic

Description

Update:

  • CANONICAL schemata: https://gerrit.wikimedia.org/r/c/mediawiki/services/function-schemata/+/764439
    • Z4K2 to take a list of Z3s
    • Z50K1 to take a list of Z3s
    • Z8K1 to take a list of Z17s
    • Z8K2 to take a list of Z20s
    • Z8K3 to take a list of Z14s
    • Z12K1 to take a list of Z11s
    • Z60K2 to take a list of Z6s
    • Z31K2 to take a list of Z6s
    • Z32K1 to take a list of Z31s
  • add tests to canonical_zobject to include typed lists
    • list of Z3s tests (as part of Z4)
    • list of Z14s tests (as part of Z8)
    • list of Z17s tests (as part of Z8)
    • list of Z20s tests (as part of Z8)
    • list of Z11s tests (as part of Z12)
    • list of Z6s tests (as part of Z60)
    • list of Z31s tests (as part of Z32)
  • NORMAL schemata: https://gerrit.wikimedia.org/r/c/mediawiki/services/function-schemata/+/767777/
    • Z4K2 to take a list of Z3s
    • Z50K1 to take a list of Z3s
    • Z8K1 to take a list of Z17s
    • Z8K2 to take a list of Z20s
    • Z8K3 to take a list of Z14s
    • Z12K1 to take a list of Z11s
    • Z60K2 to take a list of Z6s
    • Z31K2 to take a list of Z6s
    • Z32K1 to take a list of Z31s
  • add tests to normal_zobject to include typed lists
    • list of Z3s tests (as part of Z4)
    • list of Z14s tests (as part of Z8)
    • list of Z17s tests (as part of Z8)
    • list of Z20s tests (as part of Z8)
    • list of Z11s tests (as part of Z12)
    • list of Z6s tests (as part of Z60)
    • list of Z31s tests (as part of Z32)
  • JSON definitions
    • Not applicable, as the JSON definitions have canonical form (so JSON arrays instead of typed lists)

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
StalledNone
Resolvedcmassaro
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
Resolvedcmassaro
OpenNone
ResolvedNone
ResolvedNone
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
Resolvedgengh
Resolvedgengh
DeclinedLindsaykwardell
ResolvedLindsaykwardell
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedNone
Resolvedgengh
Resolvedcmassaro
ResolvedJdforrester-WMF
ResolvedSimoneThisDot
ResolvedJdforrester-WMF
ResolvedDVrandecic
ResolvedNone
ResolvedNone
Resolvedcmassaro
ResolvedDVrandecic
ResolvedLindsaykwardell
Resolvedarthurlorenzi
ResolvedNone
InvalidNone
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedgengh
Resolvedcmassaro
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedDVrandecic
Resolvedcmassaro
Resolvedarthurlorenzi
ResolvedAdesojiThisDot
OpenNone
ResolvedJdforrester-WMF
ResolvedNone
InvalidNone
Invalidgengh
ResolvedJKieserman
ResolvedNone
ResolvedJdforrester-WMF
ResolvedNone
ResolvedNone
DeclinedNone
ResolvedSimoneThisDot
ResolvedSimoneThisDot
Resolvedcmassaro
Resolvedcmassaro
ResolvedSimoneThisDot
ResolvedSimoneThisDot
Resolvedcmassaro
Resolvedcmassaro
ResolvedBUG REPORTJdforrester-WMF
ResolvedSimoneThisDot
Resolvedgengh
Resolvedgengh
Resolvedcmassaro
Resolvedcmassaro
ResolvedJdforrester-WMF
ResolvedDVrandecic
ResolvedDVrandecic

Event Timeline

Jdforrester-WMF created this task.
gengh added a subscriber: gengh.

This is done for CANONICAL, and work for NORMAL form is ongoing.

gengh changed the task status from Open to In Progress.Mar 17 2022, 10:01 AM

Change 767777 had a related patch set uploaded (by Genoveva Galarza; author: Jkieserman):

[mediawiki/services/function-schemata@master] [WIP] Add support for normal generic lists

https://gerrit.wikimedia.org/r/767777

Change 767777 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add support for normal generic lists

https://gerrit.wikimedia.org/r/767777

Change 773496 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773496

Change 773497 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773497

Change 773498 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773498

Except for the pull-throughs landing (blocked by other work), this is Resolved, I think?

Change 773498 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773498

Change 773497 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e98f603)

https://gerrit.wikimedia.org/r/773497

Change 773496 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (3195378)

https://gerrit.wikimedia.org/r/773496