Page MenuHomePhabricator

basic.py does not show any confirm message with put_current()
Closed, DuplicatePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • basic -page:Foo -simulate

What happens?:

C:\pwb\GIT\core>pwb basic -page:Foo -simulate
Retrieving 1 pages from wikipedia:de.
 ***

>>> Foo <<< ***
@@ -27 +27 @@ ***
- [[Kategorie:Abkürzung|FOO]] ***
+ [[Kategorie:Abkürzung|FOO]]Test ***

Edit summary: Bot: Ändere…

After entering a valid answer key, the confirm question is printed:

q
Do you want to accept these changes? ([y]es, [N]o, [a]ll, [q]uit): Do you want to accept these changes? ([y]es, [N]o, [a]ll, [q]uit):
User quit BasicBot bot run...

0 pages read
0 pages written
0 pages skipped
Execution time: 139 seconds
Script terminated successfully.

What should have happened instead?:

C:\pwb\GIT\core>pwb basic -page:Foo -simulate
Retrieving 1 pages from wikipedia:de.
 ***

>>> Foo <<< ***
@@ -27 +27 @@ ***
- [[Kategorie:Abkürzung|FOO]] ***
+ [[Kategorie:Abkürzung|FOO]]Test ***

Edit summary: Bot: Ändere…

Do you want to accept these changes? ([y]es, [N]o, [a]ll, [q]uit): Do you want to accept these changes? ([y]es, [N]o, [a]ll, [q]uit):

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Pywikibot 7.1.0.dev0

This was introduced with rPWBC6586279

Event Timeline

Xqt triaged this task as High priority.Mar 9 2022, 11:10 AM
Xqt added a subscriber: valhallasw.

Change 769295 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] Revert "[cleanup] no longer use win32_unicode for Python 3.6+"

https://gerrit.wikimedia.org/r/769295

Xqt renamed this task from basic.py dos not show any confirm message with put_current() to basic.py does not show any confirm message with put_current().Mar 9 2022, 11:18 AM
Xqt lowered the priority of this task from High to Medium.

Change 769295 merged by jenkins-bot:

[pywikibot/core@master] Revert "[cleanup] no longer use win32_unicode for Python 3.6+"

https://gerrit.wikimedia.org/r/769295