Page MenuHomePhabricator

Add an 'expand inline player' option
Open, Needs TriagePublic

Description

As a follow up to T246035: Videojs player for audio opens a dialog to support subtitles, which is unexpected, add an new control to the videojs control bar

  1. this control only shows when not all controls fit in the controlbar
  2. this control when clicked, opens the player in the dialog

This also requires opening the dialog by reparenting the <audio><video> element, instead of cloning it.

Event Timeline

Maybe also having an "unexpand" for cases when it's opened as modal because of subtitles? Thank you <3