Page MenuHomePhabricator
Create Task
Maniphest T303404

ArgumentCountError: Too few arguments to function MediaWiki\Extension\OATHAuth\OATHUserRepository::remove(), 2 passed in /srv/mediawiki/php-1.38.0-wmf.25/extensions/WebAuthn/src/HTMLForm/WebAuthnDisableForm.php on line 114 and exactly 3 expected
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   ArgumentCountError: Too few arguments to function MediaWiki\Extension\OATHAuth\OATHUserRepository::remove(), 2 passed in /srv/mediawiki/php-1.38.0-wmf.25/extensions/WebAuthn/src/HTMLForm/WebAuthnDisableForm.php on line 114 and
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.25/extensions/OATHAuth/src/OATHUserRepository.php(176)
#0 /srv/mediawiki/php-1.38.0-wmf.25/extensions/WebAuthn/src/HTMLForm/WebAuthnDisableForm.php(114): MediaWiki\Extension\OATHAuth\OATHUserRepository->remove(MediaWiki\Extension\OATHAuth\OATHUser, string)
#1 /srv/mediawiki/php-1.38.0-wmf.25/extensions/WebAuthn/src/HTMLForm/WebAuthnDisableForm.php(74): MediaWiki\Extension\WebAuthn\HTMLForm\WebAuthnDisableForm->authenticate(string)
#2 /srv/mediawiki/php-1.38.0-wmf.25/includes/htmlform/HTMLForm.php(726): MediaWiki\Extension\WebAuthn\HTMLForm\WebAuthnDisableForm->onSubmit(array, MediaWiki\Extension\WebAuthn\HTMLForm\WebAuthnDisableForm)
#3 /srv/mediawiki/php-1.38.0-wmf.25/includes/htmlform/HTMLForm.php(616): HTMLForm->trySubmit()
#4 /srv/mediawiki/php-1.38.0-wmf.25/includes/htmlform/HTMLForm.php(632): HTMLForm->tryAuthorizedSubmit()
#5 /srv/mediawiki/php-1.38.0-wmf.25/extensions/OATHAuth/src/HTMLForm/OATHAuthOOUIHTMLForm.php(81): HTMLForm->show()
#6 /srv/mediawiki/php-1.38.0-wmf.25/extensions/OATHAuth/src/Special/OATHManage.php(263): MediaWiki\Extension\OATHAuth\HTMLForm\OATHAuthOOUIHTMLForm->show(NULL)
#7 /srv/mediawiki/php-1.38.0-wmf.25/extensions/OATHAuth/src/Special/OATHManage.php(194): MediaWiki\Extension\OATHAuth\Special\OATHManage->addCustomContent(MediaWiki\Extension\WebAuthn\Module\WebAuthn)
#8 /srv/mediawiki/php-1.38.0-wmf.25/extensions/OATHAuth/src/Special/OATHManage.php(106): MediaWiki\Extension\OATHAuth\Special\OATHManage->addModuleHTML(MediaWiki\Extension\WebAuthn\Module\WebAuthn)
#9 /srv/mediawiki/php-1.38.0-wmf.25/includes/specialpage/SpecialPage.php(671): MediaWiki\Extension\OATHAuth\Special\OATHManage->execute(NULL)
#10 /srv/mediawiki/php-1.38.0-wmf.25/includes/specialpage/SpecialPageFactory.php(1378): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-1.38.0-wmf.25/includes/MediaWiki.php(315): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#12 /srv/mediawiki/php-1.38.0-wmf.25/includes/MediaWiki.php(910): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.38.0-wmf.25/includes/MediaWiki.php(564): MediaWiki->main()
#14 /srv/mediawiki/php-1.38.0-wmf.25/index.php(53): MediaWiki->run()
#15 /srv/mediawiki/php-1.38.0-wmf.25/index.php(46): wfIndexMain()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}
Notes

Saw two errors like these for officewiki in the last 15 minutes.

Details

Request URL
https://office.wikimedia.org/wiki/Special:Manage_Two-factor_authentication
SubjectRepoBranchLines +/-
Mark removals of WebAuthn as done by selfmediawiki/extensions/WebAuthnREL1_35+2 -2
Mark removals of WebAuthn as done by selfmediawiki/extensions/WebAuthnREL1_36+2 -2
Mark removals of WebAuthn as done by selfmediawiki/extensions/WebAuthnREL1_37+2 -2
Mark removals of WebAuthn as done by selfmediawiki/extensions/WebAuthnwmf/1.38.0-wmf.25+2 -2
Mark removals of WebAuthn as done by selfmediawiki/extensions/WebAuthnwmf/1.38.0-wmf.24+2 -2
Mark removals of WebAuthn as done by selfmediawiki/extensions/WebAuthnmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

dancy created this task.Mar 9 2022, 3:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2022, 3:52 PM
Zabe edited projects, added MediaWiki-extensions-OATHAuth; removed MediaWiki-extensions-OAuth.Mar 9 2022, 3:54 PM
Krinkle added a parent task: T300201: 1.38.0-wmf.25 deployment blockers.Mar 9 2022, 4:42 PM
Krinkle added subscribers: Reedy, Legoktm, Krinkle.Mar 9 2022, 4:47 PM

From WebAuthnDisableForm.php:

			$this->oathRepo->remove( $this->oathUser, $this->getRequest()->getIP() );

From OATHUserRepository.php:

	public function remove( OATHUser $user, $clientInfo, bool $self ) {

Looks like a regression caused by change 763190 (T210075, T210963; /cc @Legoktm, @Reedy). And somehow missed by Phan, or has the WebAuthn repo simply not had a CI run since the change in OATHAuth?

Ladsgroup subscribed.Mar 9 2022, 4:52 PM

WebAuthn and OATHAuth haven't changed in wmf.25 o.O

Ladsgroup added a comment.Mar 9 2022, 4:53 PM

It has been in wmf.24 it seems. Nice catch. I can do the backport if needed

Krinkle added a comment.Mar 9 2022, 4:58 PM
In T303404#7764325, @Krinkle wrote:

And somehow missed by Phan, or has the WebAuthn repo simply not had a CI run since the change in OATHAuth?

The latter. New commits do fail (example).

gerritbot added a comment.Mar 9 2022, 5:04 PM

Change 769475 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WebAuthn@master] WebAuthnDisableForm: Mark removal as done by self

https://gerrit.wikimedia.org/r/769475

gerritbot added a project: Patch-For-Review.Mar 9 2022, 5:04 PM
Zabe subscribed.Mar 9 2022, 5:05 PM
gerritbot added a comment.Mar 9 2022, 5:12 PM

Change 769298 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WebAuthn@wmf/1.38.0-wmf.25] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769298

gerritbot added a comment.Mar 9 2022, 5:12 PM

Change 769299 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WebAuthn@wmf/1.38.0-wmf.24] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769299

gerritbot added a comment.Mar 9 2022, 5:13 PM

Change 769300 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WebAuthn@REL1_37] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769300

gerritbot added a comment.Mar 9 2022, 5:13 PM

Change 769301 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WebAuthn@REL1_36] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769301

gerritbot added a comment.Mar 9 2022, 5:14 PM

Change 769302 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WebAuthn@REL1_35] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769302

gerritbot added a comment.Mar 9 2022, 5:17 PM

Change 769475 merged by jenkins-bot:

[mediawiki/extensions/WebAuthn@master] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769475

gerritbot added a comment.Mar 9 2022, 5:24 PM

Change 769299 merged by jenkins-bot:

[mediawiki/extensions/WebAuthn@wmf/1.38.0-wmf.24] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769299

gerritbot added a comment.Mar 9 2022, 5:24 PM

Change 769298 merged by jenkins-bot:

[mediawiki/extensions/WebAuthn@wmf/1.38.0-wmf.25] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769298

gerritbot added a comment.Mar 9 2022, 5:25 PM

Change 769300 merged by jenkins-bot:

[mediawiki/extensions/WebAuthn@REL1_37] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769300

gerritbot added a comment.Mar 9 2022, 5:26 PM

Change 769301 merged by jenkins-bot:

[mediawiki/extensions/WebAuthn@REL1_36] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769301

Stashbot added a comment.Mar 9 2022, 5:28 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T17:28:39Z] <reedy@deploy1002> Synchronized php-1.38.0-wmf.24/extensions/WebAuthn/: T303404 (duration: 00m 51s)

Stashbot added a comment.Mar 9 2022, 5:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T17:29:37Z] <reedy@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/WebAuthn/: T303404 (duration: 00m 53s)

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 9 2022, 6:00 PM
Zabe removed a parent task: T300201: 1.38.0-wmf.25 deployment blockers.Mar 9 2022, 6:38 PM
Legoktm added a comment.Mar 9 2022, 7:24 PM

Sorry about this :(( We should probably make OATHAuth and WebAuthn circular dependencies in CI. I think we could also benefit from just merging the WebAuthn repo into OATHAuth, except that WebAuthn requires the gmp extension, which isn't required by core yet...

I'll file follow-up tasks later today.

Krinkle closed this task as Resolved.Mar 9 2022, 9:06 PM
Krinkle assigned this task to Reedy.
Legoktm mentioned this in T303494: In CI OATHAuth extension should depend on WebAuthn.Mar 10 2022, 4:05 AM
Legoktm added a comment.Mar 10 2022, 4:12 AM

Follow-up tasks:

gerritbot added a comment.Mar 11 2022, 4:09 PM

Change 769302 merged by jenkins-bot:

[mediawiki/extensions/WebAuthn@REL1_35] Mark removals of WebAuthn as done by self

https://gerrit.wikimedia.org/r/769302

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2022, 4:10 PM
Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Mar 14 2022, 4:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL