Page MenuHomePhabricator

Ensure Phabricator is compatible with Elasticsearch 7.10
Closed, DeclinedPublic

Description

As part of the upgrade to Elasticsearch 7.10 for the Search cluster, Phabricator needs to be compatible with ES 7.10. Phabricator is using the Search Elasticsearch cluster to power its search feature.

Event Timeline

I don't see any docs to say it's explicitly not supported.

There seem to be version checks for 2 & 5 in the code. No idea if anything breaking has changed for Phabricator use.

Aklapper renamed this task from Phabricator is compatible with Elasticsearch 7.10 to Ensure Phabricator is compatible with Elasticsearch 7.10.Mar 12 2022, 9:59 PM

I don't see any docs to say it's explicitly not supported.

There seem to be version checks for 2 & 5 in the code. No idea if anything breaking has changed for Phabricator use.

Does this mean that we can just move forward and keep our fingers crossed? Is there a way to validate this?

The current phabricator config defines a few search engines. MySQL is the default. We switched to using ElasticSearch briefly, but my memory is that we switched back to the default (although elasticsearch is still in the config).

@brennen and I briefly attempted to verify this, but it still requires more digging. If it is the case that we use the default search driver once again, then we can remove the config. If it's not the case, we can likely use our dev-tools test project to verify this for you.

Hi @Gehel I have been at least able to confirm (via a phab admin page you might not be able to see: https://phabricator.wikimedia.org/config/cluster/search/ ) that we are currently using the MySQL as the phabricator search engine and don't intend to switch back to ES.

I think this means you don't have to consider phabricator a blocker for your upgrade, but if I'm wrong about that for other reasons, let me know :)

If it helps: It's unlikely that phabricator will ever need elasticsearch in the future.

It seems like we could close this as declined.

It seems like we could close this as declined.

Agreed - thanks all!

While it seems unlikely, in case something breaks today i deleted the phabricator indices from the production search clusters.