Page MenuHomePhabricator
Create Task
Maniphest T303469

VE should preserve .mw-file-description class in Parsoid HTML
Closed, ResolvedPublic5 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Parsoid started adding .mw-file-description class to image links for certain kinds of media wikitext. VE seems to drop them on roundtrip which means Parsoid will treat these images as having been edited and can introduce dirty diffs in some scenarios.

I am being conservative and with an abundance of caution, adding this as a train blocker. If @Arlolra and VE folks think this can wait till tomorrow (or the next train), we can remove this as a blocker.

There is already a fix for this in gerrit @ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/769507 by @Arlolra

Details

SubjectRepoBranchLines +/-
Preserve classes on media wrapper linksmediawiki/extensions/VisualEditorwmf/1.38.0-wmf.25+102 -5
Preserve classes on media wrapper linksmediawiki/extensions/VisualEditormaster+102 -5
Customize query in gerrit

Related Objects

Event Timeline

ssastry triaged this task as Medium priority.Mar 9 2022, 8:03 PM
ssastry created this task.
ssastry created this object with edit policy "Custom Policy".
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 9 2022, 8:03 PM
ssastry removed dancy as the assignee of this task.Mar 9 2022, 8:04 PM
ssastry added projects: VisualEditor, Editing-team.
ssastry added a subscriber: dancy.
gerritbot added a comment.Mar 9 2022, 8:30 PM

Change 769507 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/VisualEditor@master] Preserve class on media file description links

https://gerrit.wikimedia.org/r/769507

gerritbot added a project: Patch-For-Review.Mar 9 2022, 8:30 PM
brennen raised the priority of this task from Medium to Unbreak Now!.Mar 9 2022, 8:47 PM
matmarex subscribed.Mar 9 2022, 9:06 PM

The proposed fix is failing unit tests.

ssastry added a comment.Mar 9 2022, 11:03 PM

After a bunch of testing, we feel it is safe to roll out train as is since Parsoid's html2wt / selser are doing much better than we feared.

I am going to remove this as a blocker.

ssastry lowered the priority of this task from Unbreak Now! to Medium.Mar 9 2022, 11:03 PM
ssastry removed a parent task: T300201: 1.38.0-wmf.25 deployment blockers.

We will test this separately and if required, we can roll out a VE fix tomorrow before group 2.

Arlolra added a comment.Mar 9 2022, 11:24 PM

A patch to run parserTests with the simulated effects of dropping the class is in https://phabricator.wikimedia.org/P22230

ssastry added a comment.Mar 10 2022, 12:32 AM

It would be good to have the patch reviewed by the Editing Team and deployed before group 2 rollout tomorrow.

• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Mar 10 2022, 4:46 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.Mar 10 2022, 5:04 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
brennen added a comment.Mar 10 2022, 7:09 PM

It would be good to have the patch reviewed by the Editing Team and deployed before group 2 rollout tomorrow.

Sounds like we should currently be blocking on this?

matmarex added a comment.Mar 10 2022, 7:19 PM

No, I'm planning to review the patch in a moment (David and Ed already had a look, and it's a good idea, but we didn't have time yet to carefully read it), and then backport the patch in the next backport window. I think you can proceed with the train deployment as normal.

brennen added a comment.Mar 10 2022, 7:31 PM

Cool. We're blocked elsewhere, so the move to all wikis may wait a bit anyway, but we won't treat this as a blocker for T300201. Thanks!

gerritbot added a comment.Mar 10 2022, 8:36 PM

Change 769507 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Preserve classes on media wrapper links

https://gerrit.wikimedia.org/r/769507

gerritbot added a comment.Mar 10 2022, 8:44 PM

Change 769558 had a related patch set uploaded (by Bartosz Dziewoński; author: Arlolra):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.25] Preserve classes on media wrapper links

https://gerrit.wikimedia.org/r/769558

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 10 2022, 9:00 PM
gerritbot added a comment.Mar 10 2022, 9:19 PM

Change 769558 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.25] Preserve classes on media wrapper links

https://gerrit.wikimedia.org/r/769558

Stashbot added a comment.Mar 10 2022, 9:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-10T21:33:35Z] <rzl@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/VisualEditor/modules/ve-mw: Backport: [[gerrit:769558|Preserve classes on media wrapper links (T292657 T303469)]] (duration: 00m 49s)

Stashbot mentioned this in T292657: file "link=" syntax broken at some wikis.Mar 10 2022, 9:33 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 10 2022, 10:00 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 10 2022, 10:04 PM
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
Arlolra added a comment.Mar 10 2022, 10:12 PM

No, I'm planning to review the patch in a moment (David and Ed already had a look, and it's a good idea, but we didn't have time yet to carefully read it), and then backport the patch in the next backport window

Thanks for taking care of that @matmarex

Arlolra closed this task as Resolved.Mar 11 2022, 8:24 PM
Arlolra claimed this task.
• mewoph mentioned this in T309152: [regression-wmf.13] Add image: Missing "View image details" link .May 24 2022, 11:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL