Status	Assigned	Task
Duplicate	None	T299666 Add TypeaheadSearch component to Codex
Resolved	• Sarai-WMDE	T297025 Add TypeaheadSearch to Codex
Resolved	Catrope	T303569 Add TypeaheadSearch-only build

Event Timeline

Catrope created this task.Mar 11 2022, 12:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2022, 12:23 AM

Catrope claimed this task.Mar 11 2022, 12:24 AM

Catrope edited projects, added: Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint); removed: Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board).

Catrope moved this task from Research to In Development on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.

Change 769811 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] build: Add a separate build for TypeaheadSearch

https://gerrit.wikimedia.org/r/769811

gerritbot added a project: Patch-For-Review.Mar 11 2022, 1:27 AM

File sizes:

70323	dist/codex.es.js
40015	dist/codex.umd.js
25187	dist/codex.style.css
25205	dist/codex.style-rtl.css

42288	dist/codex-typeaheadSearch.es.js
23585	dist/codex-typeaheadSearch.umd.js
11680	dist/codex-typeaheadSearch.style.css
11682	dist/codex-typeaheadSearch.style-rtl.css

(note that the .umd.js files are minified, the .es.js files are not)

Comparing to WVUI (where commonjs2 is unminified and the other ones are minified):

30791	dist/wvui.js
185771	dist/commonjs2/wvui.commonjs2.js
22075	dist/wvui.css
26285	dist/commonjs2/wvui.css

19837	dist/wvui-search.js
12391	dist/wvui-search.css
14635	dist/commonjs2/wvui-search.css

So is the appropriate comparison codex-typeaheadSearch.umd.js (at 23.5KB) vs wvui-search.js (at 19.8KB)?

I hope an extra 4KB is not a dealbreaker. I wonder why the Codex version of this feature is larger since both versions externalize their dependencies? Differences in template compilation?

In T303569#7769020, @egardner wrote:

So is the appropriate comparison codex-typeaheadSearch.umd.js (at 24.6KB) vs wvui-search.js (at 19.8KB)?

I hope an extra 5KB is not a dealbreaker. I wonder why the Codex version of this feature is larger since both versions externalize their dependencies? Differences in template compilation?

Yes. I just managed to shave 1KB off the Codex one by removing comments (which wasn't happening because Vue didn't realize it was supposed to be in production mode, due to my mode hack; I'll probably restructure this to use a separate Vite config file rather than a mode). Not sure where the rest of the difference is coming from, I think it might just be from Codex having more layers of abstraction (including the Menu component), and perhaps composition API code being a bit more verbose than option API code.

Catrope moved this task from In Development to Code Review on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.Mar 14 2022, 9:38 PM

• STH edited projects, added: Design-System-Team (Design-System-Sprint); removed: Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint).Apr 15 2022, 9:02 PM

• STH moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.

Change 769811 merged by jenkins-bot:

[design/codex@main] build: Add the @wikimedia/codex-search package

https://gerrit.wikimedia.org/r/769811

Maintenance_bot removed a project: Patch-For-Review.Apr 19 2022, 3:30 PM

• STH removed a parent task: T300081: TypeaheadSearch in Codex (WVUI version).Apr 25 2022, 4:55 PM

AnneT added a parent task: T297025: Add TypeaheadSearch to Codex.Apr 25 2022, 5:01 PM

AnneT moved this task from Code Review to QTE Sign-off on the Design-System-Team (Design-System-Sprint) board.Apr 25 2022, 6:29 PM

AnneT closed this task as Resolved.Apr 28 2022, 4:04 PM

Volker_E moved this task from QTE Sign-off to Pending Release on the Design-System-Team (Design-System-Sprint) board.Jan 7 2023, 12:34 AM