Page MenuHomePhabricator
Create Task
Maniphest T303639

Create fields validation for the Unregister Participant API
Closed, ResolvedPublic
Actions

Description

As a Dev, I want to create the validations to the fields: user_id and event_registration_id

Acceptance Criteria:

event_registration_id:

  • Must be set
  • Must be an integer
  • Must be a valid event registration id
  • The end date must not be in the past
  • The status does not have to be 'open'

If fields validation fails we must return the reason of the error in the response:

  • Invalid registration_id
  • Registration is past

Participants should be able to unregister if the event is closed

  • Because: they may no longer be able to attend the event (so they should be able to update their status)

Participants should not able to unregister if the event has ended

  • Because: organizer should have a complete list of who intended to attend, whether or not they did

Details

SubjectRepoBranchLines +/-
Create a REST endpoint for unregistering as a participantmediawiki/extensions/CampaignEventsmaster+329 -42
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmelo created this task.Mar 11 2022, 8:09 PM
cmelo updated the task description. (Show Details)
cmelo updated the task description. (Show Details)
cmelo updated the task description. (Show Details)Mar 11 2022, 8:12 PM
cmelo updated the task description. (Show Details)
cmelo updated the task description. (Show Details)
cmelo updated the task description. (Show Details)Mar 11 2022, 8:16 PM
Daimona added a project: CampaignEvents.Mar 18 2022, 12:13 PM
Daimona updated the task description. (Show Details)Mar 21 2022, 7:28 PM
Daimona added subscribers: • JCarvalho, ifried, Daimona.Mar 21 2022, 7:30 PM

@cmelo @JCarvalho @ifried What about the last two items? Should users be able to unregister if the registration is not open or has already ended? (My answer would be no to both questions)

cmelo added a comment.Mar 21 2022, 10:37 PM

Hi @Daimona, yes I agree with you, the participant can not register in this two cases.

gerritbot added a comment.Mar 22 2022, 2:58 PM

Change 772845 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Create a REST endpoint for unregistering as a participant

https://gerrit.wikimedia.org/r/772845

gerritbot added a project: Patch-For-Review.Mar 22 2022, 2:58 PM
Daimona claimed this task.Mar 22 2022, 3:01 PM
Daimona edited projects, added Campaign-Tools (Campaign-Tools-Sprint-9); removed Campaign-Tools.Mar 22 2022, 3:03 PM
Daimona moved this task from Ready 🎬 to Review/Feedback 💬 on the Campaign-Tools (Campaign-Tools-Sprint-9) board.
ifried added subscribers: • IBrazal, CKMIE89, gonyeahialam and 2 others.EditedMar 22 2022, 4:04 PM

The question is whether participants should be able to unregister for an event that is closed in status or has already ended. My instinct is:

  • If event status is closed: At first, I thought 'no,' but as I have thought about it more, I think 'yes.' This is because the user may not be able to attend, and this is important information for the organizer to know. Also, if there is a quota for the number of participants, they can give up their seat so someone else can join.
  • If event has ended: No. I think it is useful to capture this for tracking purposes and it can later be compared against who made edits or who showed up in analytics for the organizer. But I am open to ideas/suggestions, since I would like to think about this a bit more.

What do you think, @Iflorez, @gonyeahialam, @CKMIE89, @Astinson, and @IBrazal? Thanks in advance!

ifried added a subscriber: fnartey.Mar 22 2022, 4:41 PM

I am talking to @fnartey, and he is saying:

  • If it is automatic closing since the quota of participants has been reached, the participant should be able to leave and then registration is open again until the quota is filled again.
  • If is manually closed by the organizer, then the participant should only be able to leave by contacting the organizer and having them remove them.
  • If it is closed due to event date passing, they should not be able to leave.
CKMIE89 added a comment.Mar 22 2022, 4:48 PM

Reading this I'm wondering if some kind of "waiting list" or "expression of interest" is possible, if an event is full but a "seat" opens up.... (bullet point 1 & 2 from @fnartey comments.)
You could then be automatically registered, or receive some kind of message informing you that registration is possible again?

Daimona added a comment.Mar 23 2022, 1:33 PM

Thinking about this again, I agree with the comments above. However, number of seats or automatic closing are not V0, so for now I'd stick with disallowing the unregistration only if the event has ended (but not if it's closed). What do y'all think?

cmelo added a comment.Mar 23 2022, 1:39 PM
In T303639#7799673, @Daimona wrote:

Thinking about this again, I agree with the comments above. However, number of seats or automatic closing are not V0, so for now I'd stick with disallowing the unregistration only if the event has ended (but not if it's closed). What do y'all think?

Hi @Daimona I think it is ok for V0, thank you!

fnartey added a comment.Mar 23 2022, 1:55 PM
In T303639#7799673, @Daimona wrote:

Thinking about this again, I agree with the comments above. However, number of seats or automatic closing are not V0, so for now I'd stick with disallowing the unregistration only if the event has ended (but not if it's closed). What do y'all think?

I concur with this

ifried added a comment.Mar 23 2022, 2:00 PM

Yup, makes sense, @Daimona. We can hash out details of handling participant quotas in V2 or later. For now, the simple rule of allowing participants to unregister if the event is closed and NOT allowing participants to unregister if the event has ended makes sense. I will add this information to the Acceptance Criteria. Thanks!

ifried updated the task description. (Show Details)Mar 23 2022, 2:02 PM
Daimona updated the task description. (Show Details)Mar 25 2022, 1:19 PM
gonyeahialam added a comment.Mar 25 2022, 1:53 PM
In T303639#7797080, @ifried wrote:

The question is whether participants should be able to unregister for an event that is closed in status or has already ended. My instinct is:

  • If event status is closed: At first, I thought 'no,' but as I have thought about it more, I think 'yes.' This is because the user may not be able to attend, and this is important information for the organizer to know. Also, if there is a quota for the number of participants, they can give up their seat so someone else can join.
  • If event has ended: No. I think it is useful to capture this for tracking purposes and it can later be compared against who made edits or who showed up in analytics for the organizer. But I am open to ideas/suggestions, since I would like to think about this a bit more.

What do you think, @Iflorez, @gonyeahialam, @CKMIE89, @Astinson, and @IBrazal? Thanks in advance!

I agree with this

gerritbot added a comment.Apr 1 2022, 12:17 PM

Change 772845 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Create a REST endpoint for unregistering as a participant

https://gerrit.wikimedia.org/r/772845

Daimona mentioned this in rUCAM4f699b765940: Create a REST endpoint for unregistering as a participant.Apr 1 2022, 12:17 PM
Daimona removed a project: Patch-For-Review.Apr 1 2022, 12:23 PM
Daimona moved this task from Review/Feedback 💬 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-9) board.
ifried closed this task as Resolved.Apr 1 2022, 5:35 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Sprint-9) board.

Since this is not user-facing, I will mark this as Done. Meanwhile, we will test the experience of error handling from the user perspective in T305264 (details TBD).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL