Page MenuHomePhabricator

Add "vector-menu-heading" class to otherlanguages in live preview
Closed, ResolvedPublicBUG REPORT


List of steps to reproduce (step by step, including full links if applicable):

What happens?:
"otherlanguages" menu on the left looks pretty strange.

image.png (414×316 px, 28 KB)

What should have happened instead?:
It should looks similar to other labels.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
1.38.0-wmf.25 (2b818a6)

Event Timeline

Change 770123 had a related patch set uploaded (by Stang; author: Stang):

[mediawiki/core@master] Add "vector-menu-heading" class to otherlanguages

Jdlrobson added subscribers: ovasileva, Jdlrobson.

The editing team maintains this code. I've flagged in the past in T300814 that the current approach is not sustainable. @ovasileva we will need to work with the editing team if we want to support this better.

@Jdlrobson @ovasileva I think your team is capable of preventing further regressions of the same kind by yourselves. Can you amend your processes to ensure this doesn't occur again?

Change 770123 merged by jenkins-bot:

[mediawiki/core@master] Add "vector-menu-heading" class to otherlanguages

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex edited projects, added Editing QA; removed Patch-For-Review.

Thanks for the fix @Stang!

ovasileva triaged this task as Medium priority.Mar 15 2022, 10:11 AM

@Jdlrobson, @matmarex - is this a wikiversity-only issue/restricted to that beta cluster?

No, it's also reproducible on e.g. I haven't checked which wikis exactly are affected (it depends on the configuration for the language links menu somehow).

cc @MusikAnimal this is a very similar problem to the one we've been talking about in

Yes, I had the same problem with w:User:MusikAnimal/scriptManager as well, which I've since fixed.

I think if the Readers Web team is planning more changes to menus and portals (as I understand you are, T302073), it would be ideal to provide a JS entrypoint for scripts and gadgets to create their own portlets. The need for this clearly established, even in MediaWiki Core. I have created a proposal at T303859: Provide a JS entrypoint to create custom portlets.

ovasileva renamed this task from Add "vector-menu-heading" class to otherlanguages to Add "vector-menu-heading" class to otherlanguages in live preview.Mar 15 2022, 5:17 PM

All looks good in preview with and without reload

Screenshot 2022-04-05 at 17.37.29.png (1×2 px, 502 KB)

Screenshot 2022-04-05 at 17.38.25.png (1×512 px, 172 KB)

Screenshot 2022-04-05 at 17.39.00.png (1×1 px, 393 KB)

Screenshot 2022-04-05 at 17.44.22.png (1×1 px, 343 KB)

Screenshot 2022-04-05 at 17.45.04.png (1×1 px, 628 KB)

ppelberg claimed this task.