Page MenuHomePhabricator
Create Task
Maniphest T303701

Special:Nuke doesn't update the translate page for all deleted units
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT
Actions

Description

Looking at the history of that page, only one of the 3 created units that were deleted by Special:Nuke actually updated the page. And it wasn't the first nor the last for that page.

The other vandalized units are still visible on the translated page, but I can't purge them. Since there's no unit (they are deleted), I can't do a null-edit on them to refresh the translated page.

This is something that happens more or less frequently. It may not be related to Special:Nuke at all, since sometimes, when reverting edits in quick succession, this can happen too. The title may be updated to reflect a more broader issue.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[DNM] Add robust de-duplication to avoid outdated translation pagesmediawiki/extensions/Translatemaster+23 -54
DNM: Add logs to debug outdated translation pages on mass deletionmediawiki/extensions/Translatemaster+39 -6
Remove custom job de-duplication logic on translation unit deletionmediawiki/extensions/Translatemaster+46 -54
Customize query in gerrit

Related Objects

Event Timeline

Ciencia_Al_Poder created this task.Mar 14 2022, 9:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2022, 9:44 AM
Base subscribed.Mar 14 2022, 12:56 PM
Ciencia_Al_Poder added a comment.Mar 15 2022, 8:36 AM

This happened again when dealing with this user's contributions.

Func subscribed.Mar 18 2022, 5:45 AM

Maybe it's a regression, update after mass deletion works well a year ago:
https://www.mediawiki.org/w/index.php?title=Wikimedia_Technology/ru&type=revision&diff=4445234&oldid=4445226&diffmode=source
https://www.mediawiki.org/w/index.php?title=Wikimedia_Technology/ru&type=revision&diff=4445251&oldid=4445234&diffmode=source

Func added a comment.Mar 18 2022, 5:50 AM

Also, they don't have "Reverted" or "Manual revert" tags where they should have respectively.

Ciencia_Al_Poder added a comment.Apr 5 2022, 7:33 AM

As I recalled, this happens also when doing reverts in quick succession.

Example, when I reverted 2 translation units of the same page. One succeeded but the other didn't:

my revert on the translation unit, but it wasn't propagated to the translated page

Nikerabbit triaged this task as High priority.Jun 27 2022, 11:54 AM
Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.
Pginer-WMF added a project: Language-Team (Language-2022-July-September).Jul 4 2022, 12:29 PM
Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-July-September) board.
abi_ set the point value for this task to 4.Jul 5 2022, 5:09 AM
abi_ claimed this task.Jul 21 2022, 8:04 AM
abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2022-July-September) board.
gerritbot added a comment.Jul 21 2022, 2:56 PM

Change 815999 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DNM: Add logs to debug outdated translation pages on mass deletion

https://gerrit.wikimedia.org/r/815999

gerritbot added a project: Patch-For-Review.Jul 21 2022, 2:56 PM
abi_ added a comment.Jul 21 2022, 2:57 PM

I'm able to reproduce this locally. Here's what I think is happening:

  1. Nuke extension creates a DeletePageJob for each translation unit that is to be deleted.
  2. When the first DeletePageJob is executed, the ArticleDeleteComplete hook is triggered, and we use it to create a TranslateRenderJob, that is added to the job queue.
  3. In the same job queue run, other units get deleted and the ArticleDeleteComplete hook is triggered, but no TranslateRenderJobs are created for them due to the de-duplication logic we have in PageTranslationHooks::onDeleteTranslationUnit, and because we have removeDuplicates flag set on the TranslateRenderJob.
  4. The first render job that is created completes before the last DeletePageJob is run.

To prove this hypothesis, I added logs as per this patch and here's what I see:

2022-07-21 14:33:01 wikimedia dev_wiki: Unit deleted: Translations:Main Page Translate/9/hi                  <-- Comment: First unit deleted
2022-07-21 14:33:01 wikimedia dev_wiki: Adding job TranslateRenderJob for Translations:Main Page Translate/9/hi 
2022-07-21 14:33:01 wikimedia dev_wiki: Unit deleted: Translations:Main Page Translate/12/hi
2022-07-21 14:33:01 wikimedia dev_wiki: TranslateRenderJob [Main Page Translate/hi]: Starting TranslateRenderJob triggered by Translations:Main Page Translate/9/hi
2022-07-21 14:33:01 wikimedia dev_wiki: TranslateRenderJob [Main Page Translate/hi]: Finished page edit operation
2022-07-21 14:33:01 wikimedia dev_wiki: TranslateRenderJob [Main Page Translate/hi]: Finished TranslateRenderJob     <-- Comment: TranslateRenderJob already run!
2022-07-21 14:33:01 wikimedia dev_wiki: Unit deleted: Translations:Main Page Translate/10/hi
2022-07-21 14:33:02 wikimedia dev_wiki: Unit deleted: Translations:Main Page Translate/6/hi
2022-07-21 14:33:02 wikimedia dev_wiki: Unit deleted: Translations:Main Page Translate/7/hi
2022-07-21 14:33:02 wikimedia dev_wiki: Unit deleted: Translations:Main Page Translate/8/hi
2022-07-21 14:33:02 wikimedia dev_wiki: Unit deleted: Translations:Main Page Translate/11/hi
2022-07-21 14:33:02 wikimedia dev_wiki: Unit deleted: Translations:Main Page Translate/13/hi        <-- Comment: Deletion for rest of the unit completes here.

This results in the translation page having the old translations for the units that were deleted after it ran.

gerritbot added a comment.Jul 23 2022, 6:38 AM

Change 816229 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add robust de-duplication to avoid outdated translation pages

https://gerrit.wikimedia.org/r/816229

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-July-September) board.Jul 25 2022, 2:51 AM
abi_ moved this task from In Review to In Progress on the Language-Team (Language-2022-July-September) board.Jul 28 2022, 7:58 AM
gerritbot added a comment.Jul 29 2022, 10:27 AM

Change 818439 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add robust de-duplication to avoid outdated translation pages

https://gerrit.wikimedia.org/r/818439

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-July-September) board.Jul 29 2022, 10:42 AM
gerritbot added a comment.Aug 2 2022, 11:36 AM

Change 818439 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove custom job de-duplication logic on translation unit deletion

https://gerrit.wikimedia.org/r/818439

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 2 2022, 12:00 PM
abi_ moved this task from In Review to Pending input for QA on the Language-Team (Language-2022-July-September) board.Aug 2 2022, 1:53 PM
abi_ mentioned this in T314390: Successive translation unit reverts cause out of date translation pages.Aug 2 2022, 1:59 PM

For this task we believe we've fixed the out of date translation pages when translation units are deleted using Special:Nuke extension. We've created a separate bug report to track the issue related to successive reverts: T314390: Successive translation unit reverts cause out of date translation pages

Our fix should go out with the train next week.

abi_ moved this task from Pending input for QA to Check after deployment on the Language-Team (Language-2022-July-September) board.Aug 2 2022, 2:00 PM
gerritbot added a comment.Aug 3 2022, 2:23 PM

Change 815999 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] DNM: Add logs to debug outdated translation pages on mass deletion

Reason:

Replaced by: I97d9de4773719dcd53106871d0f35ad1165fbdac

https://gerrit.wikimedia.org/r/815999

gerritbot added a comment.Aug 3 2022, 2:23 PM

Change 816229 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] [DNM] Add robust de-duplication to avoid outdated translation pages

Reason:

Replaced by: I97d9de4773719dcd53106871d0f35ad1165fbdac

https://gerrit.wikimedia.org/r/816229

Nikerabbit removed a project: Patch-For-Review.Aug 4 2022, 7:31 AM
abi_ closed this task as Resolved.Aug 24 2022, 6:12 AM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2022-July-September) board.

I've done some testing with this on Translatewiki.net and did not notice any issues caused by this patch. Our local testing has revealed that our fixes should address the issue.

Please reopen this task if you continue to notice issues with outdated translation pages, when nuking translation unit pages.

Johannnes89 subscribed.Apr 2 2025, 9:19 AM
Restricted Application added a subscriber: hubaishan. · View Herald TranscriptApr 2 2025, 9:19 AM
Pppery subscribed.Apr 2 2025, 7:24 PM
Restricted Application added a subscriber: alaa. · View Herald TranscriptApr 2 2025, 7:24 PM
Pppery unsubscribed.Apr 2 2025, 7:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits