Page MenuHomePhabricator

Finish decommissioning the legacy GuidedTour schemas
Open, Needs TriagePublic

Description

GuidedTours stopped publishing events via EventLogging entirely in rEGTO88c260f0c721: Disable logging as part of T288416. This task covers completely removing the instrument that was disabled by that patch as well as any uses of the schemas.

The schemas are:

  • GuidedTourGuiderImpression
  • GuidedTourGuiderHidden
  • GuidedTourButtonClick
  • GuidedTourInternalLinkActivation
  • GuidedTourExternalLinkActivation
  • GuidedTourExited

TODO

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 770899 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/GuidedTour@master] Remove instrumentation

https://gerrit.wikimedia.org/r/770899

Change 770900 had a related patch set uploaded (by Phuedx; author: Phuedx):

[analytics/refinery@master] Remove mentions of GuidedTour* legacy EventLogging schemas

https://gerrit.wikimedia.org/r/770900

Remove entries from the allowlist
Request the deletion of allowlisted data

These were both done as part of T288416.

kostajh added a subscriber: kostajh.

Thanks for filing this @phuedx and for the patches. Do you need anything from Growth team on this?

Thanks for filing this @phuedx and for the patches. Do you need anything from Growth team on this?

If you have the bandwidth to review the patch, then I'd really appreciate it. If not, then a guided tour of how to test the patch with some of the Growth team's tours would be great.

Thanks for filing this @phuedx and for the patches. Do you need anything from Growth team on this?

If you have the bandwidth to review the patch, then I'd really appreciate it. If not, then a guided tour of how to test the patch with some of the Growth team's tours would be great.

I'll try to review the patch, but to answer the second part of your question – creating a new account in your local environment (or on en beta wikipedia) and either abandoning the welcome survey or completing it would show you different tours.

Change 770900 merged by Mforns:

[analytics/refinery@master] Remove mentions of GuidedTour* legacy EventLogging schemas

https://gerrit.wikimedia.org/r/770900

Thanks for filing this @phuedx and for the patches. Do you need anything from Growth team on this?

If you have the bandwidth to review the patch, then I'd really appreciate it. If not, then a guided tour of how to test the patch with some of the Growth team's tours would be great.

I'll try to review the patch, but to answer the second part of your question – creating a new account in your local environment (or on en beta wikipedia) and either abandoning the welcome survey or completing it would show you different tours.

@DMburugu we could consider doing this as part of T304427: [Epic] Q4 FY 2021-22 Growth Maintenance Work, what do you think?

Change 807526 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/GuidedTour@master] Remove EventLoggingSchemas entries

https://gerrit.wikimedia.org/r/807526

I split out the removal of the EventLoggingSchemas entries in the hopes that it'll ease moving this task along.

We can safely split out removing the EventLoggingSchemas entries because the instrumentation is disabled and therefore those entries aren't being accessed by the EventLogging JS Client – that is, the change is a NOP. Further, it's safe to review and merge in isolation because the underlying mechanism is defined and well tested outside of GuidedTour.

Change 807526 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Remove EventLoggingSchemas entries

https://gerrit.wikimedia.org/r/807526