Page MenuHomePhabricator

Just Allow the Event Creator to delete the Event Registration for V0
Closed, ResolvedPublic

Description

As a Dev I want to allow only the the creator of the event registration to delete the event registration.

Acceptance Criteria:

only the the creator of the event registration can delete the event registration for V0.

Event Timeline

Change 776242 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add backend logic and REST endpoint for deleting a registration

https://gerrit.wikimedia.org/r/776242

Change 776242 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add backend logic and REST endpoint for deleting a registration

https://gerrit.wikimedia.org/r/776242

ifried added subscribers: vyuen, ifried.

This may also be good for QTE. Do you agree, @Daimona & @vyuen?

Nothing for me to test, so I'll mark this as Done.

This may also be good for QTE. Do you agree, @Daimona & @vyuen?

Yea

Thanks, I have added it to the QTE task

@cmelo @Daimona @ifried

In testing the API, the event creator and also admins can delete events. I assume that this functionality is correct, but just that the acceptance criteria is incorrect for this ticket, as it doesn't include admin? If this is true, could we just change the acceptance criteria here to include admins as well? Or if admin should not be able to delete any event registration then we would need a bug ticket.

@ifried I think this makes sense, since admins in Mediawiki can delete the pages, and we shouldn't exclude core admins rights and functionalities from the event experience. Meanwhile, we want event creators to be able to delete their own events. This way, they can easily manage their events with minimal hassle.

Curious to hear from @Daimona and @cmelo to see if they agree or have any concerns. Once I hear from them, I can update the acceptance criteria for this ticket and T303723.

@vaughnwalters You are right. I had written some detailed testing notes at T308582#7986041. Since they're for the same deletion feature, you can use them for this task as well. If you want you could also test API and special page together, to make sure that the behaviour is consistent.