Page MenuHomePhabricator
Create Task
Maniphest T303723

Create Validations for the Deleted Event Registration API
Closed, ResolvedPublic
Actions

Description

As a Dev I want to validate the inputed fields before deleting the event registration.

Acceptance criteria:

The event registration id:

  • Must be set
  • Must be an integer
  • Must be a valid event registration id
  • The event registration must not be already deleted

If not should return an error message (Like Event registration not found)

The user id must be the creator of the event for V0

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CampaignEventsmaster+550 -38Add backend logic and REST endpoint for deleting a registration
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmelo created this task.Mar 14 2022, 1:36 PM
Daimona added a project: CampaignEvents.Mar 18 2022, 12:14 PM
Daimona updated the task description. (Show Details)Mar 21 2022, 7:34 PM
Daimona claimed this task.Apr 1 2022, 4:27 PM
gerritbot added a comment.Apr 1 2022, 5:53 PM

Change 776242 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add backend logic and REST endpoint for deleting a registration

https://gerrit.wikimedia.org/r/776242

gerritbot added a project: Patch-For-Review.Apr 1 2022, 5:53 PM
Daimona edited projects, added Campaign-Tools (Campaign-Tools-Sprint-9); removed Campaign-Tools.Apr 1 2022, 5:55 PM
Daimona moved this task from Ready 🎬 to Review/Feedback 💬 on the Campaign-Tools (Campaign-Tools-Sprint-9) board.
ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Sprint-10); removed Campaign-Tools (Campaign-Tools-Sprint-9).Apr 3 2022, 12:05 PM
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Campaign-Tools (Campaign-Tools-Sprint-10) board.Apr 3 2022, 12:07 PM
gerritbot added a comment.Apr 13 2022, 1:38 PM

Change 776242 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add backend logic and REST endpoint for deleting a registration

https://gerrit.wikimedia.org/r/776242

Daimona mentioned this in rUCAM9c96c56d3c10: Add backend logic and REST endpoint for deleting a registration.Apr 13 2022, 1:40 PM
Daimona moved this task from Review/Feedback 💬 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Sprint-10) board.Apr 13 2022, 1:58 PM
Daimona removed a project: Patch-For-Review.
vyuen moved this task from QA 🐛 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-10) board.Apr 14 2022, 5:24 PM
ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Sprint-11); removed Campaign-Tools (Campaign-Tools-Sprint-10).Apr 19 2022, 9:22 PM
ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-11) board.Apr 19 2022, 10:00 PM
ifried added subscribers: vyuen, ifried.Apr 29 2022, 9:37 PM

This seems like it should be included in pre-QTE roll-up. Do you agree, @Daimona & @vyuen?

ifried closed this task as Resolved.Apr 29 2022, 9:50 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Sprint-11) board.

This may also be good for QTE. Do you agree, @Daimona & @vyuen?

Nothing for me to test, so I'll mark this as Done.

Daimona added a comment.Apr 30 2022, 8:22 AM
In T303723#7892832, @ifried wrote:

This may also be good for QTE. Do you agree, @Daimona & @vyuen?

Nothing for me to test, so I'll mark this as Done.

Yes, see T303723#7851532

Daimona added a comment.Apr 30 2022, 8:23 AM
In T303723#7892832, @ifried wrote:

This may also be good for QTE. Do you agree, @Daimona & @vyuen?

Aye

ifried mentioned this in T305708: Pre-QTE tasks roll up.May 2 2022, 4:36 PM

Great, added to T305708

ifried mentioned this in T303722: Just Allow the Event Creator to delete the Event Registration for V0.Mon, Jun 13, 8:10 PM
vaughnwalters added a subscriber: vaughnwalters.Tue, Jun 14, 10:06 PM

AC should change to allow The user Id to be that of the creator of the event or an admin per T303722. Marking this as complete in T305708

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL