[betalabs] Help panel not present when SE article re-opened in Edit mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Mar 15 2022, 1:23 AM

Description

Go to a SE article (not a structured task) - the Suggestion guide panel will be present and it's expanded:

Screen Shot 2022-03-14 at 6.01.41 PM.png (1×2 px, 492 KB)

Click on Edit and make some edits. Submit your edits.
The post-edit dialog appears - click on "Close and edit this article again".
Click on the Edit tab again - the Help panel won't be present in Edit mode.
Re-load the page - the Help panel appears and will be present in Read mode too (click on the animated gif below):

Notes:

The issue descibed above doesn't exist for Structured tasks or non-SE articles
On testwiki wmf.25 - the Help panel is always present in Edit mode; for the SE tasks (not-structured tasks) the Help panel will be present in the Read mode too.

Details

	Subject	Repo	Branch	Lines +/-
	Help panel: Show the help button when editing unstructured tasks again	mediawiki/extensions/GrowthExperiments	master	+17 -2

Customize query in gerrit

Related Objects

Mentioned In: T303553: Help button should not show up when the user edits the suggested article again
Mentioned Here: T303553: Help button should not show up when the user edits the suggested article again

Event Timeline

Etonkovidova created this task.Mar 15 2022, 1:23 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 15 2022, 1:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Etonkovidova updated the task description. (Show Details)Mar 15 2022, 1:55 AM

Etonkovidova mentioned this in T303553: Help button should not show up when the user edits the suggested article again.Mar 15 2022, 2:17 AM

Etonkovidova renamed this task from [betalabs] Help panel is not present when SE article is re-opened in Edit mode to [betalabs] Help panel not present when SE article re-opened in Edit mode.Mar 15 2022, 2:32 AM

Regression from T303553: Help button should not show up when the user edits the suggested article again so moving into current sprint for us to fix.

kostajh triaged this task as Medium priority.Mar 15 2022, 8:15 AM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

My understanding from T303553: Help button should not show up when the user edits the suggested article again is that the help panel should only be shown for the first edit. @RHo can you confirm the expected behavior?

In T303787#7777828, @mewoph wrote:

My understanding from T303553: Help button should not show up when the user edits the suggested article again is that the help panel should only be shown for the first edit. @RHo can you confirm the expected behavior?

Hi @mewoph - sorry I only meant the help panel button shouldn't show up in the post-edit Read mode state. If the user selects to edit the article again, the help panel button will still show up but in the closed state.

• mewoph claimed this task.Mar 15 2022, 4:25 PM

• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 770988 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Help panel: Show the help button when editing unstructured tasks again

https://gerrit.wikimedia.org/r/770988

gerritbot added a project: Patch-For-Review.Mar 15 2022, 5:53 PM

Desktop

Mobile

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 16 2022, 2:44 PM

Change 770988 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Help panel: Show the help button when editing unstructured tasks again

https://gerrit.wikimedia.org/r/770988

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 16 2022, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2022, 4:11 PM

Etonkovidova raised the priority of this task from Medium to Needs Triage.Mar 17 2022, 12:59 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.

Checked on testwiki wmf.1 - the issue is fixed.

	F35007305: copyedit_helpButton_reEdit_mobile.gif
	Mar 15 2022, 5:53 PM

	F35007303: copyedit_helpButton_reEdit_desktop.gif
	Mar 15 2022, 5:53 PM

	F35006028: Screen Shot 2022-03-14 at 6.01.41 PM.png
	Mar 15 2022, 1:23 AM

[betalabs] Help panel not present when SE article re-opened in Edit modeClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[betalabs] Help panel not present when SE article re-opened in Edit mode
Closed, ResolvedPublic
Actions