Page MenuHomePhabricator

Placeholder text does not fit into initial height of Reference insertion box
Closed, ResolvedPublic

Description

  1. Go to https://www.mediawiki.org/w/index.php?title=VisualEditor:Test&veaction=edit
  2. Select Insert > More > Basic reference
  3. Placeholder text does not fit into box
  4. After changing the zoom level in Firefox, it works as expected

Fedora, Firefox 98, 120% zoom

Screenshot from 2022-03-15 08-57-29.png (424×609 px, 31 KB)

Fedora, Chromium 98:

Screenshot from 2022-03-15 09-01-35.png (473×572 px, 25 KB)

Event Timeline

hello, I tried to solve the issue, but how can I show it to you...like any Github link where I can pull a request.

well I think this issue should be with restpect to firefox browser with chrome browser it's ok

hello, I tried to solve the issue, but how can I show it to you...like any Github link where I can pull a request.

Our code is hosted on Gerrit. https://www.mediawiki.org/wiki/Developer_hub is a good place to start.

Change 773653 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Emit ve.ce.Surface 'position' in some more places

https://gerrit.wikimedia.org/r/773653

This can be more easily tested by making the message very long after loading VE:

  • Open VE
  • Paste the following in the console:
mw.messages.set('cite-ve-dialog-reference-placeholder', 'Interdum et malesuada fames ac ante ipsum primis in faucibus. Suspendisse fringilla orci ut arcu molestie ultricies. Nulla in libero a mauris eleifend fringilla vitae id urna. Curabitur a nisi ac elit dapibus sagittis eu a ipsum.')
  • Open the basic cite dialog

Change 773653 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Emit ve.ce.Surface 'position' in some more places

https://gerrit.wikimedia.org/r/773653

Change 777447 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b7893044f)

https://gerrit.wikimedia.org/r/777447

Change 777447 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ffaefe32c)

https://gerrit.wikimedia.org/r/777447

This can be more easily tested by making the message very long after loading VE:

  • Open VE
  • Paste the following in the console:
mw.messages.set('cite-ve-dialog-reference-placeholder', 'Interdum et malesuada fames ac ante ipsum primis in faucibus. Suspendisse fringilla orci ut arcu molestie ultricies. Nulla in libero a mauris eleifend fringilla vitae id urna. Curabitur a nisi ac elit dapibus sagittis eu a ipsum.')
  • Open the basic cite dialog

Thanks for this @Esanders . It was helpful.

It fits perfectly now. Looks like https://photos.app.goo.gl/z9mJqvgeX5w7BoQs6 now.

For reference: it looked like https://photos.app.goo.gl/1pJHoovaUNnpbZWB6 before the fix.

ppelberg claimed this task.