Disallow adding Project Tags in the Subscribers field
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	Aklapper
	Mar 15 2022, 2:04 PM

Description

I spend too much time removing project tags (not: user accounts) from the Subscribers field, and adding them to the Project Tags field.
See also slightly related T130262.

And see also T127719.

Details

	Reference	Source Branch	Dest Branch	Author	Title
	repos/phabricator/phabricator!9	T303829	wmf/stable	aklapper	Do not offer Project Tags to be added to Subscribers fields

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
					Restricted Task
		Resolved	Feature	Aklapper	T303829 Disallow adding Project Tags in the Subscribers field

Event Timeline

See also T303773#7777737 which made me create this ticket, finally.

Josve05a awarded a token.Mar 15 2022, 8:07 PM

Aklapper merged a task: T312734: Prevent addition of projects as subscribers.Jul 11 2022, 6:28 AM

Aklapper added a subscriber: Izno.

RhinosF1 added a subscriber: RhinosF1.Jul 11 2022, 6:39 AM

Lucas_Werkmeister_WMDE awarded a token.Feb 27 2023, 5:40 PM

Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.

fnegri awarded a token.Feb 28 2023, 8:24 AM

fnegri added a subscriber: fnegri.

Aklapper added a parent task: Restricted Task.Apr 4 2023, 12:06 PM

This might be better handled as an option upstream? Putting on my list to evaluate once we've finished T333885: Migrate phabricator.wikimedia.org to Phorge as upstream.

brennen moved this task from INBOX to Priority Backlog 📥 on the Release-Engineering-Team board.May 10 2023, 4:40 PM

brennen edited projects, added Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team.

This one-liner seems to work. But no idea about its side effects as I haven't checked which exact applications within Phabricator use which exact datasource backends (from a quick test, e.g. Herald still allows the condition "Subscribers | include all of | #someProjectTag").

diff --git a/src/applications/transactions/editfield/PhabricatorSubscribersEditField.php b/src/applications/transactions/editfield/PhabricatorSubscribersEditField.php
index 2fdd1e1066..b6acaa4347 100644
--- a/src/applications/transactions/editfield/PhabricatorSubscribersEditField.php
+++ b/src/applications/transactions/editfield/PhabricatorSubscribersEditField.php
@@ -4,7 +4,7 @@ final class PhabricatorSubscribersEditField
   extends PhabricatorTokenizerEditField {
 
   protected function newDatasource() {
-    return new PhabricatorMetaMTAMailableDatasource();
+    return new PhabricatorPeopleDatasource();
   }
 
   protected function newHTTPParameterType() {