Page MenuHomePhabricator

Disallow adding Project Tags in the Subscribers field
Closed, ResolvedPublicFeature


I spend too much time removing project tags (not: user accounts) from the Subscribers field, and adding them to the Project Tags field.
See also slightly related T130262.

And see also T127719.


ReferenceSource BranchDest BranchAuthorTitle
repos/phabricator/phabricator!9T303829wmf/stableaklapperDo not offer Project Tags to be added to Subscribers fields
Customize query in GitLab

Event Timeline

Aklapper created this task.
Aklapper changed the subtype of this task from "Task" to "Feature Request".
Aklapper moved this task from To Triage to Needs code (in Phab or bot) on the Phabricator board.

See also T303773#7777737 which made me create this ticket, finally.

Aklapper added a parent task: Restricted Task.Apr 4 2023, 12:06 PM
brennen added a subscriber: brennen.

This might be better handled as an option upstream? Putting on my list to evaluate once we've finished T333885: Migrate to Phorge as upstream.

This one-liner seems to work. But no idea about its side effects as I haven't checked which exact applications within Phabricator use which exact datasource backends (from a quick test, e.g. Herald still allows the condition "Subscribers | include all of | #someProjectTag").

diff --git a/src/applications/transactions/editfield/PhabricatorSubscribersEditField.php b/src/applications/transactions/editfield/PhabricatorSubscribersEditField.php
index 2fdd1e1066..b6acaa4347 100644
--- a/src/applications/transactions/editfield/PhabricatorSubscribersEditField.php
+++ b/src/applications/transactions/editfield/PhabricatorSubscribersEditField.php
@@ -4,7 +4,7 @@ final class PhabricatorSubscribersEditField
   extends PhabricatorTokenizerEditField {
   protected function newDatasource() {
-    return new PhabricatorMetaMTAMailableDatasource();
+    return new PhabricatorPeopleDatasource();
   protected function newHTTPParameterType() {
Aklapper edited projects, added Phabricator (2023-10-03); removed Phabricator.