Page MenuHomePhabricator
Create Task
Maniphest T303858

Make IP Info available to all users in the 'autoconfirmed' group on testwiki
Closed, ResolvedPublic
Actions

Description

Motivation

IP Info currently requires one edit before the beta feature is available to them. This creates an extra step for users who we'll invite to test IP Info on testwiki. To mitigate this problem, we should make IP Info available as a beta feature to everyone in the 'autoconfirmed' group on testwiki.

AC:

Details

SubjectRepoBranchLines +/-
Allow autoconfirmed users to view basic IP informationoperations/mediawiki-configmaster+4 -2
Create group for revoking IPInfo permissionsmediawiki/extensions/IPInfomaster+14 -0
Revert "Add ipinfo-viewer user group"mediawiki/extensions/IPInfomaster+2 -14
Customize query in gerrit

Related Objects

Event Timeline

• Niharika triaged this task as Medium priority.Mar 15 2022, 5:03 PM
• Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2022, 5:03 PM
Tchanders added subscribers: phuedx, Tchanders.Mar 17 2022, 3:07 PM

@Niharika Do the acceptance criteria need updating with the following?

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Needs Design/Product 🎨 on the Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu) board.Mar 17 2022, 3:10 PM
Tchanders mentioned this in T260598: Deploy IP Info extension to test.wikipedia.org.
• Niharika added a comment.Mar 17 2022, 4:56 PM
  • Create a group for revoking all IPInfo rights using $wgRevokePermissions. This allows individual users' IPInfo rights to be revoked, and will be logged.
  • Revert T296085: Create a group that grants basic ipinfo* rights, since we are no longer granting IPInfo rights via a group.

Yes, I can add these. Thanks.

• Niharika updated the task description. (Show Details)Mar 17 2022, 4:57 PM
Tchanders moved this task from Needs Design/Product 🎨 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu) board.Mar 17 2022, 8:49 PM
Tchanders updated the task description. (Show Details)
Tchanders claimed this task.Mar 21 2022, 1:36 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu) board.
gerritbot added a comment.Mar 21 2022, 2:21 PM

Change 772352 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Revert "Add ipinfo-viewer user group"

https://gerrit.wikimedia.org/r/772352

gerritbot added a project: Patch-For-Review.Mar 21 2022, 2:21 PM
gerritbot added a comment.Mar 21 2022, 2:40 PM

Change 772406 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Create group for revoking IPInfo permissions

https://gerrit.wikimedia.org/r/772406

gerritbot added a comment.Mar 21 2022, 2:45 PM

Change 772408 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Allow autoconfirmed users to view basic IP information

https://gerrit.wikimedia.org/r/772408

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu) board.Mar 21 2022, 2:45 PM
gerritbot added a comment.Mar 21 2022, 4:19 PM

Change 772352 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Revert "Add ipinfo-viewer user group"

https://gerrit.wikimedia.org/r/772352

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.3; 2022-03-22).Mar 21 2022, 5:00 PM
Tchanders mentioned this in T296184: Automatically promote users to the group that grants basic rights.Mar 21 2022, 8:44 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 4: The Stetson); removed MW-1.39-notes (1.39.0-wmf.3; 2022-03-22), Patch-For-Review, IP Info, Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu).Mar 22 2022, 4:57 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 4: The Stetson) board.Mar 22 2022, 5:02 PM
ARamirez_WMF added projects: Patch-For-Review, MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).
ARamirez_WMF removed a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 22 2022, 5:06 PM
ARamirez_WMF added a project: MW-1.39-notes (1.39.0-wmf.3; 2022-03-22).
Tchanders added a comment.Mar 22 2022, 6:13 PM

Testing note: to add a user to the no-ipinfo group, go to Special:UserRights, enter their name, select the "blocked from IP info" group, and save.

gerritbot added a comment.Mar 22 2022, 9:50 PM

Change 772406 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Create group for revoking IPInfo permissions

https://gerrit.wikimedia.org/r/772406

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.4; 2022-03-23); removed MW-1.39-notes (1.39.0-wmf.3; 2022-03-22).Mar 22 2022, 10:00 PM
gerritbot added a comment.Mar 23 2022, 8:49 PM

Change 772408 merged by jenkins-bot:

[operations/mediawiki-config@master] Allow autoconfirmed users to view basic IP information

https://gerrit.wikimedia.org/r/772408

Stashbot added a comment.Mar 23 2022, 9:15 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-23T21:15:30Z] <catrope@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:772408|Allow autoconfirmed users to view basic IP information (T303858)]] and [[gerrit:767216|Enable IPInfo on testwiki (T260598)]] (duration: 00m 50s)

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 4: The Stetson) board.Mar 24 2022, 1:31 PM
Tchanders added subscribers: • imaigwilo, dom_walden.

@dom_walden @imaigwilo Not sure if you want to test this separately - feel free to move to Done if not

dom_walden moved this task from QA/Testing 🐞 to Done Q3 2022 on the Anti-Harassment (AHaT Sprint 4: The Stetson) board.Mar 25 2022, 3:37 PM

I can confirm that "autoconfirmed" users on testwiki can access IPInfo (just the basic viewing rights).

On beta, when I added my autoconfirmed user to the "blocked from IPInfo" group, they no longer had access to IPInfo (either the popup, infobox or Special:Preferences).

Test environments:

dom_walden added a project: IP Info.Mar 28 2022, 9:25 AM
• Niharika closed this task as Resolved.Apr 12 2022, 12:45 AM
MarcoAurelio mentioned this in T309992: Determine who can add/remove users from the no-ipinfo group.Jun 6 2022, 3:08 PM
• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL