Page MenuHomePhabricator
Create Task
Maniphest T303871

SpecialNuke: Call to undefined method Title::getId()
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce

  • Go to Special:Nuke (in German: Spezial:Massenlöschung)
    • Enter a SQL patter, e.g. Foo_12%
    • Namespace = all
    • max pages= 500
    • On the next page select one (or more) of the matches

What happens?:

  • After Submit MediaWiki responds with HTTP 500 and an error page, with this error log:
/mediawiki/index.php?title=Spezial:Massenl%C3%B6schung&action=delete 
Error from line 379 of .../mediawiki/extensions/Nuke/includes/SpecialNuke.php: 
Call to undefined method Title::getId()

Backtrace:

#0 .../mediawiki/extensions/Nuke/includes/SpecialNuke.php(64): SpecialNuke->doDelete(array, string)
#1 .../mediawiki/includes/specialpage/SpecialPage.php(600): SpecialNuke->execute(NULL)
#2 .../mediawiki/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(NULL)
#3 .../mediawiki/includes/MediaWiki.php(307): MediaWikiSpecialPageSpecialPageFactory->executePath(Title, RequestContext)
#4 .../mediawiki/includes/MediaWiki.php(945): MediaWiki->performRequest()
#5 .../mediawiki/includes/MediaWiki.php(548): MediaWiki->main()
#6 .../mediawiki/index.php(53): MediaWiki->run()
#7 .../mediawiki/index.php(46): wfIndexMain()
#8 {main}

What should have happened instead?:
Instead the selected pages should be deleted and no error messages should be shown.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

  • MW 1.35.5
  • SMW, DisplayTitle and many other extensions
  • Maria 10.4.22
  • PHP 7.3.33

The same call is still present in the current master branch:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump required MW version to 1.35.6mediawiki/extensions/NukeREL1_35+1 -1
Bump required MW version to 1.35.6mediawiki/extensions/NukeREL1_36+1 -1
Bump required MW version to 1.35.6mediawiki/extensions/NukeREL1_37+1 -1
Bump required MW version to 1.35.6mediawiki/extensions/NukeREL1_38+1 -1
Bump required MW version to 1.35.6mediawiki/extensions/Nukemaster+1 -1
Fix @since of Title::getId()mediawiki/coreREL1_38+1 -1
Fix @since of Title::getId()mediawiki/coreREL1_37+1 -1
Fix @since of Title::getId()mediawiki/coreREL1_36+1 -1
Fix @since of Title::getId()mediawiki/coremaster+1 -1
Add Title::getId() as an alias for ::getArticleId()mediawiki/coreREL1_35+9 -0
Customize query in gerrit

Event Timeline

Emwiemaikel created this task.Mar 15 2022, 7:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2022, 7:05 PM
Zabe subscribed.Mar 15 2022, 8:00 PM

Title::getId() is documented to be @since 1.35, but it actually is @since 1.36.

gerritbot added a comment.Mar 15 2022, 8:02 PM

Change 771012 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Fix @since of Title::getId()

https://gerrit.wikimedia.org/r/771012

gerritbot added a project: Patch-For-Review.Mar 15 2022, 8:02 PM
gerritbot added a comment.Mar 15 2022, 8:11 PM

Change 771013 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_35] Add Title::getId() as an alias for ::getArticleId()

https://gerrit.wikimedia.org/r/771013

gerritbot added a comment.Mar 15 2022, 9:32 PM

Change 771013 merged by jenkins-bot:

[mediawiki/core@REL1_35] Add Title::getId() as an alias for ::getArticleId()

https://gerrit.wikimedia.org/r/771013

Zabe updated the task description. (Show Details)Mar 15 2022, 9:33 PM
gerritbot added a comment.Mar 15 2022, 9:34 PM

Change 771067 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Nuke@master] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771067

ReleaseTaggerBot added a project: MW-1.35-notes.Mar 15 2022, 10:00 PM
gerritbot added a comment.Mar 17 2022, 5:21 PM

Change 771012 merged by jenkins-bot:

[mediawiki/core@master] Fix @since of Title::getId()

https://gerrit.wikimedia.org/r/771012

gerritbot added a comment.Mar 17 2022, 5:23 PM

Change 771650 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_38] Fix @since of Title::getId()

https://gerrit.wikimedia.org/r/771650

gerritbot added a comment.Mar 17 2022, 5:23 PM

Change 771651 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_37] Fix @since of Title::getId()

https://gerrit.wikimedia.org/r/771651

gerritbot added a comment.Mar 17 2022, 5:23 PM

Change 771652 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_36] Fix @since of Title::getId()

https://gerrit.wikimedia.org/r/771652

gerritbot added a comment.Mar 17 2022, 5:43 PM

Change 771652 merged by jenkins-bot:

[mediawiki/core@REL1_36] Fix @since of Title::getId()

https://gerrit.wikimedia.org/r/771652

gerritbot added a comment.Mar 17 2022, 5:49 PM

Change 771651 merged by jenkins-bot:

[mediawiki/core@REL1_37] Fix @since of Title::getId()

https://gerrit.wikimedia.org/r/771651

gerritbot added a comment.Mar 17 2022, 5:51 PM

Change 771650 merged by jenkins-bot:

[mediawiki/core@REL1_38] Fix @since of Title::getId()

https://gerrit.wikimedia.org/r/771650

Zabe closed this task as Resolved.Mar 17 2022, 5:54 PM
Zabe claimed this task.

Thanks for the report!

This should be fixed in MediaWiki 1.35.6, which is scheduled to be released end of March.

ReleaseTaggerBot added projects: MW-1.36-notes, MW-1.37-notes, MW-1.38-notes, MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 17 2022, 6:00 PM
gerritbot added a comment.Mar 17 2022, 9:38 PM

Change 771067 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771067

gerritbot added a comment.Mar 17 2022, 9:42 PM

Change 771708 had a related patch set uploaded (by Umherirrender; author: Zabe):

[mediawiki/extensions/Nuke@REL1_38] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771708

gerritbot added a comment.Mar 17 2022, 9:42 PM

Change 771709 had a related patch set uploaded (by Umherirrender; author: Zabe):

[mediawiki/extensions/Nuke@REL1_37] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771709

gerritbot added a comment.Mar 17 2022, 9:43 PM

Change 771710 had a related patch set uploaded (by Umherirrender; author: Zabe):

[mediawiki/extensions/Nuke@REL1_36] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771710

gerritbot added a comment.Mar 17 2022, 9:43 PM

Change 771711 had a related patch set uploaded (by Umherirrender; author: Zabe):

[mediawiki/extensions/Nuke@REL1_35] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771711

gerritbot added a comment.Mar 28 2022, 1:18 PM

Change 771708 merged by jenkins-bot:

[mediawiki/extensions/Nuke@REL1_38] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771708

gerritbot added a comment.Mar 28 2022, 1:20 PM

Change 771709 merged by jenkins-bot:

[mediawiki/extensions/Nuke@REL1_37] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771709

gerritbot added a comment.Mar 28 2022, 1:21 PM

Change 771710 merged by jenkins-bot:

[mediawiki/extensions/Nuke@REL1_36] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771710

gerritbot added a comment.Mar 31 2022, 10:55 PM

Change 771711 merged by jenkins-bot:

[mediawiki/extensions/Nuke@REL1_35] Bump required MW version to 1.35.6

https://gerrit.wikimedia.org/r/771711

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits