Page MenuHomePhabricator
Create Task
Maniphest T303876

create edit button for viewer detail side panel
Closed, ResolvedPublic
Actions

Description

  • create button
  • update routing for button to load function editor page for current z-function

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
add detail tab sidebarmediawiki/extensions/WikiLambdamaster+587 -57
add detail tab sidebarmediawiki/extensions/WikiLambdamaster+505 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JKieserman created this task.Mar 15 2022, 7:51 PM
DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Mar 22 2022, 4:24 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
• JKieserman claimed this task.Apr 13 2022, 1:27 PM
• JKieserman moved this task from Incoming to In progress on the Abstract Wikipedia team (Phase θ – Throttling) board.
gerritbot added a comment.Apr 13 2022, 8:30 PM

Change 779567 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] add detail tab sidebar

https://gerrit.wikimedia.org/r/779567

gerritbot added a project: Patch-For-Review.Apr 13 2022, 8:30 PM
• JKieserman moved this task from In progress to Ready: G10. Function calls UX on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 14 2022, 4:30 PM
gerritbot added a comment.Apr 25 2022, 3:12 PM

Change 779567 abandoned by Jkieserman:

[mediawiki/extensions/WikiLambda@master] add detail tab sidebar

Reason:

abandoning in favor of using Adesoji's new table component

https://gerrit.wikimedia.org/r/779567

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2022, 3:31 PM
gerritbot added a comment.Apr 26 2022, 9:24 AM

Change 786280 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] add detail tab sidebar

https://gerrit.wikimedia.org/r/786280

gerritbot added a project: Patch-For-Review.Apr 26 2022, 9:24 AM
gerritbot added a comment.May 3 2022, 3:42 PM

Change 786280 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] add detail tab sidebar

https://gerrit.wikimedia.org/r/786280

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 3 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 3 2022, 4:31 PM
• AdesojiThisDot moved this task from Ready: G10. Function calls UX to Design Review on the Abstract Wikipedia team (Phase θ – Throttling) board.May 5 2022, 8:53 AM
• aishwaryavardhana subscribed.May 17 2022, 1:20 AM

@JKieserman Unclear how to review this.

gengh subscribed.May 17 2022, 1:29 PM

Design review steps:

  1. Go to page: https://notwikilambda.toolforge.org/wiki/Z888
  2. On top menu, click "Details" option
  3. On details page, search for the function details table headed by "Function Definition"
    1. Should be followed by an "Edit" button
    2. On click, this button should redirect to the function editor page for Z888
Jdforrester-WMF moved this task from Design Review to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.May 17 2022, 6:50 PM
DVrandecic closed this task as Resolved.May 17 2022, 6:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits