Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T303844 Implement new function view desktop designs | |||
| Resolved | SimoneThisDot | T303845 create function view page | |||
| Resolved | SimoneThisDot | T303846 create "about" and "details" tabs in the function viewer page | |||
| Resolved | SimoneThisDot | T303880 create details page header buttons and have them load the correct routes |
Event Timeline
@SimoneThisDot moving our Slack conversation to Phabricator!
re: is the button group in codex: If the button group isn't in Codex it should be if I understand correctly, because it is in the DS and was approved by the DS team.
re: link vs. button I don't understand why we cannot open a new page? Are you saying this isn't technically possible or just isn't a good UX? I'm not opposed to a redirect that opens the create tester/implementation page since I know that's more conventional for Wikimedia products, but the design we agreed on and finalized is to open create tester/implementation in a new tab.
re: is the button group in codex:
Me and julia already asked about it, and they said that they are not currently building it and will share its position in the roadmap sooon, then also discussed the possibility for us to actually "implement" the component for them!
re: link vs. button Let me give all the context my I have on this topic, to help you choose the steps forward:
- There is no technical limitation in this issue. Just UX accessbility issues.
- Button and links should not have the same design as they have very different actions
- A button is expected to trigger an action within the current page
- A link is supposed to redirect you or open a new page somewhere else
- My understanding is that it is suggested to avoid redirect in wikimedia (that is why it was agreed to open in a new tab)
- In previous work I did, if there was an BUTTON that then redirected, it would have usually be supported by a notification to say (your object saved and your will now be redirected to XXX). I know we do not do this here, but it was just to tell you how much emphasis a button should have if it redirects! :)
Happy to go forward with buttons if you want, I just wanted to make sure you have the full context of link/button to make a decision.
thanks Simone!
- Sounds good re: button group & codex
- For link vs. button, some times I like to break convention ;) but I hear you. I think they should be links as well. I will need to dive back into Figma and (minorly) redesign the page for this so I'll follow up with a new design.