Page MenuHomePhabricator

🟦 Create 500 error response on exceptions in GET /entities/items/{item_id}
Closed, ResolvedPublic

Description

Story:
WHEN I request GET /entities/items/{item_id} with a valid item ID
AND a generic server or database error occurs
THEN I get 500 HTTP response
AND it contains a unexpected-error code and a message "Unexpected Error"
AND a HTTP header Content-Language set to en

Tasks:

  • catch exceptions in the GetItem use case and return a "failure" GetItemResult (with isSuccessful() == false)
  • the RouteHandler will create an error response (set http status, code, message) based on the GetItemResult

Event Timeline

Ollie.Shotton_WMDE renamed this task from 🟦 Hanlde 500 error in GET /entities/items/{item_id} to 🟦 Create 500 error response on exceptions in GET /entities/items/{item_id}.Mar 16 2022, 9:28 AM
Ollie.Shotton_WMDE updated the task description. (Show Details)
Ollie.Shotton_WMDE updated the task description. (Show Details)

Change 771948 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Implement 500 response for unexpected error

https://gerrit.wikimedia.org/r/771948

Change 771948 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Implement 500 response for unexpected error

https://gerrit.wikimedia.org/r/771948

Change 773752 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Handle unexpected errors in RouteHandler

https://gerrit.wikimedia.org/r/773752

Change 773752 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle unexpected errors in RouteHandler

https://gerrit.wikimedia.org/r/773752

Change 774820 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Set 'Content-Language: en' for 500 errors

https://gerrit.wikimedia.org/r/774820

Change 774820 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Set 'Content-Language: en' for 500 errors

https://gerrit.wikimedia.org/r/774820

WMDE-leszek claimed this task.