Page MenuHomePhabricator

Suggested edits: make task feed reusable
Closed, ResolvedPublic

Description

Currently the task feed is part of SuggestedEditsModule class, which handles both the state management (task queue, which task the user is viewing, which filters are selected etc) and the presentation (showing the task card, showing navigation buttons). The state management and the presentation should be separated so that the task feed can be shown from other modules with a different presentation.

This is needed for T302335: Suggested edits: show the full task feed on post-edit dialog and T303824: Newcomer tasks: Enable filter changes directly on the post-edit dialog when there no suggested edits.

Event Timeline

Change 785235 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: move non-UI logic out of ext.growthExperiments.Homepage.SuggestedEdits

https://gerrit.wikimedia.org/r/785235

@Etonkovidova the above patch touches a lot of the suggested edits code. Doing some spot checks of the happy path as well as edge cases checks for mobile and desktop would be much appreciated.

Change 785235 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: move non-UI logic out of ext.growthExperiments.Homepage.SuggestedEdits

https://gerrit.wikimedia.org/r/785235

@Etonkovidova the above patch touches a lot of the suggested edits code. Doing some spot checks of the happy path as well as edge cases checks for mobile and desktop would be much appreciated.

Overall all seem to be working without any issues. I filed T308887: [testwiki-wmf.12] Task counter doesn't reflect correct number of available tasks - it's a known issue, but the issue is more visible now.