Page MenuHomePhabricator
Create Task
Maniphest T304053

Reusable Story Viewer State and Next Story Button Feature
Closed, ResolvedPublic
Actions

Description

image.png (780×360 px, 218 KB)

  • "Read next story" Feature
  • Refactor the state to be able to reset the frame after the stories/story id state change, the current solution is always destroy the container element and re init the story viewer component.

Details

SubjectRepoBranchLines +/-
Reusable Story Viewer State and Next Story Button Featuremediawiki/extensions/Wikistoriesmaster+129 -52
Customize query in gerrit

Related Objects
Search...

Event Timeline

hueitan created this task.Mar 17 2022, 9:15 AM
hueitan updated the task description. (Show Details)
hueitan moved this task from Backlog to Dev on the Inuka-Team (Kanban) board.
hueitan updated the task description. (Show Details)Mar 18 2022, 2:52 PM
gerritbot added a comment.Mar 23 2022, 10:26 AM

Change 773194 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Reusable Story Viewer State and Next Story Button Feature

https://gerrit.wikimedia.org/r/773194

gerritbot added a project: Patch-For-Review.Mar 23 2022, 10:26 AM
hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Mar 25 2022, 3:48 PM
SBisson moved this task from MVP to Beta on the Wikistories board.Mar 30 2022, 12:28 PM
SBisson edited projects, added Wikistories (Beta); removed Wikistories (MVP).
gerritbot added a comment.Mar 31 2022, 4:05 PM

Change 773194 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Reusable Story Viewer State and Next Story Button Feature

https://gerrit.wikimedia.org/r/773194

hueitan mentioned this in rEWSTbd4dc46d0994: Reusable Story Viewer State and Next Story Button Feature.Mar 31 2022, 4:05 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 31 2022, 4:10 PM
SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Mar 31 2022, 4:27 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 31 2022, 5:00 PM
• EUdoh-WMF subscribed.Apr 21 2022, 5:28 AM

Testing:

This works just fine, user experience-wise.

• EUdoh-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Apr 21 2022, 5:29 AM
SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.May 19 2022, 7:55 AM
SGautam_WMF closed this task as Resolved.May 19 2022, 8:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL