Page MenuHomePhabricator
Create Task
Maniphest T304078

Render "nearby" layer with popus in dynamic maps
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Take the geojson for nearby articles and overlay on a map. This may already be possible using existing code.

  • When clicking the Show nearby articles button render the results of the geosearch query on the map
  • Clicking again hides the "nearby" layer
  • When a marker is clicked, a pop-up appears with the article name shown as a linked title and a description and preview image
  • If there's a mechanism for encapsulating the points in a layer, we should pursue that. Simply injecting the GeoJSON is also an option but maybe not the best.
  • Seems there's no good mechanism for that atm

Details

SubjectRepoBranchLines +/-
Consider thumbnail width/height when rendering nearby popupsmediawiki/extensions/Kartographermaster+25 -12
Nearby: render a popup with thumbnail and article linkmediawiki/extensions/Kartographermaster+39 -8
Add popups for the nearby markersmediawiki/extensions/Kartographermaster+82 -7
Convert nearby results to GeoJSON and rendermediawiki/extensions/Kartographermaster+162 -16
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT90645 A better Nearby for Wikivoyage
 OpenNoneT304076 Nearby feature for maps
 ResolvedAndrew-WMDET304078 Render "nearby" layer with popus in dynamic maps

Event Timeline

awight created this task.Mar 17 2022, 2:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2022, 2:04 PM
lilients_WMDE added a parent task: T304076: Nearby feature for maps.Mar 17 2022, 2:13 PM
lilients_WMDE added a project: WMDE-TechWish-Sprint-2022-03-16.Mar 17 2022, 2:57 PM
WMDE-Fisch moved this task from Backlog to Ready for pickup on the WMDE-GeoInfo-FocusArea board.Mar 22 2022, 11:35 AM
WMDE-Fisch removed a project: WMDE-TechWish-Sprint-2022-03-16.Mar 22 2022, 11:37 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2022-04-13.Apr 13 2022, 12:31 PM
awight moved this task from Ready for pickup to In sprint on the WMDE-GeoInfo-FocusArea board.Apr 13 2022, 12:32 PM
awight updated the task description. (Show Details)Apr 13 2022, 12:55 PM
thiemowmde set the point value for this task to 8.Apr 13 2022, 12:55 PM
awight claimed this task.Apr 14 2022, 2:27 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-04-13 board.

This is coming for free while working on T304077: Map geosearch results to GeoJSON or another appropriate format.

gerritbot added a comment.Apr 14 2022, 3:10 PM

Change 780870 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] [WIP] Convert nearby results to GeoJSON and render

https://gerrit.wikimedia.org/r/780870

gerritbot added a project: Patch-For-Review.Apr 14 2022, 3:10 PM
awight removed awight as the assignee of this task.Apr 14 2022, 4:04 PM
awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2022-04-13 board.

Needs more work to style the markers and show popups with thumbnail. We might end up using PruneCluster after all.

gerritbot added a comment.Apr 14 2022, 8:37 PM

Change 781037 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] Nearby: render a popup with thumbnail and article link

https://gerrit.wikimedia.org/r/781037

awight added a comment.Apr 14 2022, 8:43 PM

Needs some test fixups to make QUnit happy.

gerritbot added a comment.Apr 20 2022, 2:37 PM

Change 780870 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Convert nearby results to GeoJSON and render

https://gerrit.wikimedia.org/r/780870

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 20 2022, 3:01 PM
Andrew-WMDE claimed this task.Apr 22 2022, 9:35 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-04-13 board.
gerritbot added a comment.Apr 22 2022, 2:46 PM

Change 785307 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/Kartographer@master] Add popups for the nearby markers

https://gerrit.wikimedia.org/r/785307

Andrew-WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-04-13 board.Apr 22 2022, 3:52 PM
gerritbot added a comment.Apr 25 2022, 12:34 PM

Change 785307 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add popups for the nearby markers

https://gerrit.wikimedia.org/r/785307

gerritbot added a comment.Apr 26 2022, 10:45 AM

Change 781037 abandoned by Awight:

[mediawiki/extensions/Kartographer@master] Nearby: render a popup with thumbnail and article link

Reason:

Superceded by Ic8e36d4ee43450cda5e30bb9fbc2c161bf87e8ce

https://gerrit.wikimedia.org/r/781037

WMDE-Fisch renamed this task from Render "nearby" layer in dynamic maps to Render "nearby" layer with popus in dynamic maps.Apr 26 2022, 11:01 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-04-13 board.
WMDE-Fisch closed this task as Resolved.Apr 27 2022, 9:20 AM
WMDE-Fisch changed the point value for this task from 8 to 3.
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-04-13 board.
ECohen_WMDE mentioned this in T307707: Markers added by QID to have auto-generated title and description.May 5 2022, 3:40 PM
gerritbot added a comment.Sep 26 2022, 11:14 AM

Change 835119 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Consider thumbnail width/height when rendering nearby popups

https://gerrit.wikimedia.org/r/835119

gerritbot added a comment.Oct 20 2022, 1:14 PM

Change 835119 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Consider thumbnail width/height when rendering nearby popups

https://gerrit.wikimedia.org/r/835119

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 20 2022, 2:00 PM
gerritbot added a comment.Jan 4 2023, 4:14 PM

Change 875357 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Nearby: Must link images to Commons for legal reasons

https://gerrit.wikimedia.org/r/875357

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL