@RHo -- could you please add quick designs here for desktop and mobile?

Also, everyone should note that this is not part of T300851: [EPIC] Growth: "add a link" structured task 2.0 -- it can be prioritized separately or in the future.

@RHo , should we remove this task from the current sprint board? Are you planning to work on this any time soon?

In T304099#7976442, @MShilova_WMF wrote:

@RHo , should we remove this task from the current sprint board? Are you planning to work on this any time soon?

Hi @MShilova_WMF - sorry I should have updated this, the designs are done (adding in the task description) and it is ready for dev. However, it can be moved off if not a priority. So a question for @KStoller-WMF perhaps?

This seems like a good chance to learn more about each structured task and see if we should add more "rejection reasons" or even adjust the algorithm. However, it's also temporary code that will need to be reverted, so it doesn't seem like it's worth a lengthy engineering effort if this will be very complex to implement.
@kostajh do you have an effort estimate for this so we can better prioritize?

In T304099#7979194, @KStoller-WMF wrote:

This seems like a good chance to learn more about each structured task and see if we should add more "rejection reasons" or even adjust the algorithm. However, it's also temporary code that will need to be reverted, so it doesn't seem like it's worth a lengthy engineering effort if this will be very complex to implement.
@kostajh do you have an effort estimate for this so we can better prioritize?

It seems like something that would occupy an engineer's time for 2-3 days. Things we'd have to do:

• config variable (or hardcode) the list of wikis we want this feature to deploy to
• swap out the existing "Other" field with the new one
  • would we want new instrumentation for this field or should we just pretend that it is the existing "other" field for events logged by interacting with it?
• store the text of the field somewhere -- do you want this stored in a user_property or should it go into data logged via EventLogging?

After writing out the above, I think putting the answers into the EventLogging action_data is probably the simplest thing, although I would need to double check the maximum length for data that we could add there.

In T304099#7979212, @kostajh wrote:

• store the text of the field somewhere -- do you want this stored in a user_property or should it go into data logged via EventLogging?

We can't store it in user properties, it is per-task. I agree EventLogging seems like the way to go.

Hi @nettrom_WMF, I wanted to confirm with you the additional field we will be sending for this. I was thinking of adding other_reason field to action_data so that the possible responses for rejection_reason field are uniform regardless of whether this free text field is enabled or not. Does that sound good to you?

For wikis without the text field

"action_data": "link_target=Integrita dat;link_text=integrity dat;probability_score=0.7947532534599304;series_number=0;rejection_reason=other;acceptance_state=rejected"

For wikis with the text field

"action_data": "link_target=Integrita dat;link_text=integrity dat;probability_score=0.7947532534599304;series_number=0;rejection_reason=other;acceptance_state=rejected;other_reason=customreason"

Hi @KStoller-WMF — could you confirm the wikis where this change should be deployed to? I know the description mentions "our four pilot wikis and French" but let's spell this out since the list does change over time so I wanted to be sure.

Change 805226 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Create SelectWithTextInputWidget

https://gerrit.wikimedia.org/r/805226

In T304099#8000339, @mewoph wrote:

Hi @KStoller-WMF — could you confirm the wikis where this change should be deployed to? I know the description mentions "our four pilot wikis and French" but let's spell this out since the list does change over time so I wanted to be sure.

@mewoph Sure, good point.
I updated the description and added the wiki language codes: ES, AR, CZ, BN, FR

Change 805418 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[schemas/event/secondary@master] Add other_reason action_data to image_suggestion_interaction and link_suggestion_interaction schemas

https://gerrit.wikimedia.org/r/805418

Change 805456 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Structured task: Support free text for "other" rejection reason

https://gerrit.wikimedia.org/r/805456

Task type	Desktop	Mobile
Add image
Add link

Sample events:

Add image

event: {
  "action": "close",
  "action_data": "filename=Building_33_with_Hangar_1_in_the_background._View_toward_northwest_-_Naval_Air_Station_Moffett_Field,_Hanger_No._1,_Cummins_Avenue,_Moffett_Field,_Sunnyvale,_Santa_Clara_County,_CA_HAER_CA-335-A-4.tif;recommendation_source=commons;recommendation_source_projects=;series_number=1;total_suggestions=2;rejection_reasons=other;acceptance_state=rejected;other_reason=other reason",
  "is_mobile": true,
  "active_interface": "rejection_dialog",
  "newcomer_task_token": "fp866dankmtjm9lmleptbk79qc4brh9t",
  "page_id": 1799,
  "page_title": "Moffett Field airship hangars",
  "homepage_pageview_token": "bll7c558nmi3cust7iv4jrhsrq84a15p",
  "$schema": "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.4.0",
  "meta": {
    "stream": "mediawiki.structured_task.article.image_suggestion_interaction",
    "domain": "localhost"
  },
  "dt": "2022-06-14T16:27:53.862Z"
}

Add link

event: {
  "action": "close",
  "action_data": "link_target=Metafora;link_text=metafor;probability_score=0.5916731953620911;series_number=0;rejection_reason=other;acceptance_state=rejected;other_reason=other reason",
  "is_mobile": true,
  "active_interface": "rejection_dialog",
  "newcomer_task_token": "9rc4veeilj8mc2ra7ro33fgh66rs9si4",
  "page_id": 181,
  "page_title": "Sobecký gen",
  "homepage_pageview_token": "t9o30gjjs3tigh8eq6493irh7mt2aafr",
  "$schema": "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.7.0",
  "meta": {
    "stream": "mediawiki.structured_task.article.link_suggestion_interaction",
    "domain": "localhost"
  },
  "dt": "2022-06-14T16:44:09.053Z"
}

Change 805480 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[operations/mediawiki-config@master] Structured task: enable free text for "other" rejection reason

https://gerrit.wikimedia.org/r/805480

Change 805418 merged by jenkins-bot:

[schemas/event/secondary@master] Add other_reason action_data to image_suggestion_interaction and link_suggestion_interaction schemas

https://gerrit.wikimedia.org/r/805418

Change 805226 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Create SelectWithTextInputWidget

https://gerrit.wikimedia.org/r/805226

Moving to QA, though we still need to enable in beta labs for QA (I left a comment in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/805480) and then to enable in group2 next Thursday after the train arrives.

Change 805456 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured task: Support free text for "other" rejection reason

https://gerrit.wikimedia.org/r/805456

Change 807576 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[operations/mediawiki-config@master] Structured task: enable free text for "other" rejection reason

https://gerrit.wikimedia.org/r/807576

Change 805480 merged by jenkins-bot:

[operations/mediawiki-config@master] Structured task: enable free text for "other" rejection reason in betalabs

https://gerrit.wikimedia.org/r/805480

In T304099#8022212, @gerritbot wrote:

Change 805480 merged by jenkins-bot:

[operations/mediawiki-config@master] Structured task: enable free text for "other" rejection reason in betalabs

https://gerrit.wikimedia.org/r/805480

This is now deployed, so we can QA the "other" rejection reason on any of the beta labs wikis, cc @Etonkovidova

In T304099#8022240, @kostajh wrote:

In T304099#8022212, @gerritbot wrote:

Change 805480 merged by jenkins-bot:

[operations/mediawiki-config@master] Structured task: enable free text for "other" rejection reason in betalabs

https://gerrit.wikimedia.org/r/805480

This is now deployed, so we can QA the "other" rejection reason on any of the beta labs wikis, cc @Etonkovidova

Checked in beta - all looks as expected; moving to Test in Production.

Only for a limited amount of time (likely one week).

@KStoller-WMF @nettrom_WMF we are enabling this today and the functionality will be available when wmf.18 is in group2, in a couple of hours. Should we plan to disable it 1 week from now, or perhaps on July 11 so there is at least a full week of data?

Change 807576 merged by jenkins-bot:

[operations/mediawiki-config@master] Structured task: enable free text for "other" rejection reason

https://gerrit.wikimedia.org/r/807576

Mentioned in SAL (#wikimedia-operations) [2022-06-30T13:13:06Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: fb399065b123db536ae244a0c0fada61eb906a6e: Structured task: enable free text for "other" rejection reason (T304099) (duration: 03m 46s)

@nettrom_WMF can override me here, but I would suggest disabling ~July 18th, so we have plenty of data and we aren't asking that engineers work on Phab tasks during Inspiration Week.

Checked in production (wmf.18) - all look as expected; keeping the task in Test in Production to check after it'll be disabled.

Note: active_interface: 'rejection_dialog' is present in action: 'confirm_reject_suggestion' and action: 'close'

action: 'confirm_reject_suggestion', action_data: 'filename=French_connection_statue.JPG;recommendati…other;acceptance_state=rejected;other_reason=test', is_mobile: false, active_interface: 'rejection_dialog'

action: 'close', action_data: 'filename=French_connection_statue.JPG;recommendati…other;acceptance_state=rejected;other_reason=test', is_mobile: false, active_interface: 'rejection_dialog'

Change 814708 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] Structured task: Disable free text for "other" rejection reason

https://gerrit.wikimedia.org/r/814708

Change 814708 merged by jenkins-bot:

[operations/mediawiki-config@master] Structured task: Disable free text for "other" rejection reason

https://gerrit.wikimedia.org/r/814708

Mentioned in SAL (#wikimedia-operations) [2022-07-18T07:54:23Z] <kharlan@deploy1002> Synchronized wmf-config: Config: [[gerrit:814708|Structured task: Disable free text for "other" rejection reason (T304099)]] (duration: 02m 41s)