Page MenuHomePhabricator

InvalidArgumentException: The revision does not belong to the given page.
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   InvalidArgumentException: The revision does not belong to the given page.
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.26/includes/page/ParserOutputAccess.php(365)
#0 /srv/mediawiki/php-1.38.0-wmf.26/includes/page/ParserOutputAccess.php(267): MediaWiki\Page\ParserOutputAccess->checkPreconditions(FlaggableWikiPage, MediaWiki\Revision\RevisionStoreRecord, integer)
#1 /srv/mediawiki/php-1.38.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevs.php(826): MediaWiki\Page\ParserOutputAccess->getParserOutput(FlaggableWikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreRecord)
#2 /srv/mediawiki/php-1.38.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevsHooks.php(505): FlaggedRevs::autoReviewEdit(FlaggableWikiPage, User, MediaWiki\Revision\RevisionStoreRecord, array)
#3 /srv/mediawiki/php-1.38.0-wmf.26/includes/HookContainer/HookContainer.php(338): FlaggedRevsHooks::maybeMakeEditReviewed(WikiPage, MediaWiki\Revision\RevisionStoreRecord, boolean, User, array)
#4 /srv/mediawiki/php-1.38.0-wmf.26/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#5 /srv/mediawiki/php-1.38.0-wmf.26/includes/HookContainer/HookRunner.php(3184): MediaWiki\HookContainer\HookContainer->run(string, array)
#6 /srv/mediawiki/php-1.38.0-wmf.26/includes/Storage/PageUpdater.php(1471): MediaWiki\HookContainer\HookRunner->onRevisionFromEditComplete(WikiPage, MediaWiki\Revision\RevisionStoreRecord, boolean, User, array)
#7 /srv/mediawiki/php-1.38.0-wmf.26/includes/Storage/PageUpdater.php(911): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment)
#8 /srv/mediawiki/php-1.38.0-wmf.26/includes/MovePage.php(1007): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment)
#9 /srv/mediawiki/php-1.38.0-wmf.26/includes/MovePage.php(686): MovePage->moveToInternal(User, Title, string, boolean, array)
#10 /srv/mediawiki/php-1.38.0-wmf.26/includes/MovePage.php(532): MovePage->moveUnsafe(User, string, boolean, array)
#11 /srv/mediawiki/php-1.38.0-wmf.26/includes/specials/SpecialMovepage.php(721): MovePage->moveIfAllowed(User, string, boolean)
#12 /srv/mediawiki/php-1.38.0-wmf.26/includes/specials/SpecialMovepage.php(207): MovePageForm->doSubmit()
#13 /srv/mediawiki/php-1.38.0-wmf.26/includes/specialpage/SpecialPage.php(671): MovePageForm->execute(NULL)
#14 /srv/mediawiki/php-1.38.0-wmf.26/includes/specialpage/SpecialPageFactory.php(1378): SpecialPage->run(NULL)
#15 /srv/mediawiki/php-1.38.0-wmf.26/includes/MediaWiki.php(315): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#16 /srv/mediawiki/php-1.38.0-wmf.26/includes/MediaWiki.php(910): MediaWiki->performRequest()
#17 /srv/mediawiki/php-1.38.0-wmf.26/includes/MediaWiki.php(564): MediaWiki->main()
#18 /srv/mediawiki/php-1.38.0-wmf.26/index.php(53): MediaWiki->run()
#19 /srv/mediawiki/php-1.38.0-wmf.26/index.php(46): wfIndexMain()
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}
Impact
Notes

Event Timeline

wrong.png (177×663 px, 8 KB)

heavily went up with the train

Change 771900 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Don't pass the revision to PO access service

https://gerrit.wikimedia.org/r/771900

Change 771907 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@wmf/1.38.0-wmf.26] Don't pass the revision to PO access service

https://gerrit.wikimedia.org/r/771907

Change 771900 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Don't pass the revision to PO access service

https://gerrit.wikimedia.org/r/771900

Change 771907 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.38.0-wmf.26] Don't pass the revision to PO access service

https://gerrit.wikimedia.org/r/771907

Mentioned in SAL (#wikimedia-operations) [2022-03-18T14:26:56Z] <ladsgroup@deploy1002> Synchronized php-1.38.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevs.php: Backport: [[gerrit:771907|Don't pass the revision to PO access service (T304127)]] (duration: 00m 49s)

It should be deployed now. Can you tell if it's fixed? And if the old and new page is in correct shape?

I generally suggest opting out of FlaggedRevs, it's a problematic codebase.

And all are [automatisch gesichtet]. Awesome. Calling it done.