Scrollbars appear in popup on Minerva
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Mar 18 2022, 10:42 AM

Description

What is the problem?

On the Minerva skin at certain zoom levels on Chrome, you can see scrollbars/arrows in the IPInfo popup.

Steps to reproduce problem

Open Chrome
Login as a user with IPInfo
Go to a revision history page (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Barack_Obama_T173949?action=history)
Open the IPInfo popup
Zoom in until you see scrollbars in the popup (the exact zoom level you need will vary)

Environment

Browser: Chromium 87, Chrome 99
Wiki(s): https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (500d7c1) 07:44, 18 March 2022.

Screenshots

scrollbars_chrome_zoom.png (263×378 px, 18 KB)

QA steps

QA in beta cluster

Compare https://en.m.wikipedia.org/wiki/User:Jdlrobson/sandbox with https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson/sandbox

Expected: The text is readable and there are NO visual changes between the two (if not please check the versions of the wikis are different, and request a patchdemo to test this)

QA in production

Compare with this screenshot (taken prior to the change):

Screen Shot 2022-05-17 at 2.46.38 PM.png (1×2 px, 219 KB)

QA Results - Beta

AC	Status	Details
1	✅	T304148#7959119

QA Results - Prod

AC	Status	Details
1	✅	T304148#7981761

Details

Subject	Repo	Branch	Lines +/-
Follow-up I24090527: Add .mw-parser-output scope to limit to parsed output	mediawiki/skins/MinervaNeue	master	+10 -8
Move dd scroll hack to .content scope	mediawiki/skins/MinervaNeue	master	+10 -9
Disable scrollbars of infobox and popup	mediawiki/extensions/IPInfo	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T307177: Unnecessary scrollbars of IPInfo infobox on Minerva
T301938: IPInfo: Use infoFilled for the popup button
Mentioned Here: rSMIN6beae7b0d8db: Localisation updates from https://translatewiki.net.
rSMIN4519cd68f695: Localisation updates from https://translatewiki.net.
T160946: Large inline Math images are not restricted to the viewport
rEIPI500d7c134063: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Mar 18 2022, 10:42 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMar 18 2022, 10:42 AM

dom_walden mentioned this in T301938: IPInfo: Use infoFilled for the popup button.Mar 18 2022, 10:47 AM

Tchanders moved this task from Untriaged to IP Info on the Anti-Harassment board.Mar 21 2022, 1:53 PM

• AGueyte set the point value for this task to 2.Apr 4 2022, 5:11 PM

dom_walden mentioned this in T307177: Unnecessary scrollbars of IPInfo infobox on Minerva.May 3 2022, 6:58 AM

Change 787693 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/extensions/IPInfo@master] Disable scrollbars of infobox and popup

https://gerrit.wikimedia.org/r/787693

gerritbot added a project: Patch-For-Review.May 3 2022, 10:21 AM

@dom_walden Is this still happening? I couldn't reproduce it using the link from the description, or locally (zooming up to 500%, Chrome 101).

In T304148#7899165, @Tchanders wrote:

@dom_walden Is this still happening? I couldn't reproduce it using the link from the description, or locally (zooming up to 500%, Chrome 101).

Yes, I can still reproduce this on Chrome 101 at most zoom levels.

Esanders merged a task: T307177: Unnecessary scrollbars of IPInfo infobox on Minerva.May 3 2022, 2:47 PM

Esanders added a subscriber: StevenSun.

The problem here is that Minerva has a selector dl dd { overflow: auto } for T160946. In my opinion this selector should be scoped down to just content, so we aren't have to undo do it downstream. I'm not sure why this isn't scoped to .content when the other rules in the file (lists.less) are. Maybe @Jdlrobson knows...

(note also that only Vector is actively maintained on desktop, so in general you do not need to prioritise desktop Minerva issues, although this could be an issue for future mobile support)

Jdlrobson edited projects, added MinervaNeue (Desktop); removed MinervaNeue.May 3 2022, 2:54 PM

Change 788723 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/MinervaNeue@master] Move dd scroll hack to .content scope

https://gerrit.wikimedia.org/r/788723

Request for web team to code review. Initial glance looks like this should be low risk.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.May 6 2022, 7:12 PM

Change 787693 abandoned by Steven Sun:

[mediawiki/extensions/IPInfo@master] Disable scrollbars of infobox and popup

Reason:

It will be fixed in upstream.

https://gerrit.wikimedia.org/r/787693

ovasileva triaged this task as Medium priority.May 9 2022, 10:16 AM

Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.May 10 2022, 4:28 PM

cjming claimed this task.May 10 2022, 5:13 PM

Change 788723 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Move dd scroll hack to .content scope

https://gerrit.wikimedia.org/r/788723

DLynch reassigned this task from cjming to Esanders.May 11 2022, 4:39 PM

DLynch added a subscriber: cjming.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 11 2022, 11:30 PM

Will the anti harrasment team QA this or do they need web team to QA?

In T304148#7927445, @Jdlrobson wrote:

Will the anti harrasment team QA this or do they need web team to QA?

@Jdlrobson I can test that this has fixed the bug on IPInfo. However, to test whether this change has affected other parts of the Minerva skin I might need help.

Jdlrobson updated the task description. (Show Details)May 17 2022, 9:47 PM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 8: The Flat Cap); removed Anti-Harassment.May 18 2022, 6:28 AM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 8: The Flat Cap) board.

@Esanders I am still seeing the bug for IPInfo popups and infoboxes on beta.

Example from Chrome 101 Windows 10 (emulated on Saucelabs), screensize 1920x1080, at 100% zoom:

minerva_scrollbars_chrome_101_1920x1080_100zoom.png (936×1 px, 150 KB)

Infobox on Chrome 101 Windows 10 (emulated on Saucelabs), screensize 1280x1024, at 100% zoom:

minerva_scrollbars_infobox_chrome_101_1280x1024_100zoom.png (1×1 px, 59 KB)

https://en.wikipedia.beta.wmflabs.org MinervaNeue – (4519cd6) 06:31, 17 May 2022.

Change 793049 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/MinervaNeue@master] Follow-up I24090527: Add .mw-parser-output scope to limit to parsed output

https://gerrit.wikimedia.org/r/793049

Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.May 19 2022, 9:20 PM

Tchanders moved this task from QA/Testing 🐞 to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 8: The Flat Cap) board.May 20 2022, 4:40 PM

Jdlrobson claimed this task.May 23 2022, 5:25 PM

Change 793049 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Follow-up I24090527: Add .mw-parser-output scope to limit to parsed output

https://gerrit.wikimedia.org/r/793049

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 23 2022, 11:00 PM

Jdlrobson reassigned this task from Jdlrobson to Edtadros.May 23 2022, 11:03 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

dom_walden moved this task from Blocked/Stalled 🚧 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 8: The Flat Cap) board.May 24 2022, 9:21 AM

@Edtadros I have tested the affect of this change on the IPInfo extension. Do you need any help testing the rest of the Minerva skin?

I cannot reproduce this anymore. I have tested the IPInfo popup and infobox on Minerva on:
Browsers:

Chromium 87 (local machine)
Firefox 91 (local machine)
Chrome 101 (windows 10, emulated)
Chrome 100 (macOS catalina, emulated) (only tested revision history)

Pages:

Revision history
Recent Changes
Special:Log
Wishlist
Special:Contributions

Zoom:

100% to 300%

Test environment: https://en.wikipedia.beta.wmflabs.org MinervaNeue – (6beae7b) 06:27, 24 May 2022.

@dom_walden That's very thorough. I don't need any assistance. The QA steps are very straight forward.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Compare https://en.m.wikipedia.org/wiki/User:Jdlrobson/sandbox with https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson/sandbox (@Jdlrobson I'm assuming the steps meant to use the mobile site. If I'm wrong let me know and I will retest.)

✅ AC1: The text is readable and there are NO visual changes between the two (if not please check the versions of the wikis are different, and request a patchdemo to test this)

Screen Recording 2022-05-25 at 7.50.53 PM.mov.gif (1×1 px, 422 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Compare https://en.m.wikipedia.org/wiki/User:Jdlrobson/sandbox with to the screenshot in the description.

✅ AC1: The text is readable and there are NO visual changes between the two

Screen Shot 2022-06-05 at 5.56.59 PM.png (813×1 px, 91 KB)

Edtadros updated the task description. (Show Details)Jun 6 2022, 1:02 AM

Looks good! Resolving

Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM

	F35210229: Screen Shot 2022-06-05 at 5.56.59 PM.png
	Jun 6 2022, 1:01 AM

	F35177790: Screen Recording 2022-05-25 at 7.50.53 PM.mov.gif
	May 26 2022, 2:56 AM

	F35151340: minerva_scrollbars_chrome_101_1920x1080_100zoom.png
	May 18 2022, 1:08 PM

	F35151353: minerva_scrollbars_infobox_chrome_101_1280x1024_100zoom.png
	May 18 2022, 1:08 PM

	F35149969: Screen Shot 2022-05-17 at 2.46.38 PM.png
	May 17 2022, 9:47 PM

Scrollbars appear in popup on MinervaClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

What is the problem?

Steps to reproduce problem

Environment

Screenshots

QA steps

QA in beta cluster

QA in production

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Scrollbars appear in popup on Minerva
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions