| Klein | |
| Mar 19 2022, 5:47 PM |
| F35012113: Screenshot 2022-03-19 at 18-53-07 rEWLE1d1aa2292042.png | |
| Mar 19 2022, 5:54 PM |
| F35012111: Screenshot 2022-03-19 at 18-53-22 rEWLE1d1aa2292042.png | |
| Mar 19 2022, 5:54 PM |
List of steps to reproduce (step by step, including full links if applicable):
What happens?:
There is a missing space.
What should have happened instead?:
There should have not been a missing space.
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
| How it looks like | How it should look like |
|---|---|
 |  |
This is a typical case where a screenshot helps a lot, especially to check afterwards that it has been fixed – if the space is no longer there, it’s impossible to tell whether the space has been added or you just referred to something else.
I'm sorry. I genuinely didn't think we'd need these much details about a fixing a typo. But you're right. I'll keep that in mind if other similar cases do arise.
Both strings are in https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/controller/DiffusionCommitController.php , not sure how to best concatenate.
The link requires login. ☹ Do we have a publicly accessible copy of it on phabricator.wikimedia.org or gitlab.wikimedia.org?
Not technically the same link (one is the upstream, one is the WMF fork), but https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/blob/wmf/stable/src/applications/diffusion/controller/DiffusionCommitController.php