Page MenuHomePhabricator

Decommission the AdvancedSearchRequest instrument
Closed, ResolvedPublic

Description

In T303709: Decide whether to keep the AdvancedSearchRequest data stream, the decision to decommission the AdvancedSearchRequest instrument was made. This task tracks the follow-up work to decommission it.

TODO

Event Timeline

Change 772389 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Remove all AdvancedSearchRequest EventLogging code

https://gerrit.wikimedia.org/r/772389

Remove the AdvancedSearchRequest event sanitisation allowlist entry
Request the deletion of any previously allowlisted data if it's necessary

There's no such entry in the allowlist. There's no event_sanitized.advancedsearchrequest table either.

@Tobi_WMDE_SW @Lena_WMDE: Do you know if anyone is using the MediaWiki AdvancedSearch Grafana dashboard? If not, can it and the client-side logging code that powers it be removed as part of this task?

Edit

To be clear, this is a different dashboard from the one powered by the code in the analytics/wmde/TW/AdvancedSearchExtension-Dashboard repo.

Change 772803 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] [DNM] Remove remaining expand/collapse tracking instrumentation

https://gerrit.wikimedia.org/r/772803

phuedx updated the task description. (Show Details)

Mark the schema as inactive by editing the SchemaDoc template on the schema's talk page

See https://meta.wikimedia.org/w/index.php?title=Schema_talk%3AAdvancedSearchRequest&type=revision&diff=23039437&oldid=20139798

Change 772389 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Remove all AdvancedSearchRequest EventLogging code

https://gerrit.wikimedia.org/r/772389

Undeploy the Advanced Search dashboard

The Advanced Search dashboard created and deployed in T180571: Shiny Dashboard for usage of the AdvancedSearch extension. It was available at https://wdcm.wmflabs.org/TW_AdvancedSearchExtension/ but isn't any more (nor is https://wdcm.wmflabs.org/).

@Tobi_WMDE_SW @Lena_WMDE: Do you know if anyone is using the MediaWiki AdvancedSearch Grafana dashboard? If not, can it and the client-side logging code that powers it be removed as part of this task?

Edit

To be clear, this is a different dashboard from the one powered by the code in the analytics/wmde/TW/AdvancedSearchExtension-Dashboard repo.

Not to my knowledge but it's something @Lena_WMDE has to confirm once she's back. @awight @WMDE-Fisch any reason to keep it?

@WMDE-Fisch, half of the board https://grafana.wikimedia.org/d/000000434/mediawiki-advancedsearch already stopped working because of the decision made in T350411. I'm pretty sure we should archive the second half as well.

@WMDE-Fisch, half of the board https://grafana.wikimedia.org/d/000000434/mediawiki-advancedsearch already stopped working because of the decision made in T350411. I'm pretty sure we should archive the second half as well.

I would like to have a last chat with PM about that. We're currently using parts of it on https://grafana.wikimedia.org/d/Dlfw2L4Sk/overview-of-techwish-features?orgId=1 for a general overview on feature health. I'll put it on the agenda.

I'm going to be bold and split out the review of the remaining half of the dashboard mentioned above into a separate task. AFAICT this task is Done™ (the AdvancedSearchRequest Legacy EventLogging instrumentation has been decommissioned). Closing this out would help Data Platform Engineering better understand the current state of the Legacy EventLogging system.

phuedx claimed this task.
phuedx updated the task description. (Show Details)
phuedx updated the task description. (Show Details)

Being bold. My sincere thanks to all involved <3

Change #772803 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Remove remaining expand/collapse tracking docs

https://gerrit.wikimedia.org/r/772803