| Arlolra | |
| Mar 21 2022, 5:42 PM |
| F35322519: Screen Shot 2022-07-19 at 6.04.32 PM.png | |
| Jul 19 2022, 10:09 PM |
| F35322518: Screen Shot 2022-07-19 at 6.04.25 PM.png | |
| Jul 19 2022, 10:09 PM |
| F35322517: Screen Shot 2022-07-19 at 6.04.14 PM.png | |
| Jul 19 2022, 10:09 PM |
| F35013980: Screenshot 2022-03-21 at 12.55.03.png | |
| Mar 21 2022, 5:42 PM |
This is because the thumb spacing styling has moved onto the 'thumb image' class (the border is now on the content, instead of on the wrapper of the contents. Here too, after the content replacement for the JS player, the <audio> element is wrapped inside the span, but the span has a fixed size, which is expecting the dimensions without the padding and the border.
Filed as part of T304010
Change 812384 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/core@master] [WIP] Add styles for a class on the mw-file-element
Change 812387 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/extensions/TimedMediaHandler@master] [WIP] Make span the mw-file-element
There's also an issue with the line height.
This is the current rendering of an audio thumb ([[File:1951-test.wav|thumb|wave!]]),
This is what it looks like with $wgParserEnableLegacyMediaDOM = false;
This is after applying the change in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/812383
Change 812383 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/core@master] Suppress line-height inside thumbs
Change 812384 merged by jenkins-bot:
[mediawiki/core@master] Use a universal selector (*) to match the media element
Change 812387 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Swap the media element with a span
Change 820544 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/TimedMediaHandler@master] Stop requiring resources/config.json
Change 820544 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Stop requiring resources/config.json
The issue with the width seems resolved,
https://www.mediawiki.org/w/index.php?title=User:Arlolra/sandbox&oldid=5421194
https://en.wikipedia.org/w/index.php?title=User:Arlolra/sandbox&oldid=1105004805
But the problem with T304343#8089434 remains and T304343#8089438 should be revived
Change 812383 merged by jenkins-bot:
[mediawiki/core@master] Suppress line-height inside thumbs
Change 930276 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/Timeless@master] Copy upstream change to suppress line-height in thumbs
Change 930276 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Copy upstream change to suppress line-height in thumbs
Change 932352 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/extensions/TimedMediaHandler@master] Fix audio player being too wide when !parserEnableLegacyMediaDOM
Change 932352 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix audio player being too wide when !parserEnableLegacyMediaDOM