Remove runtime handling for "legacy" rows and codepaths
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Mar 21 2022, 9:56 PM

Description

As seen in the revert in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/772464, there is quite a lot of code that depends on things like property_exists and checking for SQL columns that may or may not exist.

We don't need to do this at runtime (ie during a normal MW request/OATHAuth auth flow). There are updaters (run via update.php) that should be taking care of that migration, and WMF production has been migrated a long time ago.

The Update scripts and any code they directly call would need to stay, other usages do not.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
ApiOATHValidate: Remove deprecated totp parameter	mediawiki/extensions/OATHAuth	master	+9 -29
OATHUserRepository: Stop handling legacy single-key	mediawiki/extensions/OATHAuth	master	+1 -5
OATHUserRepository: Remove some legacy handling	mediawiki/extensions/OATHAuth	master	+2 -47

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Reedy	T304375 Remove runtime handling for "legacy" rows and codepaths
Resolved	Reedy	T304870 Update usages of deprecated action=oathvalidate&totp=
Resolved	Reedy	T304869 StrikerBot doing deprecated action=oathvalidate&totp= queries
Resolved	dcaro	T304918 cloud: horizon login fails with invalid credentials
Invalid	None	T304874 archive.org_bot making deprecated action=oathvalidate&totp= queries

Event Timeline

Reedy created this task.Mar 21 2022, 9:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2022, 9:56 PM

Reedy renamed this task from Remove handling for "legacy" rows to Remove runtime handling for "legacy" rows.Mar 21 2022, 9:56 PM

Reedy updated the task description. (Show Details)

Change 772530 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] OATHUserRepository: Remove some legacy handling

https://gerrit.wikimedia.org/r/772530

gerritbot added a project: Patch-For-Review.Mar 22 2022, 12:00 AM

Change 772530 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] OATHUserRepository: Remove some legacy handling

https://gerrit.wikimedia.org/r/772530

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 25 2022, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2022, 9:10 PM

Change 773914 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] OATHUserRepository: Stop handling legacy single-key

https://gerrit.wikimedia.org/r/773914

gerritbot added a project: Patch-For-Review.Mar 26 2022, 9:47 AM

Change 773918 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] ApiOATHValidate: Remove deprecated totp parameter

https://gerrit.wikimedia.org/r/773918

Need to see if people are still using action=oathvalidate&user=Example&totp=

Was deprecated in June 2019 in rEOATea984e5c2b2e: Refactor the extension to support multiple auth modules

Change 773914 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] OATHUserRepository: Stop handling legacy single-key

https://gerrit.wikimedia.org/r/773914

Reedy mentioned this in T304869: StrikerBot doing deprecated action=oathvalidate&totp= queries.Mar 28 2022, 4:33 PM

Reedy renamed this task from Remove runtime handling for "legacy" rows to Remove runtime handling for "legacy" rows and codepaths.Mar 28 2022, 5:08 PM

Reedy added a subtask: T304870: Update usages of deprecated action=oathvalidate&totp=.