Page MenuHomePhabricator
Create Task
Maniphest T304377

Wikimedia\Assert\PreconditionException: Precondition failed: Range is not collapsed (from CommentUtils::isSingleCommentSignedBy)
Closed, ResolvedPublic
Actions

Description

In T299583#7794643, @brennen wrote:

Seeing this again in 1.39.0-wmf.2 (T300203):

Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Assert\PreconditionException: Precondition failed: Range is not collapsed
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.2/vendor/wikimedia/assert/src/Assert.php(49)
#0 /srv/mediawiki/php-1.39.0-wmf.2/extensions/DiscussionTools/includes/CommentUtils.php(552): Wikimedia\Assert\Assert::precondition(boolean, string)
#1 /srv/mediawiki/php-1.39.0-wmf.2/extensions/DiscussionTools/includes/CommentUtils.php(663): MediaWiki\Extension\DiscussionTools\CommentUtils::getRangeFirstNode(MediaWiki\Extension\DiscussionTools\ImmutableRange)
#2 /srv/mediawiki/php-1.39.0-wmf.2/extensions/DiscussionTools/includes/CommentUtils.php(609): MediaWiki\Extension\DiscussionTools\CommentUtils::compareRangesAlmostEqualBoundaries(MediaWiki\Extension\DiscussionTools\ImmutableRange, MediaWiki\Extension\DiscussionTools\ImmutableRange, string)
#3 /srv/mediawiki/php-1.39.0-wmf.2/extensions/DiscussionTools/includes/CommentUtils.php(739): MediaWiki\Extension\DiscussionTools\CommentUtils::compareRanges(MediaWiki\Extension\DiscussionTools\ImmutableRange, MediaWiki\Extension\DiscussionTools\ImmutableRange)
#4 /srv/mediawiki/php-1.39.0-wmf.2/extensions/DiscussionTools/includes/ApiDiscussionToolsPreview.php(61): MediaWiki\Extension\DiscussionTools\CommentUtils::isSingleCommentSignedBy(MediaWiki\Extension\DiscussionTools\ThreadItemSet, string, Wikimedia\Parsoid\DOM\Element)
#5 /srv/mediawiki/php-1.39.0-wmf.2/includes/api/ApiMain.php(1893): MediaWiki\Extension\DiscussionTools\ApiDiscussionToolsPreview->execute()
#6 /srv/mediawiki/php-1.39.0-wmf.2/includes/api/ApiMain.php(870): ApiMain->executeAction()
#7 /srv/mediawiki/php-1.39.0-wmf.2/includes/api/ApiMain.php(841): ApiMain->executeActionWithErrorHandling()
#8 /srv/mediawiki/php-1.39.0-wmf.2/api.php(90): ApiMain->execute()
#9 /srv/mediawiki/php-1.39.0-wmf.2/api.php(45): wfApiMain()
#10 /srv/mediawiki/w/api.php(3): require(string)
#11 {main}

I'm making a separate task because the stack trace is different, This exception is coming from the newly introduced method CommentUtils::isSingleCommentSignedBy() (added in rEDTO0ecc8a4c051d: Improve detecting already signed comments).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CommentUtils: Fix isSingleCommentSignedBy() with empty headingmediawiki/extensions/DiscussionToolsmaster+16 -6
Customize query in gerrit

Related Objects

Event Timeline

• matmarex created this task.Mar 21 2022, 10:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2022, 10:35 PM
• matmarex mentioned this in T299583: Wikimedia\Assert\PreconditionException: Precondition failed: Range is not collapsed.Mar 21 2022, 10:37 PM

Also it looks like there are only 8 occurrences in total, so it doesn't seem like a train blocker.

I can reproduce the error by trying to preview (or add) a new topic with a heading containing only space characters (but not empty).

gerritbot added a comment.Mar 21 2022, 11:12 PM

Change 772521 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] CommentUtils: Fix isSingleCommentSignedBy() with empty heading

https://gerrit.wikimedia.org/r/772521

gerritbot added a project: Patch-For-Review.Mar 21 2022, 11:12 PM
• matmarex claimed this task.Mar 21 2022, 11:13 PM
• matmarex added a project: Editing-team (Kanban Board).
• matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Mar 21 2022, 11:45 PM

Change 772521 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentUtils: Fix isSingleCommentSignedBy() with empty heading

https://gerrit.wikimedia.org/r/772521

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 21 2022, 11:46 PM
DLynch added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.3; 2022-03-22).Mar 22 2022, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 22 2022, 12:10 AM
• matmarex added a comment.Mar 22 2022, 12:58 AM
In T304377#7794875, @matmarex wrote:

I can reproduce the error by trying to preview (or add) a new topic with a heading containing only space characters (but not empty).

I forgot to note: the error causes the live preview to stop updating, and an error message like below when trying to add the topic:

image.png (1×3 px, 160 KB)

(I won't bother backporting the fix, because of the daily the train experiment it should be deployed tomorrow.)

Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Mar 22 2022, 1:46 PM
EAkinloose subscribed.EditedMar 23 2022, 12:01 AM

Live preview updates fine and I am able to add topic. See

Screenshot 2022-03-23 at 00.57.41.png (952×2 px, 130 KB)

Screenshot 2022-03-23 at 01.03.32.png (1×1 px, 162 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Mar 23 2022, 12:02 AM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 23 2022, 12:04 AM
• matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Mar 24 2022, 3:08 PM
ppelberg closed this task as Resolved.Mar 24 2022, 3:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits