Split Menu template into more specific templates
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	bwang
	Mar 22 2022, 9:24 PM

Description

Background

Currently the Menu template handles 4 different types of UI (dropdowns, tabs, portal and default), each with their own separate visual, functional and accessibility requirements. Splitting up the Menu template would allow for markup that is specific to a particular use case, and more easily maintainable.

Should be completed after T291304

Suggested behavior

Menu.template is broken into templates corresponding to Dropdowns, Tabs, and a default generic Menu (perhaps it could be renamed simply to "List"?). Given that "portal" menus will eventually be removed from modern Vector, there isn't a need to create a template for that.
The original markup should be preserved for Legacy vector.

Developer notes

Dropdowns should include an input checkbox element linked to a label element. Other menus don't need a label element.

Related Objects

Mentioned In: T301051: Vector 2022’s language button is inaccessible
Mentioned Here: T301051: Vector 2022’s language button is inaccessible
T291304: Simplify and remove extraneous navigation landmark regions from modern Vector

Event Timeline

bwang created this task.Mar 22 2022, 9:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2022, 9:24 PM

bwang updated the task description. (Show Details)Mar 22 2022, 9:25 PM

bwang mentioned this in T301051: Vector 2022’s language button is inaccessible.Mar 22 2022, 9:44 PM

Funny enough when we began this project they were the same templates.

I think the challenge of splitting them if we'd have to keep consistency between the classes that are shared between them (in Vue this would use some kind of composition)

Jdlrobson moved this task from Backlog to Vector code cleanup on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Mar 30 2022, 10:38 PM

Jdlrobson moved this task from Needs triage to Technical on the Vector (legacy skin) board.Apr 25 2022, 9:34 PM

Closing because this task is no longer required after work in https://phabricator.wikimedia.org/T301051 and https://phabricator.wikimedia.org/T291304

bwang closed this task as Resolved.May 12 2022, 10:14 PM