Page MenuHomePhabricator
Create Task
Maniphest T304468

Language links not correctly displayed in Commons with the new Vector (2022) skin
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
Edtadros
Authored By
Robby
Mar 22 2022, 10:51 PM
Tags
Referenced Files
F35054677: Screen Shot 2022-04-16 at 6.05.39 PM.png
Apr 17 2022, 1:08 AM
F35054678: Screen Shot 2022-04-16 at 6.06.07 PM.png
Apr 17 2022, 1:08 AM
F35054679: Screen Shot 2022-04-16 at 6.06.43 PM.png
Apr 17 2022, 1:08 AM
F35048585: Screen Shot 2022-04-12 at 3.28.23 PM.png
Apr 12 2022, 10:32 PM
F35048583: Screen Shot 2022-04-12 at 3.28.01 PM.png
Apr 12 2022, 10:32 PM
F35048588: Screen Shot 2022-04-12 at 3.28.50 PM.png
Apr 12 2022, 10:32 PM
F35020475: New Vector (2022) skin - 2022-03-22 23_38_04-Category_Novelists from Romania - Wikimedia Commons — Mozilla Firefox.png
Mar 22 2022, 10:55 PM
F35020482: Legacy Vector skin - 2022-03-22 23_38_04-Category_Novelists from Romania - Wikimedia Commons — Mozilla Firefox.png
Mar 22 2022, 10:55 PM
Subscribers
Aklapper
bwang
DerHexer
Jdlrobson
Jdrewniak
Lydia_Pintscher
Mike_Peel
View All 9 Subscribers

Description

Since a few days the Wikipedia language links on Commons are no longer displayed correctly if the new Vector skin is used while everything is displayed correctly displayed.

In order ot illustrate this I will add 2 printscreens of the wikipedia language links for the page: https://commons.wikimedia.org/wiki/Category:Novelists_from_Romania

Developer notes

To see language in sidebar:

$wgVectorLanguageInHeader = [
 "logged_in" => false,
"logged_out" => false

QA Results - Prod

ACStatusDetails
1✅T304468#7859513

Details

SubjectRepoBranchLines +/-
Scope ULS styles to when language button is in headermediawiki/skins/Vectormaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

Robby created this task.Mar 22 2022, 10:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2022, 10:51 PM
Robby added a comment.Mar 22 2022, 10:55 PM

Wikipedia language links with the new Vector Skin

New Vector (2022) skin - 2022-03-22 23_38_04-Category_Novelists from Romania - Wikimedia Commons — Mozilla Firefox.png (762×362 px, 10 KB)

Wikipedia language links with the legacy Vector Skin
Legacy Vector skin - 2022-03-22 23_38_04-Category_Novelists from Romania - Wikimedia Commons — Mozilla Firefox.png (659×322 px, 18 KB)

Robby added a subscriber: Lydia_Pintscher.Mar 22 2022, 10:56 PM
Jdlrobson added projects: Regression, Web-Team-Backlog (Kanbanana-FY-2021-22).Mar 23 2022, 4:54 AM
Robby added a subscriber: DerHexer.Mar 23 2022, 8:09 AM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 23 2022, 4:40 PM
Jdlrobson added subscribers: bwang, Jdrewniak, Jdlrobson.Mar 23 2022, 4:43 PM

The element is in the DOM, it's just hidden. I believe this is a recent regression possibly relating to @bwang recent refactorings or 80d734b4 (@Jdrewniak). I'd suggest we add a class to the body for this feature flag and limit all the language button styles.

Jdlrobson mentioned this in T304601: Vector 2022 inconsistent style of "in other languages" when editing in old wikitext editor.Mar 24 2022, 3:14 PM
ovasileva triaged this task as High priority.Mar 24 2022, 5:19 PM
LGoto moved this task from Incoming to Language Switching on the Desktop Improvements (Vector 2022) board.Mar 31 2022, 5:10 PM
Jdlrobson updated the task description. (Show Details)Mar 31 2022, 5:14 PM
LGoto set the point value for this task to 2.Mar 31 2022, 5:15 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang claimed this task.Apr 4 2022, 3:11 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang added a comment.Apr 4 2022, 9:21 PM

@Jdlrobson I did some more digging and it seems the regression is from this selector change. Does it make sense to just revert that change and restrict LanguageButton.less styles to the language button in the header?

Jdlrobson added a comment.Apr 4 2022, 11:22 PM

Let's update that selector to use a class on the body since this is an example of a feature that varies based on the site. We have vector-sticky-header-enabled for sticky header, REQUIREMENT_LANGUAGE_IN_HEADER , skin-vector-search-vue for search and should have one for this too. Since certain projects don't have desktop improvements on by default this will allow for smoother roll out /ability do cherry pick features - using a generic selector that applies to cached HTML and fresh HTML should be avoided.

Perhaps a class could be auto-added to the body tag by the FeatureManagement system in future.

bwang removed bwang as the assignee of this task.Apr 6 2022, 6:42 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 6 2022, 7:16 PM
gerritbot added a comment.Apr 6 2022, 7:16 PM

Change 777817 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Scope ULS styles to when language button is in header

https://gerrit.wikimedia.org/r/777817

gerritbot added a project: Patch-For-Review.Apr 6 2022, 7:16 PM
bwang claimed this task.Apr 7 2022, 5:03 PM
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 7 2022, 5:45 PM
gerritbot added a comment.Apr 9 2022, 12:07 AM

Change 777817 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Scope ULS styles to when language button is in header

https://gerrit.wikimedia.org/r/777817

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2022, 12:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 9 2022, 1:00 AM
Jdlrobson reassigned this task from bwang to Edtadros.Apr 11 2022, 5:07 PM
Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 12 2022, 10:32 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta commons
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Wikipedia language links are displayed correctly.

Vector 2022 w TOC Vector 2022 wo TOC Vector Legacy
Screen Shot 2022-04-12 at 3.28.01 PM.png (886×541 px, 126 KB)
Screen Shot 2022-04-12 at 3.28.23 PM.png (893×682 px, 161 KB)
Screen Shot 2022-04-12 at 3.28.50 PM.png (881×663 px, 140 KB)
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 17 2022, 1:08 AM

Test Result - Prod

Status: ✅ PASS
Environment: commons
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Wikipedia language links are displayed correctly.

Vector 2022 w TOC Vector 2022 wo TOC Vector Legacy
Screen Shot 2022-04-16 at 6.06.43 PM.png (1×1 px, 651 KB)
Screen Shot 2022-04-16 at 6.06.07 PM.png (1×1 px, 628 KB)
Screen Shot 2022-04-16 at 6.05.39 PM.png (1×1 px, 597 KB)
Edtadros updated the task description. (Show Details)Apr 17 2022, 1:10 AM
ovasileva closed this task as Resolved.Apr 19 2022, 9:31 AM
ovasileva subscribed.

Looks good!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL