Page MenuHomePhabricator
Create Task
Maniphest T304522

Display errors on invalid form submission on Special:SimilarEditors
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

From T296214:

  • Submitting the form with an invalid value shows an error. Examples of invalid values are as follows:
  • "" (the empty string)
  • A username that doesn't exist
  • An IP address that isn't a valid IPv{4,6} address

Submitting with valid input doesn't do anything yet.

Details

SubjectRepoBranchLines +/-
Add input validation for SimilarEditors formmediawiki/extensions/SimilarEditorsmaster+17 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Mar 23 2022, 2:53 PM
Tchanders moved this task from Untriaged to Similar Editors on the Anti-Harassment board.Mar 24 2022, 4:17 PM
Tchanders set the point value for this task to 3.Apr 19 2022, 4:13 PM
Tchanders moved this task from Similar Editors to AHaT Sprint 5: The Bearskin on the Anti-Harassment board.Apr 25 2022, 4:32 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 5: The Bearskin); removed Anti-Harassment.
Tchanders moved this task from AHaT Sprint 5: The Bearskin to AHaT Sprint 6: The Bigouden on the Anti-Harassment board.Apr 25 2022, 4:44 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 6: The Bigouden); removed Anti-Harassment (AHaT Sprint 5: The Bearskin).
STran claimed this task.Apr 27 2022, 1:23 AM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.
gerritbot added a comment.Apr 27 2022, 2:34 AM

Change 786439 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/SimilarEditors@master] Add input validation for SimilarEditors form

https://gerrit.wikimedia.org/r/786439

gerritbot added a project: Patch-For-Review.Apr 27 2022, 2:34 AM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 27 2022, 2:46 AM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In progress on the Similarusers board.Apr 27 2022, 5:20 PM
gerritbot added a comment.Apr 27 2022, 6:24 PM

Change 786439 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Add input validation for SimilarEditors form

https://gerrit.wikimedia.org/r/786439

STran moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 27 2022, 6:25 PM
STran mentioned this in rESIEf6c906220f11: Add input validation for SimilarEditors form.Apr 27 2022, 6:26 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 27 2022, 6:30 PM
Tchanders moved this task from In progress to Done on the Similarusers board.Apr 29 2022, 12:22 PM
Tchanders added subscribers: • imaigwilo, dom_walden.Apr 29 2022, 12:31 PM

@imaigwilo @dom_walden Here's a task for the bug we found in our meeting about testing, where errors display when first loading Special:SimilarEditors: T307211

• imaigwilo added a comment.EditedApr 29 2022, 10:15 PM

Thanks @Tchanders

Screen Shot 2022-04-28 at 6.40.26 PM.png (1×2 px, 309 KB)

Screen Shot 2022-04-29 at 6.16.30 PM.png (1×2 px, 319 KB)

Screen Shot 2022-04-29 at 6.15.11 PM.png (1×2 px, 328 KB)

• imaigwilo moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.May 1 2022, 8:48 PM
• Niharika closed this task as Resolved.May 17 2022, 5:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL