Page MenuHomePhabricator

Score extension using deprecated errorbox class
Closed, ResolvedPublic

Description

protected function getCSSClasses(): array {
  return [ 'errorbox', 'mw-ext-score-error' ];
}

should be updated to use [ 'mw-message-box-error' , 'errorbox', 'mw-ext-score-error' ] to avoid lose of styling.

Event Timeline

Change 772903 had a related patch set uploaded (by Klein Muçi; author: Klein Muçi):

[mediawiki/extensions/Score@master] Update errorbox class

https://gerrit.wikimedia.org/r/772903

@Jdlrobson, sorry for the noobish question but can you tell me what's the file's path that should be edited in the said extension? I'd like to help but I'm still not that versatile in these details. This seemed like a pretty straightforward job and I thought it could help me build more self-trust if I could get it done.

@Klein it looks like https://gerrit.wikimedia.org/g/mediawiki/extensions/Score/+/d99a2722f62173ecc85e8e8108ee6e115cfca31a/includes/ScoreException.php#71 but note to fix this you'll also need to be setup to test this extension which might be a little trickier unless you are using something like MediaWiki vagrant.

@Klein it looks like https://gerrit.wikimedia.org/g/mediawiki/extensions/Score/+/d99a2722f62173ecc85e8e8108ee6e115cfca31a/includes/ScoreException.php#71 but note to fix this you'll also need to be setup to test this extension which might be a little trickier unless you are using something like MediaWiki vagrant.

Thank you! I've already set up a basic MediaWiki environment (not sure if it is using Vagrant or not) in my Linux laptop but I've yet to add any extensions to it beside WikiLove. I could do that but do I really need to in this specific case? The change looked pretty straightforward.

I could do that but do I really need to in this specific case? The change looked pretty straightforward.

Yes, particularly with what seem like straightforward changes. We need to verify the change works. It's possible for example the new styles are not being loaded in which case further changes would be required.

you'll also need to be setup to test this extension which might be a little trickier unless you are using something like MediaWiki vagrant.

Maybe it’s tricky to make this extension work, but as the goal is to produce an error, the easiest way is to not configure it properly, e.g. not install LilyPond. In that case, there will definitely be an error message, produced by this class. 🙂

Change 772903 abandoned by Klein Muçi:

[mediawiki/extensions/Score@master] Update errorbox class

Reason:

Apparently still not good enough to be helpful

https://gerrit.wikimedia.org/r/772903

Change 773551 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):

[mediawiki/extensions/Score@master] Fix use of errorbox

https://gerrit.wikimedia.org/r/773551

Tacsipacsi changed the task status from Open to In Progress.Mar 24 2022, 3:16 PM
Tacsipacsi claimed this task.
Tacsipacsi added a subscriber: Klein.

Change 773551 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Fix use of errorbox

https://gerrit.wikimedia.org/r/773551