Page MenuHomePhabricator
Create Task
Maniphest T304534

[EPIC] Make Wikibase work with Vue 3 (non-migration build)
Closed, ResolvedPublic
Actions

Description

This is the follow-up to T294465: Make Wikibase work with the Vue 3 migration build. While we are now using the migration build in production, we want to use pure Vue 3 at some point.

“Subprojects”:

For local testing, the MediaWiki core change to use pure Vue 3 may be useful.

Wikidata-related, but out of scope for this task, because not part of MediaWiki:

  • Mismatch Finder
  • Query Builder

Details

SubjectRepoBranchLines +/-
Fix languageAndLexicalCategoryWidget whitespace for Vue 3mediawiki/extensions/WikibaseLexememaster+10 -10
Add `compatConfig: { MODE: 3 },` to all componentsmediawiki/extensions/WikibaseLexememaster+9 -0
Fully migrate to Vue 3mediawiki/extensions/WikibaseLexememaster+490 -107
bridge: Vue3: add `compatConfig: { MODE: 3 }` to all componentsmediawiki/extensions/Wikibasemaster+35 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 23 2022, 3:57 PM
Lucas_Werkmeister_WMDE mentioned this in T294465: Make Wikibase work with the Vue 3 migration build.
Lucas_Werkmeister_WMDE added a project: [DEPRECATED] wdwb-tech.
gerritbot added a comment.Mar 23 2022, 3:58 PM

Change 773276 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] WIP: Fully migrate to Vue 3

https://gerrit.wikimedia.org/r/773276

gerritbot added a project: Patch-For-Review.Mar 23 2022, 3:58 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 23 2022, 3:59 PM
Lucas_Werkmeister_WMDE mentioned this in T289020: Migrate all extension/skin code to Vue 3.Mar 25 2022, 5:24 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 5 2022, 4:32 PM
gerritbot added a comment.Jun 13 2022, 4:31 PM

Change 792243 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] bridge: Vue3: add `compatConfig: { MODE: 3 }` to all components

https://gerrit.wikimedia.org/r/792243

gerritbot added a comment.Jun 15 2022, 9:01 AM

Change 792243 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] bridge: Vue3: add `compatConfig: { MODE: 3 }` to all components

https://gerrit.wikimedia.org/r/792243

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 15 2022, 10:00 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 18 2022, 3:13 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 18 2022, 3:17 PM
ItamarWMDE added a project: wmde-wikidata-tech.Oct 19 2022, 6:58 AM
Maintenance_bot moved this task from Inbox to Sorted Team A on the [DEPRECATED] wdwb-tech board.Oct 19 2022, 7:15 AM
ItamarWMDE renamed this task from Make Wikibase work with Vue 3 (non-migration build) to [EPIC] Make Wikibase work with Vue 3 (non-migration build).Oct 25 2022, 8:41 AM
ItamarWMDE moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.
ItamarWMDE added a project: Wikidata Dev Team.
ItamarWMDE moved this task from Incoming to Epics+STALLED on the Wikidata Dev Team board.
ItamarWMDE closed subtask T321096: [Spike] Figure out tasks for Lexeme Vue 3 migration as Resolved.Nov 1 2022, 3:38 PM
gerritbot added a comment.Nov 3 2022, 2:19 PM

Change 852893 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Add `compatConfig: { MODE: 3 },` to all components

https://gerrit.wikimedia.org/r/852893

gerritbot added a comment.Nov 3 2022, 4:47 PM

Change 773276 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Fully migrate to Vue 3

https://gerrit.wikimedia.org/r/773276

gerritbot added a comment.Nov 3 2022, 4:49 PM

Change 852893 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add `compatConfig: { MODE: 3 },` to all components

https://gerrit.wikimedia.org/r/852893

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 3 2022, 5:00 PM
gerritbot added a comment.Nov 4 2022, 9:56 AM

Change 853237 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Fix languageAndLexicalCategoryWidget whitespace for Vue 3

https://gerrit.wikimedia.org/r/853237

gerritbot added a comment.Nov 7 2022, 10:06 AM

Change 853237 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Fix languageAndLexicalCategoryWidget whitespace for Vue 3

https://gerrit.wikimedia.org/r/853237

Michael mentioned this in T322623: [SW] [LEX] [TECH] Lexeme Vue console warning "computed property "representations" is readonly.".Nov 8 2022, 11:42 AM
Michael added a subtask: T298797: Make Wikidata Bridge work with pure Vue 3.Nov 8 2022, 12:23 PM
Michael closed subtask T298797: Make Wikidata Bridge work with pure Vue 3 as Resolved.Nov 8 2022, 12:29 PM
Michael updated the task description. (Show Details)Nov 8 2022, 12:31 PM
Michael added a comment.Nov 8 2022, 12:50 PM

@Catrope With the next train, the last pieces of the Wikibase Vue 3 migration should be rolling out, and we're done migrating the all the Wikibase Vue production code on MediaWiki.

Also in this graph of tasks I can see T300176: Make Termbox SSR and CSR match exactly, but that is not directly related to the Vue 3 migration, I think, merely discovered during it.

As for non-production code, I can see two open tasks:

• Catrope added a comment.Nov 18 2022, 5:56 PM
In T304534#8379196, @Michael wrote:

@Catrope With the next train, the last pieces of the Wikibase Vue 3 migration should be rolling out, and we're done migrating the all the Wikibase Vue production code on MediaWiki.

Thank you so much!

Also in this graph of tasks I can see T300176: Make Termbox SSR and CSR match exactly, but that is not directly related to the Vue 3 migration, I think, merely discovered during it.

I agree

As for non-production code, I can see two open tasks:

All references to "vue" in package.json files in the Wikibase repo are to 3.x, none to 2.x, so I think this is done.

It's not blocking, but it would be nice to find a solution. I'll take a look at this again soon.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 25 2022, 3:21 PM
ItamarWMDE moved this task from Ongoing to Epics on the wmde-wikidata-tech board.Jan 20 2023, 8:29 AM
Michael added a comment.Jun 7 2023, 9:44 AM

I think there might only be some cleanup left here, that is: removing the compatConfig: { MODE: 3 }, and such again, once it no longer makes a difference.

Maintenance_bot removed a project: Patch-For-Review.Jun 7 2023, 10:10 AM
• Catrope closed this task as Resolved.Jun 12 2023, 5:05 PM
• Catrope claimed this task.
In T304534#8908758, @Michael wrote:

I think there might only be some cleanup left here, that is: removing the compatConfig: { MODE: 3 }, and such again, once it no longer makes a difference.

That's tracked separately in T289104, so I'm closing this task.

• Catrope removed • Catrope as the assignee of this task.Jun 12 2023, 5:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits