Page MenuHomePhabricator
Create Task
Maniphest T304601

Vector 2022 inconsistent style of "in other languages" when editing in old wikitext editor
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Msz2001
Mar 24 2022, 2:10 PM
Tags
Referenced Files
F35060048: Screen Shot 2022-04-20 at 7.10.57 AM.png
Apr 20 2022, 2:12 PM
F35060049: Screen Shot 2022-04-20 at 7.11.36 AM.png
Apr 20 2022, 2:12 PM
F35048601: Screen Shot 2022-04-12 at 3.35.12 PM.png
Apr 12 2022, 10:39 PM
F35048602: Screen Shot 2022-04-12 at 3.35.38 PM.png
Apr 12 2022, 10:39 PM
F35022389: image.png
Mar 24 2022, 3:11 PM
F35022385: Screen Shot 2022-03-24 at 8.08.33 AM.png
Mar 24 2022, 3:08 PM
F35022315: image.png
Mar 24 2022, 2:10 PM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
Msz2001
Robby

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Ensure you have enabled Vector 2022
  • Disable the 2017 wikitext editor (Beta features -> "New wikitext mode")
  • Navigate to any page
  • Click on the "Edit source code" tab

What happens?:

The "In other languages" header has inconsistent styling when compared to other headers.

What should have happened instead?:

At least: The header should have the same styling as other headers.

Better: The header should not be displayed because the links to other languages are not shown on an edit page.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

The problem occurs particulary for those who haven't enabled the 2017 wikitext editor but those who have done so will encounter this bug while viewing the source code of a protected page. This only occurs on Vector 2022 skin (on the legacy Vector the styling is consistent)

image.png (668×217 px, 20 KB)

QA Results - Beta

ACStatusDetails
1✅T304601#7849913

QA Results - Prod

ACStatusDetails
1✅T304601#7868157

Related Objects

Event Timeline

Msz2001 created this task.Mar 24 2022, 2:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2022, 2:10 PM
Jdlrobson added a project: Editing-team.Mar 24 2022, 3:08 PM
Jdlrobson subscribed.

Disable the 2017 wikitext editor

How do I do this? What preferences explicitly should I set here?

Screen Shot 2022-03-24 at 8.08.33 AM.png (926×1 px, 138 KB)

Msz2001 added a comment.Mar 24 2022, 3:11 PM

@Jdlrobson The 2017 Wikitext editor may be disabled in the Beta features tab. It's called there "New wikitext mode". Sorry for the confusion.

image.png (310×841 px, 37 KB)

Msz2001 updated the task description. (Show Details)Mar 24 2022, 3:12 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Editing-team.Mar 24 2022, 3:14 PM

I can replicate the same bad styling on Special:Preferences. I think this might relate to T304468 ?

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 24 2022, 3:14 PM
ovasileva triaged this task as Medium priority.Mar 24 2022, 5:19 PM
Robby subscribed.Mar 24 2022, 7:27 PM
Jdlrobson assigned this task to bwang.Apr 5 2022, 5:03 PM
Jdlrobson moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Should be fixed by T304468 which Bernard is working on so moving to blocked on others.

Jdlrobson reassigned this task from bwang to Edtadros.Apr 8 2022, 11:52 PM
Jdlrobson moved this task from Blocked on Others to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: bwang.
Edtadros reassigned this task from Edtadros to Jdlrobson.Apr 12 2022, 10:39 PM
Edtadros subscribed.

Test Result - Beta

Status: ❓
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Ensure you have enabled Vector 2022
Disable the 2017 wikitext editor (Beta features -> "New wikitext mode")
Navigate to any page
Click on the "Edit source code" tab
What happens?:

✅ AC1: At least: The header should have the same styling as other headers.

Screen Shot 2022-04-12 at 3.35.12 PM.png (876×1 px, 244 KB)

Screen Shot 2022-04-12 at 3.35.38 PM.png (878×1 px, 249 KB)

❓ Better: The header should not be displayed because the links to other languages are not shown on an edit page.
@Jdlrobson, is the "better" option in the scope of the patch, or just the "at least" above? If it's just the latter then this is a pass.

Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 12 2022, 10:43 PM

The least is the scope. The languages are shown here because of access to the cog. Removing that on the editing page would likely annoy a few people.

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Apr 19 2022, 5:06 PM

Should be testable in production now.

ovasileva claimed this task.Apr 19 2022, 5:28 PM
Edtadros added a comment.Apr 20 2022, 2:12 PM

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Ensure you have enabled Vector 2022
Disable the 2017 wikitext editor (Beta features -> "New wikitext mode")
Navigate to any page
Click on the "Edit source code" tab
What happens?:

✅ AC1: At least: The header should have the same styling as other headers.

Screen Shot 2022-04-20 at 7.11.36 AM.png (1×1 px, 475 KB)

Screen Shot 2022-04-20 at 7.10.57 AM.png (1×1 px, 442 KB)

Edtadros updated the task description. (Show Details)Apr 20 2022, 2:15 PM
ovasileva closed this task as Resolved.Apr 21 2022, 10:55 AM
ovasileva moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Looks good, resolving!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL