Page MenuHomePhabricator

Conduct an audit of time stamp formats in Android App
Closed, ResolvedPublic

Description

Background

The Android team is implementing a number of improvements to talk pages. The improvements includes changes in the visual design. It is not clear that the date format in the new designs corresponds with the date format in the rest of the app. For that reason we want to conduct an audit of the various date formats in the Android app.

User Stories

As an Android app user, I want to have consistent date formatting, so that I do not have the cognitive load of understanding different time stamp formats.

Design
N/A

Instructions
Have a look at the code and record date formats and the location in the app of the format


APK: https://github.com/wikimedia/apps-android-wikipedia/pull/3438

Event Timeline

JTannerWMF created this task.
JTannerWMF moved this task from Needs Triage to Up Next on the Wikipedia-Android-App-Backlog board.
Screenshot_20220331-162800_Wikipedia Dev.jpg (2×1 px, 551 KB)
One this day card
Screenshot_20220331-162747_Wikipedia Dev.jpg (2×1 px, 491 KB)
Most read list
Screenshot_20220331-163030_Wikipedia Dev.jpg (2×1 px, 358 KB)
Revision history stats (long press on stats graph)
Screenshot_20220331-162809_Wikipedia Dev.jpg (2×1 px, 485 KB)
On this day page
Screenshot_20220331-162852_Wikipedia Dev.jpg (2×1 px, 331 KB)
Edits page
Screenshot_20220331-163103_Wikipedia Dev.jpg (2×1 px, 330 KB)
Diff page
Screenshot_20220331-163026_Wikipedia Dev.jpg (2×1 px, 342 KB)
Revision history
Screenshot_20220331-162946_Wikipedia Dev.jpg (2×1 px, 293 KB)
Talk page
Screenshot_20220331-162928_Wikipedia Dev.jpg (2×1 px, 341 KB)
Contribution detail
Screenshot_20220331-162834_Wikipedia Dev.jpg (2×1 px, 218 KB)
Reading list overflow menu
Screenshot_20220331-162901_Wikipedia Dev.jpg (2×1 px, 278 KB)
Contributions page
Screenshot_20220331-163058_Wikipedia Dev.jpg (2×1 px, 328 KB)
Notifications page
Screenshot_20220331-163051_Wikipedia Dev.jpg (2×1 px, 250 KB)
Watchlist page
Screenshot_20220331-162845_Wikipedia Dev.jpg (2×1 px, 208 KB)
History page

Please note that the date format may be changed by the system due to different locations/languages.

Most views are using either MMM dd, YYYY or MM/dd/YYYY

Please let me know if you need more information.

Thanks for this @cooltey.

Let’s follow the time format of the user’s device.

What are the options we have to accomplish this? Is there a foreseen 'Android' way or do we need to review regions manually?

Also, there’s nuance to it, as sometimes:

  • We apply *more visual hierarchy* on the date (e.g. 'Revision History' or 'Explore')
  • We have *more space* to display detailed infos
  • We don’t need certain infos, e.g. the year in 'On this day'

IMO 'On this day' needs to be excluded from this discussion as it’s deliberately designed to surface the day in the year.

In the screens you’ve posted, I spotted the following formats:

  • Mar 30, 2022 (Top read, Contributions page, Notifications, History)
  • March 31 (Revision history, Watchlist)
  • Mar 18, 2022 | 21:33 (Compare revisions, User talk)
  • Mar 31, 2022, 16:26 (Reading list overflow menu)
  • May 24, 2021 / 16:01 (Contribution detail)
  • 03/28/2022 (Edits)
  • 16:20 (Watchlist)

I suggest to narrow it down to:

  • Apr 26, 2022
  • 16:55, Apr 26, 2022 *
  • 04/26/2022
  • 16:55 *

* Consider the user’s 24 hour system/OS preference:

Screenshot_20220426-161745.png (2×1 px, 179 KB)

To summarize, please apply the following changes:

  • Mar 30, 2022 (Top read, Contributions page, Notifications, History) → Keep
  • March 31 (Revision history, Watchlist) → Change to Mar 30, 2022
  • Mar 18, 2022 | 21:33 (Compare revisions, User talk) → Change to 21:33, Mar 18, 2022
  • Mar 31, 2022, 16:26 (Reading list overflow menu) → Change to 16:26, Mar 31, 2022
  • May 24, 2021, 16:01 (Contribution detail) → Change to 16:26, May 24, 2021
  • 03/28/2022 (Edits) → Keep
  • 16:20 (Watchlist) → Keep

And a minor update:

Please apply the extended format (16:26, Mar 31, 2022) to this tooltip to improve readability 👇

Screenshot_20220331-163030_Wikipedia_Dev.jpg (2×1 px, 422 KB)

There is another new time format being introduced in the updated Talk interface, namely:

image.png (528×671 px, 58 KB)

Shall we make it consistent with the others you've mentioned? i.e. "Jan 16, 2022, 17:00"?

@Dbrant let’s chat about this in planning tonight 🕳🐇

Task updated per discussion in the planning meeting ✅ → moving it back to the did not pass design column.

Hi @scblr

Please check the APK in the ticket description.

Thanks @cooltey – two things:

01) Seems like the tooltip in edit history outputs the current hour twice in every case? The from time should be different (time of the article’s creation), no?

Screenshot_20220509-111524.png (2×1 px, 262 KB)

02) Seems like the app does not yet respect the device’s 24 hour time setting (also tried restarting the app), check out the video below:

https://www.dropbox.com/s/ml9tto1jct4rce6/screen-20220509-112143.mp4?dl=0

Hi @scblr

01) Seems like the tooltip in edit history outputs the current hour twice in every case? The from time should be different (time of the article’s creation), no?

Due to the restriction of the metrics API, the maximum time range is 1 year. Would it be possible to change it to MM dd, YYYY?

02) Seems like the app does not yet respect the device’s 24 hour time setting (also tried restarting the app), check out the video below:

I updated the time setting in the revision history and the watchlist, but it will not be updated automatically unless you refresh it manually after you back from the device setting page.

Sure @cooltey — moving this to Code Review ✅

Looking good on my end. Testing on 2.7.50404-r-2022-06-07

The only thing I noticed is that in most places the hours/minutes are always in 24 hour format even if the device is set to 12 hour format.

Screenshot_20220609-150308.jpg (2×1 px, 152 KB)

Screenshot_20220609-150405.jpg (2×1 px, 252 KB)

Screenshot_20220609-150352.jpg (2×1 px, 402 KB)

Screenshot_20220609-150605.jpg (2×1 px, 380 KB)

Hi @scblr
Please see the screenshots below, I have updated all places where we show the date and time in the app.

Screenshot_20220621-171228_Wikipedia Dev.jpg (2×1 px, 351 KB)
Screenshot_20220621-171255_Wikipedia Dev.jpg (2×1 px, 294 KB)
Screenshot_20220621-171249_Wikipedia Dev.jpg (2×1 px, 277 KB)
Screenshot_20220621-171222_Wikipedia Dev.jpg (2×1 px, 132 KB)
Screenshot_20220621-171232_Wikipedia Dev.jpg (2×1 px, 141 KB)

looks good so far @cooltey – one question related to talk page signatures:

Screenshot_20220621-171232_Wikipedia_Dev.jpg (2×1 px, 191 KB)

  • not quite sure what to do here – is there a way to achieve consistency between the header of the message and signature?
  • I’d still be in favor of not showing the signature (since it’s already visible in the header) – but from what I understood, this is difficult to achieve, right?

thanks!

Hi @scblr

I’d still be in favor of not showing the signature (since it’s already visible in the header) – but from what I understood, this is difficult to achieve, right?

As mentioned in the meeting, the timestamp is a part of each message, so it is not recommended to manually update its format.

That sounds good @cooltey,and let’s work towards having more structured data in the future, that only features one signature; the one in the header of the message! 🚀