Page MenuHomePhabricator

Flag exemptions in reviewer interface
Closed, ResolvedPublic

Description

Typically applications will only appear from blocked users when the user has already received an exemption. However, there are edge cases when that will not be true - eg if they are blocked between submitting an app and the app being reviewed. For that reason, it would be worthwhile to flag in the reviewer interface when a block has been exempted. This could be done using the existing criteria display, eg
Is not blocked on any project? No (exempted)

Event Timeline

Before

Screenshot 2023-09-09 at 15.13.40.png (878×3 px, 223 KB)

After

Screenshot 2023-09-09 at 15.19.01.png (368×2 px, 102 KB)

Perhaps not ideal - we should maybe be clarifying/removing the 'Satisfies Terms of Use' row too in the specific case that a block is the only disqualifying factor, but I didn't want to overcomplicate things.

PR: https://github.com/WikipediaLibrary/TWLight/pull/1198

I merged the patch that handles the block exemption since it handles the block status exemption just fine. I think it might be worth adding this language for any "No" on superuser accounts and accounts with ignore_wp_elibile. It might also be worth noting super user status like we do coordinator status at the bottom.

Moving this to done for us to clear out at our next RTL unless my recommendations get any interest.

I merged the patch that handles the block exemption since it handles the block status exemption just fine. I think it might be worth adding this language for any "No" on superuser accounts and accounts with ignore_wp_elibile. It might also be worth noting super user status like we do coordinator status at the bottom.

This makes sense, but I'm not sure it's a priority - we don't ever have coordinators reviewing applications from superusers (except when it's very obvious they're a superuser - e.g. self-review) and I don't think there are any users with ignore_wp_elibile outside of unique testing scenarios unrelated to applications. Is there a benefit I'm not seeing?

Maybe it's something for the backlog, then. I was looking at this as a generic "editor profiles don't communicate exemption status" problem. It seems like an oversight that we communicate eligibility without including those exemptions. For example, is there an at-a-glance way for editors to see their own exemptions on their profile pages?