Page MenuHomePhabricator
Create Task
Maniphest T304667

[QA task] Checking if the warning is present when a user leaves editor
Closed, ResolvedPublic
Actions

Description

Based on T294463: Leaving VE for another page doesn't trigger the exit confirmation (specifically, @Esanders comment on the ticket), the following was tested for Suggested (and Structured) edits behavior.

Tests:
(1) Preferences-Editing option "Warn me when I leave an edit page with unsaved changes" is ON/OFF
(2) Edits are made on Unstructured/Structured tasks (not published)
(3) A user with unsaved edits clicks on the tabs (Page, Discussion, View history) or links in the side bar/tool bar.
(4) A user with unsaved edits clicks Esc or Reload

What was checked:

  • is the warning present?
  • is user able to navigate/switch back into Suggestions mode after the above actions in (3) or (4)?
  • have the unsaved been changes recovered after a user returns to the Edit mode

testwiki wmf.4 - the current production
"Warn me when I leave an edit page with unsaved changes" - ON (default)

clicking on ->PageReadDiscussionView historySidebar linksEscReload
Unstructured editAbandon dialogAbandon dialogBrowser warningBrowser warningBrowser warningAbandon dialogBrowser warning
Add linkAbandon dialogAbandon dialogBrowser warningBrowser warningBrowser warningAbandon dialogBrowser warning
Add imageAbandon dialogAbandon dialogBrowser warningBrowser warningBrowser warningAbandon dialogBrowser warning

testwiki wmf.4 - the current production
"Warn me when I leave an edit page with unsaved changes" - OFF

clicking on ->PageReadDiscussionView historySidebar linksEscReload
Unstructured editAbandon dialogAbandon dialogNo warning. The edits are recovered upon returning.No warning. The edits are recovered upon returning.No warning. The edits are recovered upon returning.Abandon dialogNo warning. The edits are recovered upon returning.
Add linkAbandon dialogAbandon dialogNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedAbandon dialogNo warning; Suggestions mode is recovered upon returning; edits are discarded
Add imageAbandon dialogAbandon dialogNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is lost upon returning; edits are discardedAbandon dialogNo warning; Suggestions mode is recovered upon returning; edits are discarded

betalabs - with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/773246/
"Warn me when I leave an edit page with unsaved changes" - ON (default)

clicking on ->PageReadDiscussionView historySidebar linksEscReload
Unstructured editAbandon dialogAbandon dialogBrowser warningBrowser warningBrowser warningAbandon dialogBrowser warning
Add linkAbandon dialogAbandon dialogBrowser warningBrowser warningBrowser warningAbandon dialogBrowser warning
Add imageAbandon dialogAbandon dialogBrowser warningBrowser warningBrowser warningAbandon dialogBrowser warning

betalabs - with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/773246/
"Warn me when I leave an edit page with unsaved changes" - OFF

clicking on ->PageReadDiscussionView historySidebar linksEscReload
Unstructured editNo warning; edits are discardedNo warning; edits are discardedNo warning. The edits are recovered upon returningNo warning. The edits are recovered upon returningNo warning. The edits are recovered upon returningNo warning. The edits are not recovered upon returning.No warning. The edits are recovered upon returning
Add linkNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is lost upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; upon reload, a page stays in Suggestions mode; edits are discarded
Add imageNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; Suggestions mode is recovered upon returning; edits are discardedNo warning. The edits are not recovered upon returning. The Suggestion mode is lost.No warning; Suggestions mode is recovered upon returning; edits are discardedNo warning; upon reload, a page stays in Suggestions mode; edits are discarded

Related Objects

Event Timeline

Etonkovidova created this task.Mar 25 2022, 1:25 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 25 2022, 1:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova mentioned this in T294463: Leaving VE for another page doesn't trigger the exit confirmation.Mar 25 2022, 1:32 AM
kostajh added a subscriber: RHo.Mar 25 2022, 10:49 AM

@RHo I think this is mainly for your review; is there anything that looks out of place here? For context, @Etonkovidova made this helpful table (thank you!) in response to changes made to VE on how abandoning an edit works based on what the user has in their preferences (https://phabricator.wikimedia.org/T294463#7800239).

Etonkovidova updated the task description. (Show Details)Mar 25 2022, 5:08 PM
Etonkovidova moved this task from Inbox to Needs Discussion on the Growth-Team board.Mar 25 2022, 5:18 PM

To summarize

  • To have users turning OFF the setting: "Warn me when I leave an edit page with unsaved changes" is an edge case (especially in the context of newcomers workflows)
  • There are two points to consider: (1) Structured Edits are not recoverable as VE edits which might be confusing to editors. (2) There are cases (highlighted) where the Suggestions mode is lost - when a user navigates away and then returns to a structured task to find that not only their edits are lost but the Suggestions mode is not present.

Could be there additional warning to users navigating away from Suggestions mode?

• mewoph added a comment.Mar 30 2022, 11:23 AM

Related task: T296407: Structured Task: Easy return to Special:Homepage

RHo closed this task as Resolved.Apr 1 2022, 10:10 AM
RHo claimed this task.
In T304667#7807073, @Etonkovidova wrote:

To summarize

  • To have users turning OFF the setting: "Warn me when I leave an edit page with unsaved changes" is an edge case (especially in the context of newcomers workflows)
  • There are two points to consider: (1) Structured Edits are not recoverable as VE edits which might be confusing to editors. (2) There are cases (highlighted) where the Suggestions mode is lost - when a user navigates away and then returns to a structured task to find that not only their edits are lost but the Suggestions mode is not present.

Could be there additional warning to users navigating away from Suggestions mode?

Thanks for the extensive testing on this @Etonkovidova. I do think that given the highlighted cases are all only when someone has turned off the default on preference to "Warn me when I leave an edit page with unsaved changes", that we should respect this preference and not add an extra warning. This is especially since newcomers would be very unlikely to change the default preference that would lead to no warnings.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL