Page MenuHomePhabricator
Create Task
Maniphest T304704

Refactor GeoShape code to work nicely for GeoPoints
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Working on T302290 we think it makes sense to refactor the GeoShape code to work nicely with GeoPoints.

  • Change BBtry to async await
  • Refactor to use a common super class

Details and brainstorming

Possible follow ups:

  • Maybe get rid of sanitize-mapdata API call
  • Move localization responsibility out of JsonConfig extension

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Refactoring Geoshapesmediawiki/services/kartotherianmaster+142 -96
Split handleResult in its own functionmediawiki/services/kartotherianmaster+31 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

lilients_WMDE created this task.Mar 25 2022, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2022, 3:08 PM
gerritbot added a comment.Mar 25 2022, 3:08 PM

Change 773785 had a related patch set uploaded (by Svantje Lilienthal; author: Andrew-WMDE):

[mediawiki/services/kartotherian@master] Begin refactoring Geoshapes and Geopoints

https://gerrit.wikimedia.org/r/773785

gerritbot added a project: Patch-For-Review.Mar 25 2022, 3:08 PM
lilients_WMDE removed a project: Patch-For-Review.Mar 25 2022, 3:09 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-03-16 board.Mar 25 2022, 3:12 PM
gerritbot added a comment.Mar 28 2022, 1:17 PM

Change 773785 had a related patch set uploaded (by Svantje Lilienthal; author: Andrew-WMDE):

[mediawiki/services/kartotherian@master] Refactoring Geoshapes and Geopoints

https://gerrit.wikimedia.org/r/773785

gerritbot added a project: Patch-For-Review.Mar 28 2022, 1:17 PM

Change 774472 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/services/kartotherian@master] Split handleResult in its own function

https://gerrit.wikimedia.org/r/774472

lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-03-16 board.Mar 28 2022, 2:02 PM
lilients_WMDE set the point value for this task to 5.
awight added a project: WMDE-TechWish-Sprint-2022-03-30.Mar 30 2022, 8:10 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-03-30 board.Mar 30 2022, 8:10 AM
gerritbot added a comment.Mar 30 2022, 4:36 PM

Change 774472 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Split handleResult in its own function

https://gerrit.wikimedia.org/r/774472

lilients_WMDE mentioned this in rMSKA68315c9ec29e: Split handleResult in its own function.Mar 30 2022, 4:37 PM
lilients_WMDE moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Apr 5 2022, 8:07 AM
gerritbot added a comment.Apr 7 2022, 10:14 AM

Change 773785 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Refactoring Geoshapes

https://gerrit.wikimedia.org/r/773785

WMDE-Fisch mentioned this in rMSKAe5b4c51eaeb0: Refactoring Geoshapes.Apr 7 2022, 10:17 AM
WMDE-Fisch updated the task description. (Show Details)Apr 7 2022, 10:57 AM
WMDE-Fisch updated the task description. (Show Details)Apr 7 2022, 11:05 AM
lilients_WMDE moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-03-30 board.Apr 8 2022, 8:55 AM
thiemowmde closed this task as Resolved.Apr 13 2022, 12:05 PM
thiemowmde claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits